Page MenuHomePhabricator
Create Task
Maniphest T168856

Cannot upload SVG saved in Dia: "Cannot upload SVG files that contain a non-standard DTD declaration."
Closed, ResolvedPublic
Actions

Description

tables.svg18 KBDownload

Attempting to upload an SVG file exported by dia produces the following message.

Cannot upload SVG files that contain a non-standard DTD declaration.

Sample file attached.

Details

SubjectRepoBranchLines +/-
Allow SVGs using an older proposed recommendation DTDmediawiki/coreREL1_27+20 -1
Allow SVGs using an older proposed recommendation DTDmediawiki/coreREL1_28+9 -1
Allow SVGs using an older proposed recommendation DTDmediawiki/coremaster+3 -1
Allow SVGs using an older proposed recommendation DTDmediawiki/coreREL1_29+3 -1
Customize query in gerrit

Event Timeline

Dendrite.sysex created this task.Jun 26 2017, 12:40 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 26 2017, 12:40 PM
Dendrite.sysex updated the task description. (Show Details)Jun 26 2017, 12:44 PM
Aklapper renamed this task from SVG whitelist blackballs SVG uploads from dia to Cannot upload SVG saved in Dia: "Cannot upload SVG files that contain a non-standard DTD declaration.".Jun 26 2017, 1:02 PM
Aklapper added a project: MediaWiki-Uploading.
Restricted Application added a project: Multimedia. · View Herald TranscriptJun 26 2017, 1:02 PM
dr0ptp4kt triaged this task as Medium priority.Jun 26 2017, 3:15 PM
dr0ptp4kt moved this task from Untriaged to Next up on the Multimedia board.
matmarex subscribed.Jun 26 2017, 4:01 PM

MediaWiki accepts the following DTD declarations: (from UploadBase::checkSvgExternalDTD())

Your document is using:

This appears to be an earlier draft of the SVG DTD declaration. Why is Dia using this instead of the final one?

Bawolff subscribed.Jun 26 2017, 8:05 PM

I think its fine to whitelist that decleration too

gerritbot subscribed.Jun 27 2017, 1:48 PM

Change 361668 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/core@master] Allow SVGs using an older proposed recommendation DTD

https://gerrit.wikimedia.org/r/361668

gerritbot added a project: Patch-For-Review.Jun 27 2017, 1:48 PM
matthiasmullie subscribed.Jun 27 2017, 1:49 PM

We could allow this DTD, but can anyone check if this DTD is still used in recent Dia versions (@Dendrite.sysex?)?
If not, we should probably inform them. (for some reason, I can't get Dia running on my machine)

matthiasmullie lowered the priority of this task from Medium to Low.Jun 27 2017, 1:54 PM
matthiasmullie moved this task from Next up to Needs code review on the Multimedia board.
Aklapper added a comment.Jun 27 2017, 3:38 PM
In T168856#3382241, @matthiasmullie wrote:

We could allow this DTD, but can anyone check if this DTD is still used in recent Dia versions (@Dendrite.sysex?)?

Looks like: https://git.gnome.org/browse/dia/tree/plug-ins/svg/render_svg.c#n264 (and no real development in the last 30 months).

If not, we should probably inform them. (for some reason, I can't get Dia running on my machine)

Done: https://bugzilla.gnome.org/show_bug.cgi?id=784253

gerritbot added a comment.Jun 28 2017, 12:53 AM

Change 361668 merged by Brian Wolff:
[mediawiki/core@master] Allow SVGs using an older proposed recommendation DTD

https://gerrit.wikimedia.org/r/361668

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)).Jun 28 2017, 1:00 AM
Krinkle closed this task as Resolved.Jun 28 2017, 1:10 AM
Krinkle assigned this task to Bawolff.
gerritbot added a comment.Jul 13 2017, 6:23 PM

Change 365077 had a related patch set uploaded (by Brian Wolff; owner: Matthias Mullie):
[mediawiki/core@REL1_29] Allow SVGs using an older proposed recommendation DTD

https://gerrit.wikimedia.org/r/365077

gerritbot added a comment.Jul 13 2017, 6:32 PM

Change 365077 merged by jenkins-bot:
[mediawiki/core@REL1_29] Allow SVGs using an older proposed recommendation DTD

https://gerrit.wikimedia.org/r/365077

ReleaseTaggerBot added a project: MW-1.29-release-notes.Jul 13 2017, 7:00 PM
gerritbot added a comment.Jul 17 2017, 6:44 AM

Change 365552 had a related patch set uploaded (by Brian Wolff; owner: Matthias Mullie):
[mediawiki/core@REL1_28] Allow SVGs using an older proposed recommendation DTD

https://gerrit.wikimedia.org/r/365552

gerritbot added a comment.Jul 17 2017, 6:47 AM

Change 365553 had a related patch set uploaded (by Brian Wolff; owner: Matthias Mullie):
[mediawiki/core@REL1_27] Allow SVGs using an older proposed recommendation DTD

https://gerrit.wikimedia.org/r/365553

gerritbot added a comment.Jul 17 2017, 6:57 AM

Change 365552 merged by jenkins-bot:
[mediawiki/core@REL1_28] Allow SVGs using an older proposed recommendation DTD

https://gerrit.wikimedia.org/r/365552

ReleaseTaggerBot added a project: MW-1.28-release-notes.Jul 17 2017, 7:00 AM
gerritbot added a comment.Jul 17 2017, 7:14 AM

Change 365553 merged by jenkins-bot:
[mediawiki/core@REL1_27] Allow SVGs using an older proposed recommendation DTD

https://gerrit.wikimedia.org/r/365553

ReleaseTaggerBot added a project: MW-1.27-release-notes.Jul 17 2017, 8:00 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL