Page MenuHomePhabricator

Work out how to fix mw.widgets.SearchInputWidget's inheritance
Closed, ResolvedPublic8 Story Points

Description

Right now mw.widgets.SearchInputWidget inherits from mw.widgets.TitleInputWidget, which inherits from OO.ui.TextInputWidget, but due to T130434 we want mw.widgets.SearchInputWidget to inherit from OO.ui.SearchInputWidget. Meh.

Event Timeline

For reference, the current state is the result of T148471 and https://gerrit.wikimedia.org/r/#/c/342718/ (e218f21d444dbdf32b6541ff1a54fca2cf8776f8).

Instead of inheriting from mw.widgets.TitleInputWidget, we can just use the mw.widgets.TitleWidget mixin. mw.widgets.SearchInputWidget already overrides most of the TitleInputWidget-specific behaviors.

Instead of inheriting from mw.widgets.TitleInputWidget, we can just use the mw.widgets.TitleWidget mixin. mw.widgets.SearchInputWidget already overrides most of the TitleInputWidget-specific behaviors.

That could work, I suppose?

Change 362283 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@master] Make mw.widgets.SearchInputWidget extend OO.ui.SearchInputWidget

https://gerrit.wikimedia.org/r/362283

Jdforrester-WMF closed this task as Resolved.Jun 30 2017, 11:15 AM
Jdforrester-WMF assigned this task to matmarex.
Jdforrester-WMF removed a project: Patch-For-Review.

Thank you!

Change 362283 merged by jenkins-bot:
[mediawiki/core@master] Make mw.widgets.SearchInputWidget extend OO.ui.SearchInputWidget

https://gerrit.wikimedia.org/r/362283