Work out how to fix mw.widgets.SearchInputWidget's inheritance
Closed, ResolvedPublic8 Estimated Story Points
Actions

Assigned To

Authored By

	Jdforrester-WMF
	Jun 29 2017, 10:26 AM

Description

Right now mw.widgets.SearchInputWidget inherits from mw.widgets.TitleInputWidget, which inherits from OO.ui.TextInputWidget, but due to T130434 we want mw.widgets.SearchInputWidget to inherit from OO.ui.SearchInputWidget. Meh.

Details

	Subject	Repo	Branch	Lines +/-
	Make mw.widgets.SearchInputWidget extend OO.ui.SearchInputWidget	mediawiki/core	master	+51 -82

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		• Prtksxna	T130434 Break up TextInputWidget
		Resolved		matmarex	T169194 Work out how to fix mw.widgets.SearchInputWidget's inheritance

Event Timeline

Jdforrester-WMF created this task.Jun 29 2017, 10:26 AM

For reference, the current state is the result of T148471 and https://gerrit.wikimedia.org/r/#/c/342718/ (e218f21d444dbdf32b6541ff1a54fca2cf8776f8).

Instead of inheriting from mw.widgets.TitleInputWidget, we can just use the mw.widgets.TitleWidget mixin. mw.widgets.SearchInputWidget already overrides most of the TitleInputWidget-specific behaviors.

In T169194#3391492, @matmarex wrote:

Instead of inheriting from mw.widgets.TitleInputWidget, we can just use the mw.widgets.TitleWidget mixin. mw.widgets.SearchInputWidget already overrides most of the TitleInputWidget-specific behaviors.

That could work, I suppose?

Change 362283 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@master] Make mw.widgets.SearchInputWidget extend OO.ui.SearchInputWidget

https://gerrit.wikimedia.org/r/362283

gerritbot added a project: Patch-For-Review.Jun 29 2017, 8:23 PM