Page MenuHomePhabricator
Create Task
Maniphest T170133

Remove strike-through when hovering/tapping over deleted content in a visual diff
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Removing the strike-through improves readability:

Hover-strikethrough.gif (140×250 px, 39 KB)

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (b76c9699b)mediawiki/extensions/VisualEditormaster+1 -1
DiffElement: hide strikethrough on hoverVisualEditor/VisualEditormaster+3 -0
Customize query in gerrit

Related Objects

Event Timeline

• Prtksxna created this task.Jul 10 2017, 11:32 AM
Restricted Application added a project: VisualEditor. · View Herald TranscriptJul 10 2017, 11:32 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot subscribed.Jul 10 2017, 1:49 PM

Change 364202 had a related patch set uploaded (by DLynch; owner: DLynch):
[VisualEditor/VisualEditor@master] DiffElement: hide strikethrough on hover

https://gerrit.wikimedia.org/r/364202

gerritbot added a project: Patch-For-Review.Jul 10 2017, 1:49 PM
• Deskana awarded a token.Jul 10 2017, 1:55 PM
• Deskana triaged this task as Medium priority.Jul 10 2017, 1:58 PM
• Deskana moved this task from To Triage to TR6: Visual diffs on the VisualEditor board.
gerritbot added a comment.Jul 10 2017, 3:24 PM

Change 364202 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] DiffElement: hide strikethrough on hover

https://gerrit.wikimedia.org/r/364202

gerritbot added a comment.Jul 10 2017, 3:34 PM

Change 364229 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (b76c9699b)

https://gerrit.wikimedia.org/r/364229

gerritbot added a comment.Jul 10 2017, 4:03 PM

Change 364229 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (b76c9699b)

https://gerrit.wikimedia.org/r/364229

Jdforrester-WMF closed this task as Resolved.Jul 10 2017, 4:12 PM
Jdforrester-WMF assigned this task to DLynch.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF edited projects, added MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)); removed Patch-For-Review.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJul 10 2017, 4:12 PM
• Prtksxna added a comment.Jul 10 2017, 5:12 PM

How is this going to translate on mobile?

In https://www.mediawiki.org/wiki/User:Prtksxna/VeDiff @Esanders said:

Seems reasonable - we should also have a touch input equivalent.

Ryasmeen added projects: Verified, Verified-in-Phase0.Jul 12 2017, 1:52 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL