Track duplicate parses on page save
Closed, DeclinedPublic
Actions

Assigned To

Authored By

	aaron
	Aug 9 2017, 7:21 PM

Description

Given the lazy loading of parsing, it's hard to track what is responsible for duplicate parses during editing. Several hooks (AbuseFilter, SpamBlacklist) and doEditContent() itself call getParserOutput(). The flamegraphs shows the parse happening via most of those hooks, but it doesn't distinguish the "first to call" effect from actual duplicate parses (due to things in AF or vary-* flags from REVISIONID and such).

It would be nice to have a statsd gauge for tracking parses per save to aid in looking for regressions.

Details

	Subject	Repo	Branch	Lines +/-
	Track duplicate parses on page save via logging	mediawiki/core	master	+16 -0

Customize query in gerrit

Related Objects

Mentioned In: T288707: Detect and monitor against multiple Parser invocation during edit requests
T198483: Save Timing increased 50% since 2018-06-28 20:53

Event Timeline

aaron created this task.Aug 9 2017, 7:21 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 9 2017, 7:21 PM

Krinkle subscribed.Aug 9 2017, 7:43 PM

aaron triaged this task as Medium priority.Aug 16 2017, 6:53 PM

aaron moved this task from Inbox, needs triage to Doing (old) on the Performance-Team board.

aaron moved this task from Doing (old) to To-do: Goals prioritized current Quarter on the Performance-Team board.Aug 23 2017, 7:09 PM

• Imarlier moved this task from To-do: Goals prioritized current Quarter to Backlog: Maintenance, non-prioritized on the Performance-Team board.Jan 18 2018, 4:04 PM

Start by adding a log message when this is detected.

Change 444264 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/core@master] [WIP] Track duplicate parses on page save via logging

https://gerrit.wikimedia.org/r/444264

gerritbot added a project: Patch-For-Review.Jul 6 2018, 7:11 PM

Krinkle mentioned this in T198483: Save Timing increased 50% since 2018-06-28 20:53.Jul 6 2018, 10:27 PM

Change 444264 abandoned by Aaron Schulz:
Track duplicate parses on page save via logging

https://gerrit.wikimedia.org/r/444264

Closing per comments on patch about MCR refactor.

Legoktm mentioned this in T288707: Detect and monitor against multiple Parser invocation during edit requests.Aug 12 2021, 6:32 AM