Page MenuHomePhabricator

Notice: Cannot access property on non-object in /srv/mediawiki/php-1.30.0-wmf.13/includes/specials/SpecialDoubleRedirects.php on line 143
Closed, ResolvedPublicPRODUCTION ERROR

Description

Notice: Cannot access property on non-object in /srv/mediawiki/php-1.30.0-wmf.13/includes/specials/SpecialDoubleRedirects.php on line 143

Event Timeline

Can you provide more details from the log? Like which object and what property are mentioned?

I think moving line 143 back to the top of the function might solve this (moving it down was not the best idea).

Can you provide more details from the log? Like which object and what property are mentioned?

Don't need it, it's obvious from the code -- it's $result https://github.com/wikimedia/mediawiki/blob/master/includes/specials/SpecialDoubleRedirects.php#L143

$titleA = Title::makeTitle( $result->namespace, $result->title );

Change 371143 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] SpecialDoubleRedirects: Fix undefined '$result->namespace' notice

https://gerrit.wikimedia.org/r/371143

Krinkle triaged this task as Medium priority.Aug 10 2017, 8:30 PM

Change 371203 had a related patch set uploaded (by 20after4; owner: Krinkle):
[mediawiki/core@wmf/1.30.0-wmf.13] SpecialDoubleRedirects: Fix undefined '$result->namespace' notice

https://gerrit.wikimedia.org/r/371203

Change 371203 merged by jenkins-bot:
[mediawiki/core@wmf/1.30.0-wmf.13] SpecialDoubleRedirects: Fix undefined '$result->namespace' notice

https://gerrit.wikimedia.org/r/371203

Mentioned in SAL (#wikimedia-operations) [2017-08-10T22:31:03Z] <twentyafterfour@tin> Synchronized php-1.30.0-wmf.13/includes/specials/SpecialDoubleRedirects.php: Hopefully fix T173045 (duration: 00m 48s)

Change 371143 merged by jenkins-bot:
[mediawiki/core@master] SpecialDoubleRedirects: Fix undefined '$result->namespace' notice

https://gerrit.wikimedia.org/r/371143

Krinkle removed a project: Patch-For-Review.

Nope. Warnings stopped August 10.

Screen Shot 2017-08-12 at 15.04.22.png (500×2 px, 92 KB)

mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:10 PM