Page MenuHomePhabricator

UploadWizard generates wikitext like '{{83|...}}' (with different numbers) instead of '{{en|...}}' in file descriptions
Closed, ResolvedPublic

Description

UploadWizard generates wikitext like {{83|...}} (with different numbers) instead of {{en|...}} in file descriptions.

Example: https://commons.wikimedia.org/w/index.php?title=File%3ABrittany_country_code_sticker_on_motorbike.jpg&type=revision&diff=255636909&oldid=255636438 ?

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 372417 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/UploadWizard@master] Preserve array keys (language keys) when sorting the language dropdown

https://gerrit.wikimedia.org/r/372417

Change 372417 merged by jenkins-bot:
[mediawiki/extensions/UploadWizard@master] Preserve array keys (language keys) when sorting the language dropdown

https://gerrit.wikimedia.org/r/372417

After this is deployed, we'll need to find and fix the broken uploads. I will be doing that.

Change 372419 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/UploadWizard@wmf/1.30.0-wmf.14] Preserve array keys (language keys) when sorting the language dropdown

https://gerrit.wikimedia.org/r/372419

Change 372419 merged by jenkins-bot:
[mediawiki/extensions/UploadWizard@wmf/1.30.0-wmf.14] Preserve array keys (language keys) when sorting the language dropdown

https://gerrit.wikimedia.org/r/372419

Mentioned in SAL (#wikimedia-operations) [2017-08-17T18:03:14Z] <thcipriani@tin> Synchronized php-1.30.0-wmf.14/extensions/UploadWizard/UploadWizard.config.php: SWAT: [[gerrit:372419|Preserve array keys (language keys) when sorting the language dropdown]] T173522 (duration: 00m 51s)

This is good with that^ right?

Yes, fixed and deployed.

I still need to clean up the broken wikitext pages, but that is not a deployment blocker.

Thanks @matmarex (and good seeing you last week, sorry we didn't talk much)

There seem to be only three legitimate templates on Commons with potentially confusing names:

select page_title from page
where page_namespace=10
and page_title rlike '^[0-9]+$'

Excluding those, we only get 240 results. I'll go through them with something semiautomatic (AWB or something) and change them to use {{en}} or {{unknown language}}.

select page_title, tl_title
from templatelinks
left join page on tl_from=page_id
where tl_namespace=10
and (tl_title like '1%' -- This silly condition makes MySQL use indices better and run faster
or tl_title like '2%'
or tl_title like '3%'
or tl_title like '4%'
or tl_title like '5%'
or tl_title like '6%'
or tl_title like '7%'
or tl_title like '8%'
or tl_title like '9%')
and tl_title rlike '^[1-9]+$'
and tl_from_namespace=6
and tl_title < 356
order by tl_title;
De_schipbrug_met_zicht_op_deel_van_de_binnenstad.jpg{{1}}
6c9d81e1315ce8cd20b5770e2b8e1d9b--hd-wallpaper-asian-ladies.jpg{{1}}
1145_HK_Museum_of_Arts_@_798.JPG{{123}}
President_of_Argentina_Mauricio_Macri_&_Vice_President_of_the_United_States_Michael_R._Pence_in_Buenos_Aires,_15_August_2017_(3).jpg{{141}}
President_of_Argentina_Mauricio_Macri_&_Vice_President_of_the_United_States_Michael_R._Pence_in_Buenos_Aires,_15_August_2017_(2).jpg{{141}}
President_of_Argentina_Mauricio_Macri_&_Vice_President_of_the_United_States_Michael_R._Pence_in_Buenos_Aires,_15_August_2017_(5).jpg{{141}}
Uganda_National_Assembly_2001.svg{{141}}
Rifugio_Soria_Ellena_e_Monte_Gelas.jpg{{149}}
HABARUGIRA_preaching.jpg{{151}}
Habarugira.jpg{{151}}
@johnson_HABARUGIRA_at_IG.jpg{{151}}
Vishnu_Chandran_CS.jpg{{185}}
Жихарев_месяцеслов_1782.jpg{{187}}
Obisk_brachny.jpg{{187}}
Fangruida_biography.jpg{{2}}
Joe_Leal.jpg{{21}}
N-Arachidonoyl_GlycineSVG.svg{{22}}
Mani_khan.jpg{{241}}
Jeżów_(9).jpg{{246}}
Jelenia_Góra_(Zabobrze).jpg{{246}}
CENTRUM_REHABILITACJI_K.K._Wiśniewscy_(Jelenia_Góra).jpg{{246}}
Jeżów_(18).jpg{{246}}
Małe_morze_-_widok_z_molo_w_Juracie.jpg{{247}}
PL-Kozarze-MostekNaNurcu.jpg{{247}}
Водоспад_Бісків.jpg{{247}}
Водоспад_Кізя.jpg{{247}}
Linus_Sangred.jpg{{247}}
BENJAMIN_HERCHCOVITCH_ATOR_E_LOCUTOR.jpg{{249}}
Альпийский_пер.jpg{{256}}
Dvoynykh2.jpg{{256}}
(-)-Aurantiamine.png{{28}}
Nokian_ylimääräinen_yhtiökokous_2013.jpg{{286}}
New_Yorkin_rahoituslaitosten_keskittymä.jpg{{286}}
Toivoniemi_Oulu_20170814.jpg{{286}}
Koskitie_20_Oulu_20170814.jpg{{286}}
Satamatie_39_Oulu_20170814.jpg{{286}}
Eduardo_Robledo_Rincón,_Presidente_y_fundador_de_Gerencia_del_Poder®.jpg{{288}}
Presentación_del_libro_"Poder_¿para_qué?"_en_Acapulco.jpg{{288}}
70_años_de_la_relación_de_México_y_Argentina.jpg{{288}}
Premio_Nacional_por_La_rebelión_de_los_colgados.jpg{{288}}
Fashion_show_Jerusalem_02.jpg{{29}}
Fangruida_biography.jpg{{3}}
Fascistfish.png{{3}}
Mani_khan_jadoon.jpg{{323}}
Landscape_from_Isobue_Misaki.jpg{{34}}
NKD115Saborna_Crkva_Hrista_Spasitelja_Banja_Luka_4.jpg{{34}}
NKD115Saborna_Crkva_Hrista_Spasitelja_Banja_Luka_5.jpg{{34}}
NKD138_Šadrvan_ispred_Ferhadija_džamije_u_Banja_Luci.jpg{{34}}
NKD138_Ferhadija_Dzamija_1.jpg{{34}}
Drake_Hotel_Philly.JPG{{39}}
Fangruida_biography.jpg{{4}}
Piaski_Drużków_12.jpg{{49}}
El_Greco_Ecstasy_of_St_Francis.jpg{{5}}
PLM_A5c5yfi_587.jpg{{5}}
Kirche_Hohenbocka_August_2017_(2).jpg{{65}}
Kirche_Hohenbocka_August_2017_(3).jpg{{65}}
Kirche_Hohenbocka_August_2017_(1).jpg{{65}}
Kirche_Hohenbocka_August_2017_(4).jpg{{65}}
Kirche_Hohenbocka_August_2017_(5).jpg{{65}}
Malchen-FrankensteinerStr45.jpg{{65}}
Pfungstadt-Süntelbuche3.jpg{{65}}
Pfungstadt-Süntelbuche4.jpg{{65}}
Stratocumulus_floccus_am_Abend.jpg{{65}}
Kirche_Nebelschütz_August_2017_(1).jpg{{65}}
Kirche_Nebelschütz_August_2017_(3).jpg{{65}}
Kirche_Nebelschütz_August_2017_(2).jpg{{65}}
Kirche_Nebelschütz_August_2017_(4).jpg{{65}}
Kirche_Nebelschütz_August_2017_(5).jpg{{65}}
Kirche_Nebelschütz_August_2017_(6).jpg{{65}}
Kirche_Nebelschütz_August_2017_(8).jpg{{65}}
Kirche_Nebelschütz_August_2017_(7).jpg{{65}}
Kirche_Nebelschütz_August_2017_(9).jpg{{65}}
Kirche_Nebelschütz_August_2017_(10).jpg{{65}}
Kirche_Nebelschütz_August_2017_(11).jpg{{65}}
Kirche_Nebelschütz_August_2017_(12).jpg{{65}}
Bleistiftzeichnung_von_Lino_Salini_1911_(1889_-_1944),_Zeichnung_zeigt_Maximus_Paul_Ferdinand_Kirchbach_(Max_Kirchbach,_1872_-_????).jpg{{65}}
Hamburger_Hafen_vom_Fischmarkt_mit_Portugiesenviertel,_1962.jpg{{65}}
Kirschblüte,_um_1980.jpg{{65}}
Hamburg-Hammerbrook_vor_Zerstörung_1943.jpg{{65}}
Maria_und_Engel_mit_totem_Jesus_vor_Golgatha,_um_1970.jpg{{65}}
Ludolf_Leendertsz._de_Jongh_-_Paying_the_Hostess.jpg{{66}}
Toivoniemi_Oulu_20170814.jpg{{66}}
Koskitie_20_Oulu_20170814.jpg{{66}}
Satamatie_39_Oulu_20170814.jpg{{66}}
Caméra_XPAD3.png{{7}}
Zwembad_De_Houtvaart_in_1992.jpg{{76}}
Fc-eindhoven-logo-66F80721E7-seeklogo.png{{83}}
Roque_Raúl_Alfaro_-_Argentina_1987.jpg{{83}}
Purushottam_Express_waiting_for_its_departure_from_Balasore.jpg{{83}}
St._Clair_Tunnel.png{{83}}
FC_OSS.png{{83}}
MapinfoProfessional.png{{83}}
90_degree_hammock.jpg{{83}}
2017_Ramblers_pose_with_Eastman_Statue.jpg{{83}}
2017_Science_Museum_(London)_02.jpg{{83}}
Twisted_Timbers.jpg{{83}}
2017_Science_Museum_(London)_06.jpg{{83}}
2017_Science_Museum_(London)_04.jpg{{83}}
2017_Science_Museum_(London)_05.jpg{{83}}
2017_Science_Museum_(London)_08.jpg{{83}}
2017_Science_Museum_(London)_07.jpg{{83}}
2017_Science_Museum_(London)_09.jpg{{83}}
2017_Science_Museum_(London)_11.jpg{{83}}
2017_Science_Museum_(London)_10.jpg{{83}}
2017_Science_Museum_(London)_15.jpg{{83}}
+_PDF_Transformation_Wellness_Proposal_Lisa_Anne_Miller_05_11_2017_(1).pdf{{83}}
Elizabethville_2017.jpg{{83}}
Cathie_Beck.jpg{{83}}
Asunción_Business_Center.jpg{{83}}
Pickle-lifter-maille.jpg{{83}}
Daniel_Inouye_Airport_Aloha_Sign.jpg{{83}}
Capilla_de_Santa_María_del_Campo,_Castropol.jpg{{83}}
Matthias_Manasi_performing_at_the_Berliner_Philharmonie.jpg{{83}}
2009_Bad_Münstereifel_Contrejour_10555.jpg{{83}}
2013_Bad_Münstereifel_Kölnerstrasse_Maisons_50556.jpg{{83}}
Sui_Dynasty.png{{83}}
1950's_sign_2017-05-17_129.jpg{{83}}
1950's_sign_2017-05-17_131.jpg{{83}}
1950's_sign_2017-05-17_130.jpg{{83}}
1950's_sign_2017-05-17_132.jpg{{83}}
Karlovy_Vary_Russian_Orthodox_Church.jpg{{83}}
Karlovy_Vary_Church_of_the_Russian_Czar.jpg{{83}}
Dresden_D.O.M._Rococo.jpg{{83}}
Dresden_Semper_Oper_Theaterplatz.jpg{{83}}
Ceský_Raj_View_on_Vsen.jpg{{83}}
Antwerpen_Oude_Koornmarkt_San_Salvatorkerk.jpg{{83}}
Antwerpen_Oude_Koornmarkt_Tempelstraat_San_Salvatorkerk.jpg{{83}}
Karlovy_Vary_Monument_For_Ludwig_Van_Beethoven.jpg{{83}}
Antwerpen_Groenplaats_Peter_Paul_Rubens_San_Salvatorkerk.jpg{{83}}
Karlovy_Vary_Beethoven_Memorial.jpg{{83}}
Praha_Kavarná_Obecní_Dum_Jugendstil.jpg{{83}}
Praha_Lucerna-Complex_Made_By_Vaclav_Havel's_Grandfather.jpg{{83}}
Praha_Statue_on_Vinohrady_Theater_Neorenaissance_II.jpg{{83}}
Praha_Former_'German_Opera'_Neorenaissance.jpg{{83}}
Praha_Statni_Opera.jpg{{83}}
Praha_State_Opera_Neorenaissance_I.jpg{{83}}
Praha_Statni_Opera_Neorenaissance_II.jpg{{83}}
Praha_State_Opera.jpg{{83}}
Praha_Jewish_Cemetery_With_Blessing_Hands_Of_A_'Cohen'.jpg{{83}}
Praha_St.Vitus_Cathedral_Southern_Front.jpg{{83}}
Praha_Vysehrad_National_Cemetery_II.jpg{{83}}
Praha_Josip_Plecnik's_Entrance_To_The_Wall_Garden.jpg{{83}}
Praha_Tyn_Church_Madonna_With_Child_Where_The_Protestant_Chalice_Used_To_Be.jpg{{83}}
Praha_Josip_Plecnik's_Entrance_To_Zahrada_Na_Valech.jpg{{83}}
Praha_Na_Prikope_-_Art_Déco_II.jpg{{83}}
Praha_Mustek_'Koruna'-Building_-_Art_Déco.jpg{{83}}
Praha_Vodickova_Frog_Detail_-_Jugendstil.jpg{{83}}
Praha_Wenceslav_by_Josef_Vaclav_Myslbek.jpg{{83}}
Praha_Na_Prikope_Freemason_Symbolism_-_Jugendstil_I.jpg{{83}}
Praha_Na_Prikope_Freemason_Symbolism_-_Jugendstil_II.jpg{{83}}
Praha_Na_Prikope_Freemason_Symbolism_-_Jugendstil_III.jpg{{83}}
Praha_Zivnostenska_Banka_Freemason_Symbolism.jpg{{83}}
Praha_Zivnostenska_Banka_Jugendstil.jpg{{83}}
Praha_Nekazanka_Freemason_Symbolism_-_Jugendstil_I.jpg{{83}}
Praha_Nekazanka_Freemason_Symbolism_-_Jugendstil_II.jpg{{83}}
Praha_Na_Prikope_Jugendstil_II.jpg{{83}}
Praha_Representation_House_-_Jugendstil.jpg{{83}}
Praha_Tynská_Tyn_Church.jpg{{83}}
Praha_Entrance_To_Obecni_Dum_-_Stained_Glass_By_Alfons_Mucha.jpg{{83}}
Den_Bommel.jpg{{83}}
Willemstad_II.jpg{{83}}
Oudenbosch_Saint_Louisplein_Former_Jesuit_College.jpg{{83}}
Karlovy_Vary_Lazenská_-_Jugendstil_I.jpg{{83}}
Karlovy_Vary_Lazenská_-_Jugendstil_II.jpg{{83}}
Oudenbosch_Basiliek_One_Third_Copy_Of_Rome's_St.Peter.jpg{{83}}
Roudnice_nad_Labem.jpg{{83}}
Roudnice_View_North_Towards_Lobkovic_Castle.jpg{{83}}
Roudnice_View_North_Towards_Lobkovic_Castle_II.jpg{{83}}
Roudnice_View_North.jpg{{83}}
Roudnice_View_NorthEast.jpg{{83}}
LevinJM_Headshot_FINAL_20161028.jpg{{83}}
MuseumRowSignage.jpg{{83}}
IDF_Navy_Rav_Aluf_Prediction.png{{83}}
BENJAMIN_HERCHCOVITCH_ATOR_E_LOCUTOR.jpg{{83}}
Praha_V_Kolkovne_-_Jugendstil.jpg{{83}}
Praha_Na_Porici_-_Rondokubismus_I.jpg{{83}}
Praha_Jewish_Cemetery.jpg{{83}}
Praha_Stary_Zidovsky_Hrbitov.jpg{{83}}
Praha_View_on_Karluv_Most.jpg{{83}}
Erfurt_Krämerbrücke_II.jpg{{83}}
Praha_Stained_Glass_Window_By_Alfons_Mucha_-_Jugendstil.jpg{{83}}
Praha_St.Vitus_Cathedral_Alfons_Mucha_Window.jpg{{83}}
Praha_St.Vitus_Cathedral_Great_West_Window.jpg{{83}}
Kutna_Hora_Unrestored_Medieval_Fresco_in_St.Barbara_Cathedral.jpg{{83}}
Kutna_Hora_View_on_Backside_of_Choir_of_St.Barbora_Cathedral.jpg{{83}}
Praha_Wenceslav_Square_-_Art_Déco.jpg{{83}}
Praha_Karluv_Most.jpg{{83}}
Praha_Obecni_Dum_-_Jugendstil.jpg{{83}}
Praha_Na_Porici_-_Rondokubismus_II.jpg{{83}}
Friction_Extrusion_Cross_Section.png{{83}}
Friction_Extrusion_Dies.jpg{{83}}
Friction_Extrusion_Milling_Machine.png{{83}}
Friction_Extrusion_ShAPE_Machine.jpg{{83}}
Friction_Extrusion_Marker.jpg{{83}}
Friction_Extrusion_Texture.jpg{{83}}
Friction_Extrusion_Stir_Welding.jpg{{83}}
Friction_Extrusion_Tubes.jpg{{83}}
2017_Blue_whale_skeleton_at_the_Central_Hall_of_the_Natural_History_Museum,_London_03.jpg{{83}}
2017_Blue_whale_skeleton_at_the_Central_Hall_of_the_Natural_History_Museum,_London_01.jpg{{83}}
2017_Blue_whale_skeleton_at_the_Central_Hall_of_the_Natural_History_Museum,_London_02.jpg{{83}}
James_Hoban,_Octagon.jpg{{83}}
A_Visakhapatnam_(VSKP)_WAP-7_at_Bhubaneswar_railway_station.jpg{{83}}
A_duronto_liveried_Ghaziabad_WAP-7_hauling_Bhubaneswar_Rajdhani.jpg{{83}}
An_Royapuram_(RPM)_WAP-7_at_Tambaram_station,_Tamil_Nadu.jpg{{83}}
Louis_Penfield_House_Living_Room_5.jpg{{83}}
Rajeshwar_Rana_pic.png{{83}}
Ada_Esther_Leverson.jpg{{83}}
Hadrian's_Wall_2017.jpg{{83}}
Nightlord_Cult_Of_The_Moon_Album_Cover.jpg{{83}}
Kit_body_samoa12h.png{{83}}
Kit_left_arm_samoa12h.png{{83}}
Kit_right_arm_samoa12h.png{{83}}
Louis_Penfield_House_4.jpg{{83}}
Louis_Penfield_House_Molding_2.jpg{{83}}
Louis_Penfield_House_Molding_1.jpg{{83}}
Louis_Penfield_House_Rain_Chain_2.jpg{{83}}
Louis_Penfield_House_Terrace_2.jpg{{83}}
Louis_Penfield_House_Rain_Chain_1.jpg{{83}}
Louis_Penfield_House_Terrace_1.jpg{{83}}
Louis_Penfield_House_and_Garden.jpg{{83}}
The_Underground_Titans_Tour_'92_advert.jpg{{83}}
Nightlord_Promo_Shot_1990.gif{{83}}
Assemblies_of_God_gatsata.jpg{{83}}
Habarugira_johnson.jpg{{83}}
HIRWA_Heritiear.jpg{{83}}
God's_glory_drama_team_girls_and_media_team.jpg{{83}}
JGRVEdit-2303.png.jpg{{98}}
President_of_Argentina_Mauricio_Macri_&_Vice_President_of_the_United_States_Michael_R._Pence_in_Buenos_Aires,_15_August_2017_(3).jpg{{98}}
President_of_Argentina_Mauricio_Macri_&_Vice_President_of_the_United_States_Michael_R._Pence_in_Buenos_Aires,_15_August_2017_(2).jpg{{98}}
President_of_Argentina_Mauricio_Macri_&_Vice_President_of_the_United_States_Michael_R._Pence_in_Buenos_Aires,_15_August_2017_(5).jpg{{98}}
Jules_verne_à_Amiens.jpg{{98}}
Vouarces_-_Mairie.jpg{{98}}
Alice_David_3_2015.png{{98}}
Cham_-_Charivari_-_V5d255-a.png{{98}}
Cham_-_Charivari_-_V5d255-c.png{{98}}
Cham_-_Charivari_-_V5d255-b.png{{98}}
Cham_-_Charivari_-_V5d255-d.png{{98}}
Iceland_2x2_road.png{{98}}
Iceland_2+1_road.png{{98}}
New_Zealand_map-es.svg{{98}}

I've done the cleanup this morning. Ended up editing 486 pages. Many were already cleaned up by conscientious editors, some were false positives (broken syntax for coordinates etc. from old edits).

https://commons.wikimedia.org/w/index.php?limit=500&title=Special%3AContributions&target=Matma+Rex&start=2017-08-21&end=2017-08-21

(You might see fewer edits in my contributions, since a few of them already have {{delete}} templates etc. and will probably soon be deleted.)