Maniphest T173557

Canceling edit does not restore statement rank to its original value
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Nicolas_Raoul
	Aug 18 2017, 5:39 AM

Tags

Referenced Files

	F9108863: Screenshot from 2017-08-18 14-37-16.png
	Aug 18 2017, 5:39 AM

Subscribers

MichaelSchoenitzer

Description

Go to https://www.wikidata.org/wiki/Q30297094
Press the "Edit" button of the "country" statement
Change the rank to deprecated or preferred but do not save
Press "Cancel"
Expected: Rank restored to "normal". Actually: Rank looks like it has changed.

Note: Data is not affected. Only the UI does not look the way it should. Refreshing the page restores the UI to how it should be.

Screenshot from 2017-08-18 14-37-16.png (86×66 px, 911 B)

Details

	Subject	Repo	Branch	Lines +/-
	RankSelector._stopEditing: Handle dropValue	mediawiki/extensions/Wikibase	master	+3 -0

Customize query in gerrit

Related Objects

Duplicates Merged Here: T303377: Wikidata website, changing a rank and cancel immediate does not set back the rank to previous value
T186409: Cancel doesn't ret rank icon back

Event Timeline

Nicolas_Raoul created this task.Aug 18 2017, 5:39 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 18 2017, 5:39 AM

Mbch331 merged a task: T186409: Cancel doesn't ret rank icon back.Feb 3 2018, 2:33 PM

Mbch331 added a subscriber: MichaelSchoenitzer.

hoo subscribed.Jul 17 2018, 5:26 PM

Lydia_Pintscher triaged this task as Low priority.Jun 6 2020, 6:43 PM

Lydia_Pintscher moved this task from incoming to ready to go on the Wikidata board.

Moebeus subscribed.Dec 6 2021, 11:01 AM

Lucas_Werkmeister_WMDE merged a task: T303377: Wikidata website, changing a rank and cancel immediate does not set back the rank to previous value.Mar 9 2022, 12:40 PM

Lucas_Werkmeister_WMDE added a subscriber: Wurgl.

Change 770106 had a related patch set uploaded (by Hoo man; author: Hoo man):

[mediawiki/extensions/Wikibase@master] RankSelector._stopEditing: Handle dropValue

https://gerrit.wikimedia.org/r/770106

gerritbot added a project: Patch-For-Review.Mar 12 2022, 10:04 PM

hoo claimed this task.Mar 12 2022, 10:05 PM

hoo added a project: Wikidata-Campsite (Team A Hearth 🏰🔥).

hoo moved this task from Incoming to Peer Review on the Wikidata-Campsite (Team A Hearth 🏰🔥) board.

Change 770106 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] RankSelector._stopEditing: Handle dropValue

https://gerrit.wikimedia.org/r/770106

Maintenance_bot removed a project: Patch-For-Review.Mar 16 2022, 11:10 AM

Nicolas_Raoul unsubscribed.Mar 16 2022, 11:12 AM

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.1; 2022-03-21-early).Mar 16 2022, 12:00 PM

hoo moved this task from Peer Review to Product Verification on the Wikidata-Campsite (Team A Hearth 🏰🔥) board.Mar 16 2022, 7:33 PM

Tested this with @hoo. Done!