MW-CS should enforce the one class per file requirement (there's an upstream sniff for this). This will be necessary in preparation for the PSR-4 namespaceization project.
Description
Description
Details
Details
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T166010 The Great Namespaceization Effort | |||
| Resolved | Legoktm | T173798 Enforce one class per file in preparation for PSR-4 |
Event Timeline
Comment Actions
Change 372916 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/tools/codesniffer@master] Require only one class/interface/trait per file
Comment Actions
Change 372916 merged by jenkins-bot:
[mediawiki/tools/codesniffer@master] Require only one class/interface/trait per file
Comment Actions
This will be included in the next release. In the meantime, http://phpcs-dashboard.wmflabs.org/sniffs/Generic.Files.OneClassPerFile.MultipleFound.html
Comment Actions
Unfortunately this doesn't exactly do what we need. This enforces separately one class per file, one interface per file, etc. But it doesn't prevent a file from having one class and a interface in the same file.
Comment Actions
Change 374026 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/tools/codesniffer@master] Use local OneClassPerFile sniff for only one class/interface/trait
Comment Actions
Change 374026 merged by jenkins-bot:
[mediawiki/tools/codesniffer@master] Use local OneClassPerFile sniff for only one class/interface/trait