[wmf.16-regression] Saved query names displayed shifted up
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Etonkovidova
	Aug 24 2017, 10:17 PM

Description

On RC page save a set of filters and give it a name with letters that have descenders (p, y, j, g).
The filter's name will bi displayed cut off and misaligned (shifted up), which the most likely cause for cutoff descenders.

Betalabs:

Screen Shot 2017-08-24 at 3.07.40 PM.png (157×603 px, 24 KB)

The shift-up occurs for the filter names without descenders:

Compare with wmf.15

Screen Shot 2017-08-24 at 3.09.27 PM.png (279×785 px, 43 KB)

Note: testwiki wmf.16 displays the issue:

Screen Shot 2017-08-30 at 9.45.45 AM.png (493×694 px, 105 KB)

Details

	Subject	Repo	Branch	Lines +/-
	Fix saved query names cutoff	mediawiki/core	master	+2 -0

Customize query in gerrit

Event Timeline

Etonkovidova created this task.Aug 24 2017, 10:17 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 24 2017, 10:17 PM

• Mattflaschen-WMF renamed this task from [betalabs-regression] Filters's names displayed shifted up to [betalabs-regression] Saved query names displayed shifted up.Aug 25 2017, 5:16 PM

Etonkovidova updated the task description. (Show Details)Aug 30 2017, 4:46 PM

Etonkovidova renamed this task from [betalabs-regression] Saved query names displayed shifted up to [wmf.16-regression] Saved query names displayed shifted up.Sep 1 2017, 6:35 PM

Etonkovidova moved this task from Untriaged to Ready for Pickup on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.

SBisson added a project: User-Petar.petkovic.Sep 11 2017, 2:40 PM

This most likely happened after we changed the saved queries title from "we don't care how long this is" to "trim it at 1 line". The display options make it hard to align now, but need to be looked into.

Change 377967 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/core@master] Fix saved query names cutoff

https://gerrit.wikimedia.org/r/377967

gerritbot added a project: Patch-For-Review.Sep 14 2017, 8:48 AM

In T174111#3601143, @Mooeypoo wrote:

This most likely happened after we changed the saved queries title from "we don't care how long this is" to "trim it at 1 line". The display options make it hard to align now, but need to be looked into.

You are correct, overflow: hidden, that was needed for ellipsis crop of long query titles, caused the issue.

• Petar.petkovic moved this task from Backlog to For Review on the User-Petar.petkovic board.Sep 14 2017, 8:55 AM

• Petar.petkovic moved this task from Ready for Pickup to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.

SBisson moved this task from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Sep 14 2017, 12:42 PM

Change 377967 merged by jenkins-bot:
[mediawiki/core@master] Fix saved query names cutoff

https://gerrit.wikimedia.org/r/377967

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)).Sep 14 2017, 1:00 PM

• Petar.petkovic moved this task from For Review to QA on the User-Petar.petkovic board.Sep 14 2017, 1:58 PM

Checked the fix in betalabs - looks good.

Screen Shot 2017-09-14 at 11.14.21 AM.png (341×678 px, 43 KB)

Etonkovidova closed this task as Resolved.Sep 14 2017, 6:15 PM

	F9536086: Screen Shot 2017-09-14 at 11.14.21 AM.png
	Sep 14 2017, 6:15 PM

	F9227008: Screen Shot 2017-08-30 at 9.45.45 AM.png
	Aug 30 2017, 4:46 PM

	F9169687: Screen Shot 2017-08-24 at 3.07.40 PM.png
	Aug 24 2017, 10:17 PM

	F9169691: Screen Shot 2017-08-24 at 3.09.27 PM.png
	Aug 24 2017, 10:17 PM

	F9169695: Screen Shot 2017-08-24 at 3.04.42 PM.png
	Aug 24 2017, 10:17 PM

[wmf.16-regression] Saved query names displayed shifted upClosed, ResolvedPublicActions

Description

Details

Event Timeline

[wmf.16-regression] Saved query names displayed shifted up
Closed, ResolvedPublic
Actions