The names of new Saved Filters don't appear as expected in the Active Filter area
Closed, ResolvedPublic
Actions

Description

On Recent Changes, delete all filters with Trashcan then make some new selections.
Click bookmark and give the setting a name.
(The name will not appear immediately in the Active area, which is OK, since we just saved it.)
Now use Saved filters menu and select a different Saved Filter.
- OR click trashcan to delete all filters.
Then select the new filter we just saved.

Expected result: the filter loads and its name shows up in the Active Filers area.
Actual result: Whether you select a different filter then come back, or use Trashcan to delete all filters, the new saved filter loads but its name does not appear. You have to click in the address bar and reload the page to make the new name start appearing.

Details

	Subject	Repo	Branch	Lines +/-
	RCFilters: Minimize saved query before comparison	mediawiki/core	master	+32 -1

Customize query in gerrit

Related Objects

Duplicates Merged Here: T174217: [wmf.15] RC - Saved filter name will not be displayed in 'Active filters' area unless RC page is reload

Event Timeline

• jmatazzoni created this task.Aug 25 2017, 6:52 PM

• jmatazzoni moved this task from Untriaged to Ready for Pickup on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.

(The name will not appear immediately in the Active area, which is OK, since we just saved it.)

The name should appear immediately. That would help confirming that the filter was saved.

There is also a related issue: deleting a saved filter while it is being the active one keeps the name next to the active filters label and the bookmark action hidden. The expected behaviour would be to for the label to disappear when the filter is deleted and the bookmark action to appear.

We can include these as part of the current ticket or create separate ones depending on how much related the issues actually are.

Etonkovidova merged a task: T174217: [wmf.15] RC - Saved filter name will not be displayed in 'Active filters' area unless RC page is reload .Aug 28 2017, 4:41 PM

Change 374402 had a related patch set uploaded (by Mooeypoo; owner: Mooeypoo):
[mediawiki/core@master] RCFilters: Minimize saved query before comparison

https://gerrit.wikimedia.org/r/374402

gerritbot added a project: Patch-For-Review.Aug 28 2017, 8:08 PM

Mooeypoo claimed this task.Aug 28 2017, 8:08 PM

Mooeypoo moved this task from Ready for Pickup to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.

Change 374402 merged by jenkins-bot:
[mediawiki/core@master] RCFilters: Minimize saved query before comparison

https://gerrit.wikimedia.org/r/374402

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)).Aug 28 2017, 9:01 PM

SBisson moved this task from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Aug 29 2017, 10:21 AM