[regression] language icon is darker than other icons
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Nirzar
	Aug 31 2017, 11:23 PM

Description

All article action icons should be of same color.

the regression introduces language icon to be darker than rest. it was the same color.

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/skins/MinervaNeue	wmf/1.30.0-wmf.16	+1 -1	Adjust language icon color
	mediawiki/skins/MinervaNeue	master	+1 -1	Adjust language icon color

Customize query in gerrit

Event Timeline

• Nirzar created this task.Aug 31 2017, 11:23 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 31 2017, 11:23 PM

• Nirzar triaged this task as High priority.Aug 31 2017, 11:24 PM

• Nirzar removed a project: (DEPRECATED) Bug-Report.

• Nirzar added subscribers: Jdlrobson, ovasileva.Sep 1 2017, 3:24 PM

ovasileva moved this task from To Do to Needs Design Review on the Readers-Web-Kanbanana-Board-Old board.Sep 1 2017, 3:27 PM

Where are you seeing this?
https://en.m.wikipedia.org/wiki/Highways_in_Ontario looks fine as does https://en.m.wikipedia.beta.wmflabs.org/wiki/Headings

Ahh I was checking pages without languages. I see it now.

https://en.m.wikipedia.beta.wmflabs.org/wiki/Selenium_language_test_page%26%26sleep_5s
https://en.m.wikipedia.org/wiki/France

Yeh that's not great.

Change 375395 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Adjust language icon color

https://gerrit.wikimedia.org/r/375395

gerritbot added a project: Patch-For-Review.Sep 1 2017, 3:32 PM

There was a typo in the fill color.
Fix should be live on
https://en.m.wikipedia.beta.wmflabs.org/wiki/Selenium_language_test_page%26%26sleep_5s shortly.

We can SWAT this Tuesday. I'm afraid we'll have to live with the pain until then. We've already had one special permission SWAT deploy today.

Change 375395 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Adjust language icon color

https://gerrit.wikimedia.org/r/375395

Change 375398 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@wmf/1.30.0-wmf.16] Adjust language icon color

https://gerrit.wikimedia.org/r/375398

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-09-05 (1.30.0-wmf.17)).Sep 1 2017, 4:00 PM

phuedx added a project: Regression.Sep 4 2017, 4:42 PM

ovasileva moved this task from Incoming to 2017-18 Q1 on the Readers-Web-Backlog board.Sep 5 2017, 12:04 PM

Piotr will swat this at 4pm PST (https://wikitech.wikimedia.org/w/index.php?title=Deployments&type=revision&diff=1769395&oldid=1769374)

Change 375398 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@wmf/1.30.0-wmf.16] Adjust language icon color

https://gerrit.wikimedia.org/r/375398

Mentioned in SAL (#wikimedia-operations) [2017-09-06T00:14:56Z] <Reedy> that was T174747 Adjust language icon color

Deployed and tested on production - looks ok. @Nirzar - you can check it on production if you want. I'm changing this task to "resolved".

pmiazga closed this task as Resolved.Sep 6 2017, 12:21 AM

Macro votecat: looks good

wikilove to @pmiazga and @Jdlrobson

ReleaseTaggerBot edited projects, added MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)); removed MW-1.30-release-notes (WMF-deploy-2017-09-05 (1.30.0-wmf.17)).Sep 6 2017, 1:00 AM

[regression] language icon is darker than other iconsClosed, ResolvedPublicActions

Description

Details

Event Timeline

[regression] language icon is darker than other icons
Closed, ResolvedPublic
Actions