Disable RelatedArticles instrumentation on all wikis
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	phuedx
	Sep 4 2017, 2:21 PM

Description

Background

The RelatedArticles A/B test has finished. [[ https://phabricator.wikimedia.org/T169948#3573023 | ~0% of EventLogging events are feature-disabled events as expected ]]. It's time to turn off the instrumentation.

AC

The instrumentation is turned off on all wikis.
- i.e. $wgRelatedArticlesLoggingBucketSize is 0 everywhere.
The instrumentation implementation isn't removed from the RelatedArticles codebase.

Details

	Subject	Repo	Branch	Lines +/-
	Disable RelatedArticles instrumentation on all wikis	operations/mediawiki-config	master	+1 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		pmiazga	T174944 Disable RelatedArticles instrumentation on all wikis
		Resolved		ovasileva	T169948 Stop RelatedArticles A/B test and clean up config

Event Timeline

phuedx created this task.Sep 4 2017, 2:21 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 4 2017, 2:21 PM

phuedx added a subtask: T169948: Stop RelatedArticles A/B test and clean up config.Sep 4 2017, 2:22 PM

ovasileva triaged this task as Medium priority.Sep 4 2017, 2:23 PM

ovasileva moved this task from Incoming to Upcoming on the Web-Team-Backlog board.

When can this be done? Now?

@Jdlrobson - we can do it now, so long as we leave the code intact. In my precursory analysis of the data, it seemed we were still having some issues with bucketing, meaning there's still a possibility of repeating the a/b test later on.

ovasileva set the point value for this task to 1.Sep 19 2017, 4:53 PM

ovasileva added a project: Readers-Web-Kanbanana-Board-Old.Sep 20 2017, 3:29 PM

Jdlrobson moved this task from Upcoming to 2017-18 Q1 on the Web-Team-Backlog board.Sep 25 2017, 3:18 PM

Change 380554 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[operations/mediawiki-config@master] Disable RelatedArticles instrumentation on all wikis

https://gerrit.wikimedia.org/r/380554

gerritbot added a project: Patch-For-Review.Sep 25 2017, 5:14 PM

On SWAT calendar for tomorrow

• bmansurov moved this task from Needs Code Review to Needs More Work on the Readers-Web-Kanbanana-Board-Old board.Sep 25 2017, 6:27 PM

Change 380554 merged by jenkins-bot:
[operations/mediawiki-config@master] Disable RelatedArticles instrumentation on all wikis

https://gerrit.wikimedia.org/r/380554

Mentioned in SAL (#wikimedia-operations) [2017-09-26T13:15:34Z] <hashar@tin> Synchronized wmf-config/CommonSettings.php: Disable RelatedArticles instrumentation on all wikis - T174944 (duration: 00m 45s)

https://grafana.wikimedia.org/dashboard/db/eventlogging-schema?orgId=1&var-schema=RelatedArticles&from=1506430800000&to=now 🎉🎉🎉

phuedx moved this task from Needs More Work to Ready for Signoff on the Readers-Web-Kanbanana-Board-Old board.Sep 26 2017, 1:37 PM

I'll sign it off today

pmiazga claimed this task.Sep 27 2017, 2:34 PM

• Niedzielski mentioned this in T175526: Fully loaded time regression on 3G Barack Obama en.wiki.Sep 27 2017, 2:49 PM

Config value is set to zero on all wikis, grafana shows zero-to-couple events per minute (drop from ~700 events per minute) - it's probably an old/cached code. Looks good to me - I'll resolve this task.

pmiazga closed this task as Resolved.Sep 27 2017, 6:03 PM

pmiazga removed a project: Patch-For-Review.

phuedx updated the task description. (Show Details)Sep 27 2017, 6:05 PM

In T174944#3640530, @pmiazga wrote:

Config value is set to zero on all wikis, grafana shows zero-to-couple events per minute (drop from ~700 events per minute) - it's probably an old/cached code. Looks good to me - I'll resolve this task.

Just a note that there are still Popups events being logged and that instrumentation was disabled on Monday, September 18th.

Disable RelatedArticles instrumentation on all wikisClosed, ResolvedPublic1 Estimated Story PointsActions