Page MenuHomePhabricator
Create Task
Maniphest T175978

Keep using the 'editmyoptions' user right for GlobalPreferences
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

There's a TODO in the code at the moment about whether or not the editmyoptions user right (description: "Edit your own preferences") is sufficient for global prefs. I think it is, but I wanted to just see if there was anything that I'm not considering, before removing the todo.

Editing that user right is the recommended way to disable user preferences.

Is there some weird situation in which a site would want to disable local preference editing, but keep global enabled? Surely they'd just share the user_properties table then?

Details

SubjectRepoBranchLines +/-
Remove TODOs we decided we don't needmediawiki/extensions/GlobalPreferencesmaster+0 -2
Customize query in gerrit

Event Timeline

Samwilson created this task.Sep 15 2017, 5:18 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 15 2017, 5:18 AM
Legoktm subscribed.Sep 15 2017, 6:08 AM

At that time I was thinking of OAuth/BotPasswords. Both of those have editmyoptions as a separate grant, and I wasn't sure if we also needed to have a separate user right plus separate grant for it. I think the current right is good enough though.

Samwilson added a comment.Sep 19 2017, 10:52 PM

Ok, we'll just remove the comments from the code, and stick with a single user right.

• DannyH set the point value for this task to 1.Sep 19 2017, 10:53 PM
• DannyH moved this task from New & TBD Tickets to Up Next (June 3-21) on the Community-Tech board.
• DannyH triaged this task as Medium priority.Sep 19 2017, 10:58 PM
Niharika renamed this task from Keep using the 'editmyoptions' user right for GlobalPreferences? to Keep using the 'editmyoptions' user right for GlobalPreferences.Sep 19 2017, 11:26 PM
kaldari edited projects, added Community-Tech-Sprint; removed Community-Tech.Sep 26 2017, 11:25 PM
MaxSem claimed this task.Jan 4 2018, 11:23 PM
MaxSem moved this task from Ready to In Development on the Community-Tech-Sprint board.
gerritbot subscribed.Jan 4 2018, 11:27 PM

Change 402139 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/extensions/GlobalPreferences@master] Remove TODOs we decided we don't need

https://gerrit.wikimedia.org/r/402139

gerritbot added a project: Patch-For-Review.Jan 4 2018, 11:27 PM
MaxSem moved this task from In Development to Needs Review/Feedback on the Community-Tech-Sprint board.Jan 4 2018, 11:27 PM
gerritbot added a comment.Jan 4 2018, 11:35 PM

Change 402139 merged by jenkins-bot:
[mediawiki/extensions/GlobalPreferences@master] Remove TODOs we decided we don't need

https://gerrit.wikimedia.org/r/402139

MaxSem closed this task as Resolved.Jan 4 2018, 11:36 PM
MaxSem removed a project: Patch-For-Review.
MaxSem moved this task from Needs Review/Feedback to Q1 2018-19 on the Community-Tech-Sprint board.
Niharika edited projects, added Community-Tech; removed Community-Tech-Sprint.Jan 31 2018, 12:07 AM
• TBolliger moved this task from Up Next (June 3-21) to Archive on the Community-Tech board.Jan 31 2018, 10:58 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits