So it turns out he isn't in the admins module, so he needs inclusion before being flagged back into the ldap group. I'm preparing a patchset now.

Change 378754 had a related patch set uploaded (by RobH; owner: RobH):
[operations/puppet@production] adding wmf staff david chan to admin module ldap section

https://gerrit.wikimedia.org/r/378754

Change 378754 merged by RobH:
[operations/puppet@production] adding wmf staff david chan to admin module ldap section

https://gerrit.wikimedia.org/r/378754

Hi, I still don't see +2 on https://gerrit.wikimedia.org/r/7738/ , even after logging in afresh.

Note my gerrit username is 'divec' (account ID 839).

Thanks!

There are two LDAP users here I think...

• http://tools.wmflabs.org/ldap/user/dchan
• http://tools.wmflabs.org/ldap/user/divec

In T176142#3616617, @dchan wrote:

Hi, I still don't see +2 on https://gerrit.wikimedia.org/r/7738/ , even after logging in afresh.

Note my gerrit username is 'divec' (account ID 839).

Thanks!

@dchan: Your account dchan is tied to your @wikimedia.org account, while your divec is your personal account. I'd advise you use your WMF account for wmf actions like ldap.

If this is unacceptable, we can roll back your dchan user to no rights, and grant wmf rights to your personal account, but that seems odd. (It sounds like your gerrit work is done via your personal account though? I'm asking other opsen to ensure our changing this is ok!) It is just much easier to audit for WMF flag when ALL the accounts using it are tied to a legitimate @wikimedia.org email account.

Change 378919 had a related patch set uploaded (by RobH; owner: RobH):
[operations/puppet@production] changing dchan to divec

https://gerrit.wikimedia.org/r/378919

Change 378919 merged by RobH:
[operations/puppet@production] changing dchan to divec

https://gerrit.wikimedia.org/r/378919

Next time there is an issue, please reopen the task =] (I just am subscribed so I noticed it was getting updates.)

Ok so no username was specified in the original request, and I went with the account that uses @wikimedia.org. I think its a bad idea to use personal accounts for ldap wmf flag when there are @wikimedia.org wikitech accounts that can be used.

However, its what we recommend, not what is hard required (there are a few volunteers turned staff who still use their old accounts.) I've gone ahead and made changes to admins module to remove dchan and add divec.

Go ahead and try now! If there is an issue, please reopen this task.

Thank you, that's working now - and you're right, that's exactly what happened in my case, I first contributed as a volunteer.