acceptance criteria
- Deploy print styles instrumentation from T169730: Define and implement instrumentation for printing on desktop web at sampling rate 10%
Project | Branch | Lines +/- | Subject | |
---|---|---|---|---|
operations/mediawiki-config | master | +8 -0 | Enable Print instrumentation |
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | Jdlrobson | T154965 [EPIC] Print styles - desktop | |||
Resolved | ovasileva | T169732 Deploy new desktop print styles on all projects | |||
Declined | ovasileva | T170021 Analyze the impact of new print styles | |||
Resolved | phuedx | T176341 Deploy print styles instrumentation |
Yes, the rationale from T169730#3475086 still holds. 10% is a bit conservative (i.e. we could likely increase this ratio and get the data sooner without even crossing the 10 events/second threshold), but let's account for the remote possibility that the new onBeforePrint events vastly outnumber the already estimated clickPrintableVersion ones.
Moving into sprint so we can start recording data asap. We can then proceed with T169732: Deploy new desktop print styles on all projects in two weeks (Oct 9)
Change 379580 had a related patch set uploaded (by Bmansurov; owner: Bmansurov):
[operations/mediawiki-config@master] Enable Print instrumentation
Change 379580 merged by jenkins-bot:
[operations/mediawiki-config@master] Enable Print instrumentation
As of this writing, print scheme instrumentation is active on group 0 and group 1 wikis. It'll kick in on group 2 wikis later today.
Mentioned in SAL (#wikimedia-operations) [2017-09-21T18:31:14Z] <thcipriani@tin> Synchronized wmf-config/InitialiseSettings.php: SWAT: [[gerrit:379580|Enable Print instrumentation]] T176341 (duration: 00m 52s)
The instrumentation has been deployed, enabled, and we're receiving events at a peak rate of ~25 events/min 🎉🎉🎉
If we want to increase that rate, then I suggest a new task for increasing the bucket size (with working!). FYI it'll be a 1 pointer 😉