Page MenuHomePhabricator

Coordinate harvest broken for Philipines
Closed, ResolvedPublic

Description

It looks like Frietjes has made a lot of changes like this which effectively remove the coordinates from the Monument database and by extension from the Wikidata migration.

Per Unknown_fields/monuments_ph_(en) essentially all of the coordinates have been converted to this format.

Event Timeline

We could quite easily add the coord field to the harvest to at least make the data accessible for Wikidata migration.

For the harvester to support harvesting lat/lon from coord I believe we need a new converter (or probably two) and we probably have to drop support for plain lat/lon. @JeanFred do ou think that might work?

Change 380939 had a related patch set uploaded (by Lokal Profil; owner: Lokal Profil):
[labs/tools/heritage@master] Harvest coordinate template

https://gerrit.wikimedia.org/r/380939

Change 380939 had a related patch set uploaded (by Lokal Profil; owner: Lokal Profil):
[labs/tools/heritage@master] Harvest coordinate template

https://gerrit.wikimedia.org/r/380939

This is just the simple harvest to have it accessible for the migrator.

Change 380939 merged by jenkins-bot:
[labs/tools/heritage@master] Harvest coordinate template and drop lat, lon

https://gerrit.wikimedia.org/r/380939

There is a follow-up task for converting the coordinate template to individual lat/long fields in the database. T200097: Add converter for coord template to lat, lon fields

This should be checked after the next successful harvest then be resolved.

Looks like the ph table not only failed to harvest but didn't even create the source table.

Will investigate in the logs

Looks like the ph table not only failed to harvest but didn't even create the source table.

Will investigate in the logs

This was due to me not having recreated the table by running python monument_tables.py
Running that however lead to discovering an implicit assumption that the lat, lon fields always exist by using these as keys.

Change 447806 had a related patch set uploaded (by Lokal Profil; owner: Lokal Profil):
[labs/tools/heritage@master] Handle missing lat, lon in monument config

https://gerrit.wikimedia.org/r/447806

Change 447806 merged by jenkins-bot:
[labs/tools/heritage@master] Handle missing lat, lon in monument config

https://gerrit.wikimedia.org/r/447806

Mentioned in SAL (#wikimedia-cloud) [2018-07-31T09:07:53Z] <Lokal_Profil> Deploy latest from Git master: 6bffdbb, 65f04d2, df4e313 (T200326), 2b5e868 (T176845)