Page MenuHomePhabricator
Create Task
Maniphest T177973

Please strip leading spaces from the "format" field in TemplateData GUI
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Related to T138492: Add support for actual format strings to TemplateData's "format" parameter:

In the TemplateData GUI (opened via "Manage TemplateData" button while editing the template), it's unfortunately easy to accidentally end up with a format that specifies a leading space, which is invalid, and therefore the page can't be saved.

We should automagically strip the leading spaces from that field (and trailing spaces, if that's also a problem).

Details

SubjectRepoBranchLines +/-
Add stripping leading and trailing spaces from the "format" fieldmediawiki/extensions/TemplateDatamaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

• Whatamidoing-WMF created this task.Oct 11 2017, 6:01 PM
Restricted Application added a project: VisualEditor. · View Herald TranscriptOct 11 2017, 6:01 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Jdforrester-WMF subscribed.Oct 11 2017, 6:20 PM
• Deskana triaged this task as Low priority.Oct 24 2017, 6:47 PM
• Deskana set the point value for this task to 1.
• Deskana added a project: good first task.
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptOct 24 2017, 6:47 PM
• Deskana moved this task from To Triage to Freezer on the VisualEditor board.Oct 24 2017, 6:47 PM
Dvorapa subscribed.Oct 24 2017, 7:44 PM
• Elitre subscribed.Nov 3 2017, 3:33 PM
matmarex added a project: Google-Code-in-2018.Oct 23 2018, 5:03 AM
matmarex subscribed.

I would like to mentor this task in Google-Code-in-2018.

Aklapper updated the task description. (Show Details)Oct 23 2018, 1:29 PM
Aklapper moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-in-2018 board.

https://codein.withgoogle.com/tasks/5995431646461952/

matmarex renamed this task from Please strip leading spaces from the TemplateData GUI to Please strip leading spaces from the "format" field in TemplateData GUI.Oct 23 2018, 4:10 PM
matmarex updated the task description. (Show Details)
gerritbot subscribed.Nov 1 2018, 9:56 PM

Change 471175 had a related patch set uploaded (by Bjornskjald; owner: Bjornskjald):
[mediawiki/extensions/TemplateData@master] Add stripping leading and trailing spaces from the "format" field

https://gerrit.wikimedia.org/r/471175

gerritbot added a project: Patch-For-Review.Nov 1 2018, 9:56 PM
Jdforrester-WMF assigned this task to ptrcnull.Nov 1 2018, 10:12 PM
Jdforrester-WMF edited projects, added VisualEditor (Current work); removed Patch-For-Review, VisualEditor.
Jdforrester-WMF moved this task from Incoming to QA on the VisualEditor (Current work) board.
gerritbot added a comment.Nov 1 2018, 10:17 PM

Change 471175 merged by jenkins-bot:
[mediawiki/extensions/TemplateData@master] Add stripping leading and trailing spaces from the "format" field

https://gerrit.wikimedia.org/r/471175

matmarex closed this task as Resolved.Nov 1 2018, 10:23 PM
ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.3; 2018-11-06).Nov 1 2018, 11:00 PM
• Elitre unsubscribed.Nov 8 2018, 5:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits