Page MenuHomePhabricator

Align Popups to WikimediaUI color palette
Closed, ResolvedPublic

Description

Align Popups to WikimediaUI color palette, most of it has been done already in https://gerrit.wikimedia.org/r/#/c/383032/
Remaining are the SVG colors.

Testing criteria

Several icons have been optimised and had color changes. Be sure to check in both RTL and LTR mode. We are not expecting any change in visual appearance from before other than the colors being different.

  • Check sad face when viewing a page preview without a summary
  • Check the settings dialog with and without navpopup gadget
  • Check the beta feature icon

Event Timeline

Change 384432 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/Popups@master] Optimize SVGs and align colors to WikimediaUI palette

https://gerrit.wikimedia.org/r/384432

Change 384432 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Optimize SVGs and align colors to WikimediaUI palette

https://gerrit.wikimedia.org/r/384432

Change 386254 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] Optimize SVGs and align colors to WikimediaUI palette

https://gerrit.wikimedia.org/r/386254

Sry, task number mistakenly copy&pasted. 386254 doesn't belong here.

Oh yes, I worked on this a while ago, but got sidetracked with other stuff. The icons I saw looked good. If we all think this is good to go, I won't stop it :)

✅ Check sad face when viewing a page preview without a summary
✅ Check the settings dialog with and without navpopup gadget

?? Check the beta feature icon

I think we got rid of the beta feature, so i couldn't verify this. in any case, it should be fine

Macro votecat: looks good

Volker_E raised the priority of this task from High to Needs Triage.Jun 1 2018, 2:07 PM
Volker_E moved this task from Backlog to Done on the UI-Standardization-Kanban board.