Restrict access to the testing URL for the new book rendering workflow
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Currently, access to the URL used to test the Remex + Electron based book rendering workflow (Special:RenderBook/test) is unrestricted.

Context

The original conversation between @Jdlrobson and @Tgr starts here: T175868#3680538

AC

Restrict access to the special page to the Readers Web/Infra engineers and PO (@ovasileva)

Solutions

@Tgr submitted a change as part of T175868, which restricts access to the URL to users with "(WMF)" in their name
- Per T175868#3681307, you have to be an admin to register names with WMF in 'em
In T175868#3686340, @Tgr explained how to create a new group with the "testpdf" right.
- This seems a little more involved but superior to the above in that it provides finer grained access control. OTOH, do we really need that?
In T178289#3688851, @Jdlrobson suggested that we should simply disable the testing URL until we're ready to test the concatenation feature
Move the logic from @Tgr's change to the Collection extension (a hybrid of @Tgr's change and @Jdlrobson's change)

Details

Subject	Repo	Branch	Lines +/-
Disable special page usage until further notice	mediawiki/extensions/Collection	master	+15 -0
Disable special page usage until further notice	mediawiki/extensions/Collection	wmf/1.31.0-wmf.3	+15 -0
Disable special page usage until further notice	mediawiki/extensions/Collection	wmf/1.31.0-wmf.4	+15 -0

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		• JKatzWMF	T150871 [EPIC] (Proposal) Replicate core OCG features and sunset OCG service
Invalid		None	T186740 [EPIC] It should be possible to print a book using the Proton service
Invalid		None	T178095 [EPIC] Fix problems with the PHP concatenation special page service
Resolved		ovasileva	T177994 Book generation fails for articles with '/' character in title
Invalid		None	T177993 Article concatenation fails on large books
Resolved	PRODUCTION ERROR	phuedx	T177988 Warning: Invalid argument supplied for foreach() in /srv/mediawiki/php-1.31.0-wmf.2/extensions/Collection/includes/DataProvider.php on line 152
Invalid		None	T177996 Article concatenation not resilient to curl errors
Invalid		Jdlrobson	T175868 Deploy and test new book rendering (Remex + Electron)
Invalid		Jdlrobson	T178036 Book rendering database query error
Resolved		Jdlrobson	T178289 Restrict access to the testing URL for the new book rendering workflow

Event Timeline

phuedx created this task.Oct 16 2017, 1:06 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 16 2017, 1:06 PM

AFAICT this is high priority as the URL allows users access to an experimental workflow that might result in the Electron-based render service hanging /cc @ovasileva

@Jdlrobson: Is this the case?

Change 384601 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/Collection@master] Disable special page usage until further notice

https://gerrit.wikimedia.org/r/384601

gerritbot added a project: Patch-For-Review.Oct 16 2017, 8:32 PM

@phuedx correct. A third option is to disable the registration of the code in the special page until we have time to test it more thoroughly.

Really it comes down to how quickly we need to be able to turn this on and off and what the timeline is like for fixing all the associated bugs in T178095.
TBH I'm leaning towards the hacky option (https://gerrit.wikimedia.org/r/#/c/377929/) if we're planning to fix T178095 soon (e.g. within next week or 2).

If we're not, we should disable the special page in code right away and do the more complicated but thorough work of introducing a test group.

I'm sensing we might be leaning towards fixing this later so I'd recommend:
Merging and SWATTing https://gerrit.wikimedia.org/r/384601 and creating a new task around accessing the page until we think of something better (and also who knows.. might turn out that YAGNI).

Pulling in for visibility as I am working on this and we need to do something this sprint.

Jdlrobson moved this task from To Do to Blocked on Others on the Readers-Web-Kanbanana-Board-Old board.Oct 16 2017, 10:44 PM

@ovasileva: With T178289#3688851 in mind, this also needs your input.

From my POV, we (Readers Web) have got enough to be getting on with this week and we're OOO next week at the offsite. It's unlikely that we'll have enough bandwidth to do option #2 right now, so I'd recommend that we did option #1. I prefer option #1 to fully disabling the special page because we haven't yet fully fixed and tested the workflow (which is causing a little confusion on my part).

phuedx updated the task description. (Show Details)Oct 17 2017, 11:52 AM

@phuedx - option #1 seems fine

ovasileva triaged this task as High priority.Oct 17 2017, 4:46 PM

phuedx updated the task description. (Show Details)Oct 17 2017, 5:00 PM

ovasileva set the point value for this task to 2.Oct 17 2017, 5:08 PM

ovasileva moved this task from Blocked on Others to Needs Design Review on the Readers-Web-Kanbanana-Board-Old board.Oct 17 2017, 5:14 PM

Jdlrobson moved this task from Needs Design Review to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.Oct 17 2017, 5:14 PM

phuedx mentioned this in T175868: Deploy and test new book rendering (Remex + Electron).Oct 17 2017, 5:18 PM

Once https://gerrit.wikimedia.org/r/384601 is merged we'll need to swat it. If this happens before branch cut (today?) then that will save us some time!!

Jdlrobson mentioned this in T177988: Warning: Invalid argument supplied for foreach() in /srv/mediawiki/php-1.31.0-wmf.2/extensions/Collection/includes/DataProvider.php on line 152.Oct 17 2017, 5:57 PM

Change 384601 merged by jenkins-bot:
[mediawiki/extensions/Collection@master] Disable special page usage until further notice

https://gerrit.wikimedia.org/r/384601

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-10-24 (1.31.0-wmf.5)).Oct 17 2017, 9:00 PM

Change 384903 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/Collection@wmf/1.31.0-wmf.4] Disable special page usage until further notice

https://gerrit.wikimedia.org/r/384903

The above patch should be swatted at first available opportunity. If time also swat to the 1.31.0-wmf.3 branch.

Change 385005 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/Collection@wmf/1.31.0-wmf.3] Disable special page usage until further notice

https://gerrit.wikimedia.org/r/385005

This is on the deploy calendar for today.

Change 384903 merged by jenkins-bot:
[mediawiki/extensions/Collection@wmf/1.31.0-wmf.4] Disable special page usage until further notice

https://gerrit.wikimedia.org/r/384903

Change 385005 merged by jenkins-bot:
[mediawiki/extensions/Collection@wmf/1.31.0-wmf.3] Disable special page usage until further notice

https://gerrit.wikimedia.org/r/385005

Page is disabled so signing off...

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2017-10-17 (1.31.0-wmf.4)); removed MW-1.31-release-notes (WMF-deploy-2017-10-24 (1.31.0-wmf.5)).Oct 19 2017, 12:00 AM

Restrict access to the testing URL for the new book rendering workflowClosed, ResolvedPublic2 Estimated Story PointsActions