Page MenuHomePhabricator
Create Task
Maniphest T177988

Warning: Invalid argument supplied for foreach() in /srv/mediawiki/php-1.31.0-wmf.2/extensions/Collection/includes/DataProvider.php on line 152
Closed, ResolvedPublic3 Estimated Story PointsPRODUCTION ERROR
Actions

Description

Seen recently spiking in fatalmonitor logstash

[Exception ErrorException] (/srv/mediawiki/php-1.31.0-wmf.2/extensions/Collection/includes/DataProvider.php:152) PHP Warning: Invalid argument supplied for foreach()    
  #0 /srv/mediawiki/php-1.31.0-wmf.2/extensions/Collection/includes/DataProvider.php(152): MWExceptionHandler::handleError(integer, string, string, integer, array, array)
  #1 /srv/mediawiki/php-1.31.0-wmf.2/extensions/Collection/includes/BookRenderingMediator.php(70): MediaWiki\Extensions\Collection\DataProvider->fetchMetadata(array)    
  #2 /srv/mediawiki/php-1.31.0-wmf.2/extensions/Collection/includes/BookRenderingMediator.php(102): MediaWiki\Extensions\Collection\BookRenderingMediator->getBook(array)
  #3 /srv/mediawiki/php-1.31.0-wmf.2/extensions/Collection/SpecialRenderBook.php(53): MediaWiki\Extensions\Collection\BookRenderingMediator->getBookFromCache(array)

Details

SubjectRepoBranchLines +/-
Handle and debug case where API returns no pagesmediawiki/extensions/Collectionmaster+7 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

thcipriani created this task.Oct 11 2017, 7:27 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 11 2017, 7:27 PM
thcipriani updated the task description. (Show Details)Oct 11 2017, 7:29 PM
thcipriani added a subscriber: Jdlrobson.Oct 11 2017, 7:33 PM

Adding @Jdlrobson since we touched this extension during SWAT recently

Jdlrobson added projects: Readers-Web-Kanbanana-Board-Old, Web-Team-Backlog.Oct 11 2017, 8:08 PM

Looks like this was caused by the work in T175856

Jdlrobson updated the task description. (Show Details)Oct 11 2017, 8:21 PM
Jdlrobson moved this task from Incoming to 2017-18 Q2 on the Web-Team-Backlog board.Oct 11 2017, 10:05 PM
Jdlrobson added a parent task: T178095: [EPIC] Fix problems with the PHP concatenation special page service.Oct 12 2017, 5:30 PM
gerritbot subscribed.Oct 12 2017, 10:00 PM

Change 383941 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/Collection@master] Handle and debug case where API returns no pages

https://gerrit.wikimedia.org/r/383941

gerritbot added a project: Patch-For-Review.Oct 12 2017, 10:00 PM
Jdlrobson added a project: good first task.Oct 12 2017, 10:04 PM

Looks like the issue here is the pages array is not defined. Seemed easy to I wrote a patch.

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptOct 12 2017, 10:04 PM
Jdlrobson moved this task from To Do to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.Oct 12 2017, 10:04 PM
phuedx moved this task from Needs Code Review to Needs More Work on the Readers-Web-Kanbanana-Board-Old board.Oct 16 2017, 12:48 PM
phuedx subscribed.

I've left a couple of minor questions on rECOL943316349253: Handle and debug case where API returns no pages. Moving to Needs More Work so that folk know that it's been reviewed.

Jdlrobson moved this task from Needs More Work to Doing on the Readers-Web-Kanbanana-Board-Old board.Oct 16 2017, 7:47 PM
Jdlrobson moved this task from Doing to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.Oct 16 2017, 7:53 PM
phuedx claimed this task.Oct 17 2017, 11:58 AM
phuedx reassigned this task from phuedx to Jdlrobson.Oct 17 2017, 4:31 PM

Whoops!

ovasileva triaged this task as Medium priority.Oct 17 2017, 4:35 PM
ovasileva set the point value for this task to 3.Oct 17 2017, 4:38 PM
phuedx raised the priority of this task from Medium to Unbreak Now!.Oct 17 2017, 4:45 PM

We tend to treat unhandled exceptions as UBN! This is semi-documented in our SWAT policy.

Restricted Application added subscribers: Liuxinyu970226, Jay8g. · View Herald TranscriptOct 17 2017, 4:45 PM
gerritbot added a comment.Oct 17 2017, 5:04 PM

Change 383941 merged by jenkins-bot:
[mediawiki/extensions/Collection@master] Handle and debug case where API returns no pages

https://gerrit.wikimedia.org/r/383941

Jdlrobson moved this task from Needs Code Review to Ready for Signoff on the Readers-Web-Kanbanana-Board-Old board.Oct 17 2017, 5:13 PM
Jdlrobson lowered the priority of this task from Unbreak Now! to High.Oct 17 2017, 5:57 PM
Jdlrobson removed a project: Patch-For-Review.

I don't believe this is unbreak now status.
Provided T178289 is swatted, this error will not be possible in production. Thus I suggest we focus on addressing that problem to avoid a SWAT here.
Please feel free to disagree.

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-10-24 (1.31.0-wmf.5)).Oct 17 2017, 6:00 PM
phuedx removed Jdlrobson as the assignee of this task.Oct 17 2017, 6:06 PM
Jdlrobson added a comment.Oct 18 2017, 11:47 PM

It's not possible for this to happen in production now.

phuedx added a comment.Oct 19 2017, 8:30 AM

@Jdlrobson: Why not?

Jdlrobson added a comment.Oct 19 2017, 3:45 PM

T178289 has been swatted making this code unreachable.

phuedx closed this task as Resolved.Oct 31 2017, 2:04 PM
phuedx claimed this task.

This exception hasn't bubbled to the top of the stack during the last two weeks: https://logstash.wikimedia.org/app/kibana#/discover?_g=(refreshInterval:(display:Off,pause:!f,value:0),time:(from:'2017-10-17T00:00:00.000Z',mode:absolute,to:'2017-10-31T00:00:00.000Z'))&_a=(columns:!(_source),filters:!(('$state':(store:appState),meta:(alias:!n,disabled:!f,index:'logstash-*',key:exception.message,negate:!f,value:'PHP+Warning:+Invalid+argument+supplied+for+foreach()'),query:(match:(exception.message:(query:'PHP+Warning:+Invalid+argument+supplied+for+foreach()',type:phrase))))),index:'logstash-*',interval:auto,query:(query_string:(analyze_wildcard:!t,query:BookRenderingMediator)),sort:!('@timestamp',desc))

🎉🎉🎉

Liuxinyu970226 unsubscribed.Nov 1 2017, 10:40 AM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:09 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL