NavPopups conflicts with Page previews on Italian Wikipedia
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Jdlrobson
	Oct 17 2017, 9:11 PM

Description

Steps to reproduce:

Visit it.wikipedia.org
Log in
Enable Popup di navigazione (NavPopups) in user preferences
1. https://it.wikipedia.org/wiki/Speciale:Preferenze#mw-prefsection-gadgets
Visit an article and hover over a link.

Both features appear, sometimes overlapping.

Expected behavior: After enabling NavPopups gadget, Page Previews should be suppressed.

Screen Shot 2017-10-04 at 9.46.33 AM.png (639×580 px, 252 KB)

Acceptance criteria

Add the following entry in operations/mediawiki-config for $wgPopupsConflictingNavPopupsGadgetName:

'itwiki' => 'Popup'

Details

	Subject	Repo	Branch	Lines +/-
	Use correct name for gadgets popup on itwiki	operations/mediawiki-config	master	+1 -0

Customize query in gerrit

Related Objects

Mentioned In: T178566: Mention global JS in NavPopups conflict message
T135630: Hovercards and NavPopups conflict
Mentioned Here: T178566: Mention global JS in NavPopups conflict message

Event Timeline

Jdlrobson created this task.Oct 17 2017, 9:11 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 17 2017, 9:11 PM

Jdlrobson mentioned this in T135630: Hovercards and NavPopups conflict.Oct 17 2017, 9:12 PM

Jdlrobson added a project: good first task.Oct 17 2017, 9:15 PM

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptOct 17 2017, 9:15 PM

ovasileva triaged this task as Medium priority.Oct 18 2017, 9:17 AM

As this is a config change.

phuedx updated the task description. (Show Details)Oct 18 2017, 10:32 AM

• Elitre subscribed.Oct 18 2017, 11:45 AM

ovasileva added a project: Readers-Web-Kanbanana-Board-Old.Oct 18 2017, 3:48 PM

Jdlrobson moved this task from Upcoming to 2017-18 Q2 on the Web-Team-Backlog board.Oct 18 2017, 4:50 PM

Jdlrobson moved this task from To Do to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.Oct 18 2017, 5:00 PM

Change 385007 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[operations/mediawiki-config@master] Use correct name for gadgets popup on itwiki

https://gerrit.wikimedia.org/r/385007

gerritbot added a project: Patch-For-Review.Oct 18 2017, 5:01 PM

Change 385007 merged by jenkins-bot:
[operations/mediawiki-config@master] Use correct name for gadgets popup on itwiki

https://gerrit.wikimedia.org/r/385007

Who will sign off?

Stand back! I'm going to try science!

🎉🎉🎉

I tested the following scenarios on itwiki:

Enable Page Previews
1. Navigate to Special:Preferences
2. Enable Page Previews
3. Dwell on a link
4. Observe that a preview appears 👍
Enable Page Previews and the NavPopups gadget
1. Navigate to Speciale:Preferences#mw-prefsection-gadgets
2. Enable the gadget
3. Observe that Page Previews can't be enabled or disabled as it's overridden by the gadget 👍
4. Dwell on a link
5. Observe that a navigation popup (a NavPopup?) appears 👍

I may have spoken to soon. @Elitre reports that they are still seeing Page Previews and NavPopups at the same time.

We determined this was actually due to me invoking NavPopups from my global.js at Meta.

I've captured updating the generic message that we display to users about possible conflicts with gadgets in T178566: Mention global JS in NavPopups conflict message.

	F9999788: Screen Shot 2017-10-04 at 9.46.33 AM.png
	Oct 17 2017, 9:11 PM

NavPopups conflicts with Page previews on Italian WikipediaClosed, ResolvedPublic1 Estimated Story PointsActions