Page MenuHomePhabricator
Create Task
Maniphest T178757

Add diff support for Lexeme
Closed, ResolvedPublic
Actions

Description

As an editor I want to see the details of a change another editor made in a diff in order to verify the change was good. This diff should behave the same way as a diff between 2 versions of an item.

Acceptance criteria:

  • I can see a diff between any two versions of a Lexeme.

Details

SubjectRepoBranchLines +/-
Add LexemeDiffVisualizermediawiki/extensions/WikibaseLexememaster+272 -2
Add ItemDiffVisualizerTestmediawiki/extensions/Wikibasemaster+155 -0
Move diffing visualizer stuff related to items to its dedicated classesmediawiki/extensions/Wikibasemaster+556 -221
Introduce DiffView interfacemediawiki/extensions/Wikibasemaster+28 -1
Rename DiffView to BasicDiffViewmediawiki/extensions/Wikibasemaster+9 -9
Make DiffView extendiblemediawiki/extensions/Wikibasemaster+3 -3
Customize query in gerrit

Related Objects

Event Timeline

Ladsgroup created this task.Oct 22 2017, 12:46 PM
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptOct 22 2017, 12:46 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot subscribed.Oct 22 2017, 12:46 PM

Change 385837 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/Wikibase@master] Make DiffView extendible

https://gerrit.wikimedia.org/r/385837

gerritbot added a project: Patch-For-Review.Oct 22 2017, 12:46 PM
gerritbot added a comment.Oct 22 2017, 1:27 PM

Change 385838 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/WikibaseLexeme@master] [WIP] Add LexemeDiffVisualizer

https://gerrit.wikimedia.org/r/385838

Ladsgroup mentioned this in rEWLE31c68614779f: [WIP] Add LexemeDiffVisualizer.Oct 22 2017, 1:28 PM
thiemowmde triaged this task as Medium priority.Oct 23 2017, 6:19 AM
thiemowmde moved this task from incoming to in progress on the Wikidata board.
thiemowmde added subscribers: thiemowmde, WMDE-leszek, • Jonas, Jakob_WMDE.
gerritbot added a comment.Oct 23 2017, 6:35 AM

Change 385837 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Make DiffView extendible

https://gerrit.wikimedia.org/r/385837

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-10-24 (1.31.0-wmf.5)).Oct 23 2017, 7:00 AM
Ladsgroup moved this task from Incoming to In progress on the User-Ladsgroup board.Oct 23 2017, 9:13 AM
gerritbot added a comment.Oct 24 2017, 10:40 AM

Change 386152 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/Wikibase@master] Rename DiffView to BasicDiffView

https://gerrit.wikimedia.org/r/386152

gerritbot added a comment.Oct 24 2017, 11:05 AM

Change 386152 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Rename DiffView to BasicDiffView

https://gerrit.wikimedia.org/r/386152

gerritbot added a comment.Oct 24 2017, 11:56 AM

Change 386160 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/Wikibase@master] Intorudce DiffView interface

https://gerrit.wikimedia.org/r/386160

Lydia_Pintscher moved this task from incoming to big tasks on the Wikidata Lexicographical data board.Oct 24 2017, 2:39 PM
Lydia_Pintscher merged a task: T173325: diff support for lexeme.Oct 24 2017, 2:54 PM
Lydia_Pintscher added subscribers: Bugreporter, PokestarFan.
Lydia_Pintscher updated the task description. (Show Details)Oct 24 2017, 3:08 PM
gerritbot added a comment.Oct 24 2017, 4:53 PM

Change 386227 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/Wikibase@master] Move diffing visualizer stuff related to items to its dedicated classes

https://gerrit.wikimedia.org/r/386227

gerritbot added a comment.Oct 24 2017, 5:25 PM

Change 386160 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Introduce DiffView interface

https://gerrit.wikimedia.org/r/386160

Ladsgroup moved this task from Doing to Review on the Wikidata-Former-Sprint-Board board.Oct 26 2017, 9:34 AM
ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2017-10-31 (1.31.0-wmf.6)); removed MW-1.31-release-notes (WMF-deploy-2017-10-24 (1.31.0-wmf.5)).Oct 30 2017, 3:01 PM
gerritbot added a comment.Nov 1 2017, 1:49 PM

Change 386227 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Move diffing visualizer stuff related to items to its dedicated classes

https://gerrit.wikimedia.org/r/386227

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2017-11-07 (1.31.0-wmf.7)); removed MW-1.31-release-notes (WMF-deploy-2017-10-31 (1.31.0-wmf.6)).Nov 1 2017, 2:00 PM
WMDE-leszek mentioned this in rEWLE41f51babb8dd: [WIP] Add LexemeDiffVisualizer.Nov 2 2017, 8:38 AM
Ladsgroup mentioned this in rEWLE7a298d899e72: [WIP] Add LexemeDiffVisualizer.Nov 2 2017, 10:46 AM
Ladsgroup mentioned this in rEWLEead3f6986011: Add LexemeDiffVisualizer.Nov 2 2017, 2:07 PM
Ladsgroup mentioned this in rEWLE27436a866c67: Add LexemeDiffVisualizer.
Ladsgroup mentioned this in rEWLE64a9ba4e4613: Add LexemeDiffVisualizer.Nov 2 2017, 2:13 PM
gerritbot added a comment.Nov 2 2017, 3:46 PM

Change 388077 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/Wikibase@master] Add ItemDiffVisualizerTest

https://gerrit.wikimedia.org/r/388077

Ladsgroup moved this task from In progress to Blocked on others on the User-Ladsgroup board.Nov 2 2017, 4:43 PM
Ladsgroup mentioned this in rEWLE324f1e10c486: Add LexemeDiffVisualizer.Nov 2 2017, 5:32 PM
gerritbot added a comment.Nov 2 2017, 5:34 PM

Change 388077 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add ItemDiffVisualizerTest

https://gerrit.wikimedia.org/r/388077

Ladsgroup mentioned this in rEWLEa9e247b4d95f: Add LexemeDiffVisualizer.Nov 3 2017, 9:45 AM
Ladsgroup mentioned this in rEWLEd2eb86ab0a72: Add LexemeDiffVisualizer.Nov 3 2017, 11:26 AM
gerritbot added a comment.Nov 3 2017, 12:04 PM

Change 385838 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Add LexemeDiffVisualizer

https://gerrit.wikimedia.org/r/385838

Ladsgroup moved this task from Review to Done on the Wikidata-Former-Sprint-Board board.Nov 3 2017, 12:05 PM
Ladsgroup closed this task as Resolved.Nov 21 2017, 10:59 AM
Ladsgroup removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits