Page MenuHomePhabricator
Create Task
Maniphest T178954

Wikipedia Portal has insecure link to CC license in footer
Closed, ResolvedPublic
Actions

Description

At the bottom of https://www.wikipedia.org/ , there's a footer which reads:

This page is available under the Creative Commons Attribution-ShareAlike License

The link there to CC uses http:// when it should use https://.

Details

SubjectRepoBranchLines +/-
Fix nonsecure link to CC license page on Wikipedia portal.wikimedia/portalsmaster+1 -1
Fix nonsecure link to CC license page on Wikipedia portal.wikimedia/portalsmaster+1 -1
Customize query in gerrit

Event Timeline

BBlack created this task.Oct 24 2017, 8:42 PM
Restricted Application added a project: Discovery-ARCHIVED. · View Herald TranscriptOct 24 2017, 8:42 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
MacFan4000 claimed this task.Oct 24 2017, 8:47 PM
gerritbot subscribed.Oct 24 2017, 8:53 PM

Change 386270 had a related patch set uploaded (by MacFan4000; owner: MacFan4000):
[wikimedia/portals@master] Fix nonsecure link to CC license page on Wikipedia portal.

https://gerrit.wikimedia.org/r/386270

gerritbot added a project: Patch-For-Review.Oct 24 2017, 8:53 PM
MacFan4000 added a project: good first task.Oct 24 2017, 9:30 PM
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptOct 24 2017, 9:30 PM
MaxSem closed this task as Resolved.Oct 25 2017, 2:15 AM
MaxSem subscribed.

Should be deployed with the next periodical portals update.

gerritbot added a comment.Oct 25 2017, 2:15 AM

Change 386270 merged by jenkins-bot:
[wikimedia/portals@master] Fix nonsecure link to CC license page on Wikipedia portal.

https://gerrit.wikimedia.org/r/386270

gerritbot added a comment.Oct 25 2017, 3:08 PM

Change 386401 had a related patch set uploaded (by Jdrewniak; owner: Jdrewniak):
[wikimedia/portals@master] Fix nonsecure link to CC license page on Wikipedia portal.

https://gerrit.wikimedia.org/r/386401

Jdrewniak subscribed.Oct 25 2017, 3:11 PM

I've updated this with a patch that makes the change in the handlebars templates instead of the generated html

debt reopened this task as Open.Oct 25 2017, 4:00 PM
debt triaged this task as Medium priority.
debt added a project: Discovery-Portal-Sprint.
debt subscribed.

Keeping this open, as we'll need to review the patch and then make sure it gets installed during our next portal update.

debt moved this task from Backlog to Needs code review on the Discovery-Portal-Sprint board.Oct 25 2017, 4:01 PM
gerritbot added a comment.Oct 25 2017, 5:43 PM

Change 386401 merged by jenkins-bot:
[wikimedia/portals@master] Fix nonsecure link to CC license page on Wikipedia portal.

https://gerrit.wikimedia.org/r/386401

Kizule closed this task as Resolved.Oct 25 2017, 6:16 PM
Kizule subscribed.

Now can be closed!

Kizule moved this task from Needs code review to Done on the Discovery-Portal-Sprint board.Oct 25 2017, 6:16 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits