Page MenuHomePhabricator

Clarify that spaces are not allowed in Phabricator usernames when creating an account
Closed, ResolvedPublic

Description

In the "Create an account" page (after authenticating), it isn't very clear to users that spaces are not allowed in usernames, nor what to do about that.

image.png (728×709 px, 74 KB)

The notice reads:

Usernames must contain only numbers, letters, period, underscore and hyphen, and can not end with a period. They must have no more than 64 characters.

I suggest changing this to:

Usernames must contain only numbers, Latin letters, period, underscore and hyphen, and can not end with a period. Spaces should be replaced with an underscore (_). They must have no more than 64 characters.

(Bolding just for visibility of change. Including an actual underscore so that users can copy&paste it. Specifying "Latin letters" per docs.)

I just helped an editor through this confusion, and I didn't realize myself that spaces weren't allowed which added to the confusion (I think I assumed that Phab automagically replaced them with underscores, like browsers do with typed URLs).

Event Timeline

Change 455265 had a related patch set uploaded (by Aklapper; owner: Aklapper):
[operations/puppet@production] Phab: Clarify that spaces are not allowed in user account names

https://gerrit.wikimedia.org/r/455265

Change 455265 had a related patch set uploaded (by Dzahn; owner: Aklapper):
[operations/puppet@production] Phab: Clarify that spaces are not allowed in user account names

https://gerrit.wikimedia.org/r/455265

Change 455265 merged by Dzahn:
[operations/puppet@production] Phab: Clarify that spaces are not allowed in user account names

https://gerrit.wikimedia.org/r/455265

merged and has been deployed but i can't confirm. the "create account" screen seems to have no extra message, not the old one in the screenshot above and also not the new one.

please verify.

Dzahn reassigned this task from Aklapper to mmodell.

Indeed, there is a one byte difference in the string now so strings don't match. Let me cook up a followup patch when I find more time.

String in upstream ./src/applications/people/storage/PhabricatorUser.php is
Usernames must contain only numbers, letters, period, underscore, and hyphen, and can not end with a period. They must have no more than %d characters.

String in https://gerrit.wikimedia.org/r/#/c/operations/puppet/+/455265/4/modules/phabricator/data/fixed_settings.yaml is
Usernames must contain only numbers, letters, period, underscore and hyphen, and can not end with a period. They must have no more than %d characters.

Change 511457 had a related patch set uploaded (by Aklapper; owner: Aklapper):
[operations/puppet@production] Phab: Fix a typo to match a string to overwrite

https://gerrit.wikimedia.org/r/511457

Indeed, there is a one byte difference in the string now so strings don't match.

Yep, though it looks to me as if upstream has it wrong and we have it right. That comma looks extra. But yea, let's match anyways:)

Change 511457 merged by Dzahn:
[operations/puppet@production] Phab: Fix a typo to match a string to overwrite

https://gerrit.wikimedia.org/r/511457

Works now; it shows: Usernames must contain only numbers, Latin letters, period, underscore and hyphen, and can not end with a period. They must have no more than 64 characters. Spaces should be replaced with an underscore (_). Thanks!

That comma looks extra.

Upstream keeps it Oxford, we ain't. :P