Page MenuHomePhabricator
Create Task
Maniphest T179321

Capitalizing a matching tag makes CodeMirror not recognize it
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

CodeMirror doesn't recognize matching tags when one is capitalized and the other isn't. The closing tag is treated like normal text, or like an incorrect tag.

Examples: <ref> and </Ref>, <Gallery> and </gallery>. See the screenshot.

ref gallery.jpg (310×374 px, 44 KB)

Details

SubjectRepoBranchLines +/-
Highlight match end tag with different capitalizationmediawiki/extensions/CodeMirrormaster+8 -1
Customize query in gerrit

Event Timeline

• DannyH created this task.Oct 30 2017, 6:33 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 30 2017, 6:33 PM
kaldari set the point value for this task to 5.Nov 1 2017, 11:37 PM
• DannyH moved this task from Needs Discussion to Product backlog on the Community-Tech board.Nov 1 2017, 11:38 PM
Niharika triaged this task as Lowest priority.Nov 7 2017, 11:09 PM
Liuxinyu970226 subscribed.Nov 27 2017, 10:10 AM
• TBolliger edited projects, added Community-Tech (2015-2017); removed Community-Tech.Feb 14 2018, 1:18 AM
• TBolliger moved this task from Backlog to Freezer on the Community-Tech (2015-2017) board.
Liuxinyu970226 unsubscribed.Feb 14 2018, 2:02 AM
TerraCodes subscribed.Feb 26 2018, 9:45 AM
gerritbot added a comment.Apr 13 2019, 9:46 PM

Change 503671 had a related patch set uploaded (by TheDJ; owner: TheDJ):
[mediawiki/extensions/CodeMirror@master] Hightlight match tag with different capitalization

https://gerrit.wikimedia.org/r/503671

gerritbot added a project: Patch-For-Review.Apr 13 2019, 9:46 PM
TheDJ claimed this task.Apr 13 2019, 9:46 PM
gerritbot added a comment.May 15 2019, 9:25 PM

Change 503671 merged by jenkins-bot:
[mediawiki/extensions/CodeMirror@master] Highlight match end tag with different capitalization

https://gerrit.wikimedia.org/r/503671

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.6; 2019-05-21).May 15 2019, 10:00 PM
Ladsgroup removed a project: Patch-For-Review.May 28 2019, 3:37 PM
TheDJ closed this task as Resolved.Feb 24 2020, 7:53 PM

this was fixed a while ago

TheDJ moved this task from Backlog to Done on the MediaWiki-extensions-CodeMirror board.Feb 26 2020, 10:10 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits