Page MenuHomePhabricator
Create Task
Maniphest T179415

Reference Tooltip: once disabled, cannot be reenabled via preferences>gadgets
Open, Needs TriagePublic
Actions

Description

Discovered while testing T179097

Steps:

  1. Login and navigate to an article with references
  2. Hover over a reference and view the reference tooltip
  3. Click the settings icon and disable reference tooltips via the popup
  4. Hover over a reference and verify no tooltip appears
  5. Navigate to preferences>gadgets and attempt to reenable reference tooltips

Expected Result:
The reference tooltip item is unchecked and checking it reenables the tool

Actual Result:
The reference tooltip is checked (it should not be). Fiddling with the check mark seems to have no effect. After unchecking, rechecking, and then saving the preferences, the reference tooltip still does not appear when hovering over a reference.

Tested on a couple of different accounts using Windows with IE and Edge and also Mac with Safari and Chrome. The bug was present on all of them.

@ovasileva - I wasn't sure if this is a 'readers' bug or if it belongs elsewhere. Can you take a look at tag appropriately?

Related Objects

Event Timeline

ABorbaWMF created this task.Oct 31 2017, 4:49 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 31 2017, 4:49 PM
Nirmos subscribed.Oct 31 2017, 10:05 PM

As far as I can see, https://en.wikipedia.org/wiki/MediaWiki:Gadget-ReferenceTooltips.js does not attempt send any API call to change the preferences so that the gadget is disabled. It sets a cookie that lasts for 90 days that disables it.

Jdlrobson edited projects, added Local-Wiki-Template-And-Gadget-Issues, MediaWiki-extensions-Gadgets, MediaWiki-General; removed Web-Team-Backlog.Oct 31 2017, 10:50 PM
Jdlrobson subscribed.

This is a user gadget and has nothing to do with WMF. Not sure what is the appropriate place to feed this back. The talk page on English Wikipedia maybe (but that might not necessarily filter to other wikis)?

Nirmos removed a project: MediaWiki-extensions-Gadgets.Oct 31 2017, 11:13 PM

As far as I can see, https://en.wikipedia.org/wiki/MediaWiki:Gadget-ReferenceTooltips.js does not attempt send any API call to change the preferences so that the gadget is disabled. It sets a cookie that lasts for 90 days that disables it.

...which makes sense, because the gadget is enabled by default (which means anons get it) but only registered users have preferences. What ABorbaWMF wants to do isn't impossible, but you would have to do different things depending on whether mw.user.isAnon() or not.

Also, the Gadgets tag "is not meant for reporting bugs or problems with local gadgets themselves".

Aklapper edited projects, added WMF-General-or-Unknown; removed MediaWiki-General.Nov 1 2017, 4:39 PM

There is a good chance that a gadget maintainer (if existing) will never see this task reported in "Wikimedia Phabricator".
https://en.wikipedia.org/wiki/MediaWiki_talk:Gadget-ReferenceTooltips.js might be a better place to bring this up. We generally don't track random gadget issues of random sites in Phabricator. See https://phabricator.wikimedia.org/T85433 and https://phabricator.wikimedia.org/T167983#3515844 for a high-level explanation

Jdlrobson moved this task from Backlog to Gadget problems on the Local-Wiki-Template-And-Gadget-Issues board.Nov 21 2018, 6:42 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL