Page MenuHomePhabricator
Create Task
Maniphest T181253

Make UI use wbsetclaim API for Form Statements
Closed, ResolvedPublic
Actions

Description

Use StatementChanger in ControllerViewfactory for Form Statements

Details

SubjectRepoBranchLines +/-
Refactor response code in AddForm for readability/claritymediawiki/extensions/WikibaseLexememaster+6 -5
Update lastrevid after adding a new Formmediawiki/extensions/WikibaseLexememaster+30 -4
Teach wb.RevisionStore.js to deal with (sub-)entitiesmediawiki/extensions/Wikibasemaster+40 -0
Use StatementChanger in ControllerViewfactory for Form Statementsmediawiki/extensions/WikibaseLexememaster+1 -1
Expose JS RevisionStore to custom Changers registered by extensionmediawiki/extensions/Wikibasemaster+8 -0
Set the form revision data after saving a form with a FormChangermediawiki/extensions/WikibaseLexememaster+67 -10
Adapt JS statement revision data to allow saving statement on formsmediawiki/extensions/WikibaseLexememaster+130 -5
Return the revision ID after adding form with wblexemeaddform APImediawiki/extensions/WikibaseLexememaster+22 -0
Deserialize form-level statement datamediawiki/extensions/WikibaseLexememaster+42 -6
Update the base revision after saving a form with a FormChangermediawiki/extensions/WikibaseLexememaster+49 -5
Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 23 2017, 4:09 PM
• Jonas moved this task from Backlog to In Progress on the Wikidata-Sprint-2017-11-22 board.Nov 23 2017, 4:10 PM
gerritbot subscribed.Nov 23 2017, 4:26 PM

Change 393093 had a related patch set uploaded (by Jonas Kress (WMDE); owner: Jonas Kress (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Use StatementChanger in ControllerViewfactory for Form Statements

https://gerrit.wikimedia.org/r/393093

gerritbot added a project: Patch-For-Review.Nov 23 2017, 4:26 PM
• Jonas mentioned this in rEWLE11180838f3e0: Use StatementChanger in ControllerViewfactory for Form Statements.Nov 23 2017, 4:26 PM
• Jonas moved this task from In Progress to Review on the Wikidata-Sprint-2017-11-22 board.Nov 24 2017, 11:06 AM
WMDE-leszek added a project: Wikidata-Sprint-2017-12-06.Dec 5 2017, 2:16 PM
WMDE-leszek moved this task from Backlog to Review on the Wikidata-Sprint-2017-12-06 board.
thiemowmde mentioned this in rEWLEd4581a0b412e: Use StatementChanger in ControllerViewfactory for Form Statements.Dec 8 2017, 3:12 PM
thiemowmde mentioned this in rEWLE7a1a6f1be810: Use StatementChanger in ControllerViewfactory for Form Statements.Dec 8 2017, 4:31 PM
WMDE-leszek mentioned this in rEWLE525cff5a3a78: Use StatementChanger in ControllerViewfactory for Form Statements.Dec 12 2017, 12:48 PM
WMDE-leszek mentioned this in rEWLE68ac0c58e812: Return the revision ID after adding form with wblexemeaddform API.Dec 12 2017, 3:05 PM
WMDE-leszek mentioned this in rEWLEc7877fc5355a: Update the base revision after saving a form with a FormChanger.
WMDE-leszek mentioned this in rEWLE038f6caec47a: Use StatementChanger in ControllerViewfactory for Form Statements.
gerritbot added a comment.Dec 12 2017, 4:07 PM

Change 397837 had a related patch set (by WMDE-leszek) published:
[mediawiki/extensions/WikibaseLexeme@master] Return the revision ID after adding form with wblexemeaddform API

https://gerrit.wikimedia.org/r/397837

WMDE-leszek mentioned this in rEWLE760f9bbd25c5: Update the base revision after saving a form with a FormChanger.Dec 12 2017, 4:07 PM
WMDE-leszek mentioned this in rEWLEa490833eebbc: Use StatementChanger in ControllerViewfactory for Form Statements.Dec 12 2017, 4:11 PM
gerritbot added a comment.Dec 13 2017, 4:07 PM

Change 398068 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Thiemo Mättig (WMDE)):
[mediawiki/extensions/Wikibase@master] Teach wb.RevisionStore.js to deal with (sub-)entities

https://gerrit.wikimedia.org/r/398068

gerritbot added a comment.Dec 13 2017, 4:25 PM

Change 398070 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Thiemo Mättig (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Update lastrevid after adding a new Form

https://gerrit.wikimedia.org/r/398070

thiemowmde mentioned this in rEWLEb30ae82990bb: Update lastrevid after adding a new Form.Dec 13 2017, 4:30 PM
gerritbot added a comment.Dec 15 2017, 4:05 PM

Change 398496 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/WikibaseLexeme@master] Adapt JS statement revision data to allow saving statement on forms

https://gerrit.wikimedia.org/r/398496

WMDE-leszek mentioned this in rEWLE5ed2855be135: Adapt JS statement revision data to allow saving statement on forms.Dec 15 2017, 4:06 PM
gerritbot added a comment.Dec 18 2017, 9:23 AM

Change 397838 abandoned by WMDE-leszek:
Update the base revision after saving a form with a FormChanger

https://gerrit.wikimedia.org/r/397838

WMDE-leszek mentioned this in rEWLE40dd97939d58: Adapt JS statement revision data to allow saving statement on forms.Dec 18 2017, 10:36 AM
WMDE-leszek mentioned this in rEWLEef47ec266bc6: Set the form revision data after saving a form with a FormChanger.
WMDE-leszek renamed this task from Make UI use wbsetclaim API for Form Statements to Make UI use wbsetclaim API for Form Statements (days: 1).Dec 18 2017, 11:19 AM
WMDE-leszek claimed this task.Dec 18 2017, 1:18 PM
WMDE-leszek mentioned this in rEWLE05eecc68291a: Adapt JS statement revision data to allow saving statement on forms.Dec 18 2017, 2:15 PM
WMDE-leszek mentioned this in rEWLE35309c0e227c: Set the form revision data after saving a form with a FormChanger.
WMDE-leszek mentioned this in rEWLE59185aeb7813: Use StatementChanger in ControllerViewfactory for Form Statements.
WMDE-leszek mentioned this in rEWLE865ff71249ba: Return the revision ID after adding form with wblexemeaddform API.Dec 18 2017, 2:22 PM
WMDE-leszek mentioned this in rEWLE32f058de13eb: Adapt JS statement revision data to allow saving statement on forms.
WMDE-leszek mentioned this in rEWLEdfb26ec1f8c9: Set the form revision data after saving a form with a FormChanger.
WMDE-leszek mentioned this in rEWLE7ba39f655211: Use StatementChanger in ControllerViewfactory for Form Statements.
WMDE-leszek mentioned this in rEWLEdb846c06055d: Adapt JS statement revision data to allow saving statement on forms.Dec 18 2017, 2:31 PM
WMDE-leszek mentioned this in rEWLEb520b7b84e83: Set the form revision data after saving a form with a FormChanger.
WMDE-leszek mentioned this in rEWLE0f41844c6a5d: Use StatementChanger in ControllerViewfactory for Form Statements.
WMDE-leszek mentioned this in rEWLE8a6a4a37e873: Use StatementChanger in ControllerViewfactory for Form Statements.Dec 18 2017, 2:55 PM
WMDE-leszek mentioned this in rEWLE8134ba79a475: Use StatementChanger in ControllerViewfactory for Form Statements.Dec 18 2017, 4:39 PM
gerritbot added a comment.Dec 19 2017, 8:34 AM

Change 398844 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/WikibaseLexeme@master] Deserialize form-level statement data

https://gerrit.wikimedia.org/r/398844

WMDE-leszek mentioned this in rEWLEb28cbbba863e: Deserialize form-level statement data.Dec 19 2017, 8:36 AM
WMDE-leszek mentioned this in rEWLE352534024f0d: Deserialize form-level statement data.Dec 19 2017, 8:48 AM
WMDE-leszek mentioned this in rEWLE9126be919bab: Return the revision ID after adding form with wblexemeaddform API.
WMDE-leszek mentioned this in rEWLE3397bc277fd8: Adapt JS statement revision data to allow saving statement on forms.
WMDE-leszek mentioned this in rEWLE6ffbbd27dd2a: Set the form revision data after saving a form with a FormChanger.
WMDE-leszek mentioned this in rEWLE3522cf114a97: Deserialize form-level statement data.Dec 19 2017, 9:00 AM
WMDE-leszek mentioned this in rEWLE0170a8cc31a2: Return the revision ID after adding form with wblexemeaddform API.
WMDE-leszek mentioned this in rEWLE00497de5f4d1: Adapt JS statement revision data to allow saving statement on forms.
WMDE-leszek mentioned this in rEWLEc2d57f662e0a: Set the form revision data after saving a form with a FormChanger.
WMDE-leszek mentioned this in rEWLE5b63ea60f4f8: Use StatementChanger in ControllerViewfactory for Form Statements.
WMDE-leszek mentioned this in rEWLE332128262e99: Use StatementChanger in ControllerViewfactory for Form Statements.
WMDE-leszek mentioned this in rEWLE6a3b71f72156: Adapt JS statement revision data to allow saving statement on forms.Dec 19 2017, 9:13 AM
WMDE-leszek mentioned this in rEWLE70b5cd7eb9a6: Use StatementChanger in ControllerViewfactory for Form Statements.
WMDE-leszek mentioned this in rEWLEdb1b69490f11: Set the form revision data after saving a form with a FormChanger.Dec 19 2017, 9:19 AM
WMDE-leszek mentioned this in rEWLEbb963aacb5be: Use StatementChanger in ControllerViewfactory for Form Statements.
WMDE-leszek renamed this task from Make UI use wbsetclaim API for Form Statements (days: 1) to Make UI use wbsetclaim API for Form Statements (days: 2).Dec 19 2017, 11:45 AM
WMDE-leszek mentioned this in rEWLEf3947a5c2f58: Use StatementChanger in ControllerViewfactory for Form Statements.Dec 19 2017, 12:49 PM
WMDE-leszek renamed this task from Make UI use wbsetclaim API for Form Statements (days: 2) to Make UI use wbsetclaim API for Form Statements.Dec 19 2017, 2:26 PM
WMDE-leszek added a project: Wikidata-Sprint-2017-12-20.
WMDE-leszek moved this task from Backlog to Review on the Wikidata-Sprint-2017-12-20 board.
WMDE-leszek removed WMDE-leszek as the assignee of this task.Dec 19 2017, 3:18 PM
WMDE-leszek subscribed.
gerritbot added a comment.Dec 19 2017, 3:24 PM

Change 398844 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Deserialize form-level statement data

https://gerrit.wikimedia.org/r/398844

gerritbot added a comment.Dec 19 2017, 3:34 PM

Change 399197 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Refactor response code in AddForm for readability/clarity

https://gerrit.wikimedia.org/r/399197

thiemowmde mentioned this in rEWLEb8b96c524674: Refactor response code in AddForm for readability/clarity.Dec 19 2017, 3:35 PM
gerritbot added a comment.Dec 19 2017, 3:44 PM

Change 397837 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Return the revision ID after adding form with wblexemeaddform API

https://gerrit.wikimedia.org/r/397837

WMDE-leszek mentioned this in rEWLE7740bdef0206: Use StatementChanger in ControllerViewfactory for Form Statements.Dec 19 2017, 5:01 PM
WMDE-leszek mentioned this in rEWLE24d7ee22a5a3: Adapt JS statement revision data to allow saving statement on forms.Dec 21 2017, 3:58 PM
WMDE-leszek mentioned this in rEWLE627c2cfedbaa: Set the form revision data after saving a form with a FormChanger.
WMDE-leszek mentioned this in rEWLEf47b8c0dbe93: Set the form revision data after saving a form with a FormChanger.Dec 21 2017, 4:01 PM
WMDE-leszek mentioned this in rEWLE1fa2b7af4000: Use StatementChanger in ControllerViewfactory for Form Statements.Dec 21 2017, 4:04 PM
WMDE-leszek mentioned this in rEWLE937fe909de0b: Adapt JS statement revision data to allow saving statement on forms.Dec 22 2017, 8:21 AM
WMDE-leszek mentioned this in rEWLEcb15f4bc91e2: Adapt JS statement revision data to allow saving statement on forms.
WMDE-leszek mentioned this in rEWLE8f1519f9b91a: Adapt JS statement revision data to allow saving statement on forms.Dec 22 2017, 8:33 AM
WMDE-leszek mentioned this in rEWLEd626ef3cafc6: Set the form revision data after saving a form with a FormChanger.Dec 22 2017, 8:44 AM
WMDE-leszek mentioned this in rEWLE0d0546d89c8d: Use StatementChanger in ControllerViewfactory for Form Statements.Dec 22 2017, 9:00 AM
WMDE-leszek mentioned this in rEWLE43a20b13e47e: Set the form revision data after saving a form with a FormChanger.Dec 22 2017, 11:48 AM
WMDE-leszek mentioned this in rEWLE0493eab405c3: Use StatementChanger in ControllerViewfactory for Form Statements.Dec 22 2017, 12:01 PM
WMDE-leszek mentioned this in rEWLE115f1ab016c4: Adapt JS statement revision data to allow saving statement on forms.Dec 22 2017, 1:57 PM
WMDE-leszek mentioned this in rEWLE4a34dc73bbea: Set the form revision data after saving a form with a FormChanger.
WMDE-leszek mentioned this in rEWLE285506aaf893: Use StatementChanger in ControllerViewfactory for Form Statements.
gerritbot added a comment.Dec 27 2017, 11:26 AM

Change 397797 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Expose JS RevisionStore to custom Changers registered by extension

https://gerrit.wikimedia.org/r/397797

gerritbot added a comment.Dec 27 2017, 11:26 AM

Change 398496 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Adapt JS statement revision data to allow saving statement on forms

https://gerrit.wikimedia.org/r/398496

gerritbot added a comment.Dec 27 2017, 11:26 AM

Change 398805 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Set the form revision data after saving a form with a FormChanger

https://gerrit.wikimedia.org/r/398805

gerritbot added a comment.Dec 27 2017, 11:37 AM

Change 393093 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Use StatementChanger in ControllerViewfactory for Form Statements

https://gerrit.wikimedia.org/r/393093

WMDE-leszek moved this task from Review to Done on the Wikidata-Sprint-2017-12-20 board.Dec 27 2017, 11:52 AM
ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)).Dec 27 2017, 12:00 PM
WMDE-leszek closed this task as Resolved.Jan 2 2018, 2:30 PM
gerritbot added a comment.Jan 8 2018, 4:20 PM

Change 398068 abandoned by Thiemo Kreuz (WMDE):
Teach wb.RevisionStore.js to deal with (sub-)entities

https://gerrit.wikimedia.org/r/398068

gerritbot added a comment.Jan 10 2018, 5:17 PM

Change 398070 abandoned by Thiemo Kreuz (WMDE):
Update lastrevid after adding a new Form

Reason:
I resubmitted the documentation snippets as I55c3cb0.

https://gerrit.wikimedia.org/r/398070

gerritbot added a comment.Mar 6 2018, 11:53 AM

Change 399197 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Refactor response code in AddForm for readability/clarity

https://gerrit.wikimedia.org/r/399197

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits