[Secure HTML extension] 2 warnings: Undefined index, non-static
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Stefahn
	Nov 26 2017, 6:27 PM

Description

I guess this is related to https://phabricator.wikimedia.org/T180857

There are 2 issues when generating a new secure HTML code via Special:SecureHTML.

When calling Special:SecureHTML this warning appears:

Notice: Undefined index: in /mediawiki/extensions/SecureHTML/SpecialSecureHTML.php on line 40

After entering a HTML code the Secure HTML code is parsed and shown. However there is a warning:

Strict Standards: call_user_func() expects parameter 1 to be a valid callback, non-static method SpecialSecureHTML::trySubmit() should not be called statically in /mediawiki/includesformForm.php on line 613

Tried both the REL_1_27 and master version of https://www.mediawiki.org/wiki/Extension:Secure_HTML and MediaWiki 1.27.4.

Details

	Subject	Repo	Branch	Lines +/-
	Fix callable for SpecialSecureHTML::trySubmit	mediawiki/extensions/SecureHTML	master	+1 -1

Customize query in gerrit

Event Timeline

Stefahn created this task.Nov 26 2017, 6:27 PM

Reedy unsubscribed.Nov 26 2017, 6:41 PM

You'd be advised to download the 1.27 version of the extension from https://www.mediawiki.org/wiki/Special:ExtensionDistributor/SecureHTML if you are on MediaWiki 1.27.

I tried with the 1.27 version and it throws the same errors.

Stefahn added a project: MediaWiki-extensions-Page_Forms.Nov 27 2017, 10:08 AM

Stefahn added a comment.Nov 29 2017, 4:57 PM

This comment was removed by Stefahn.

Is it only the 3rd issue that requires the presence of Page Forms to happen, or all of them?

Stefahn added a comment.Nov 29 2017, 10:22 PM

This comment was removed by Stefahn.

Stefahn added a comment.Nov 29 2017, 11:17 PM

This comment was removed by Stefahn.

I think a new bug report is the way to go, yes. Hopefully there you can clarify exactly how to reproduce this issue.

Okay, added a new bug report: https://phabricator.wikimedia.org/T181903.
I will update the description of this bug report and delete my unrelated comments.

Stefahn renamed this task from SecureHTML: Undefined index, non-static, DBUnexpectedError to 2 warnings in SecureHTML: Undefined index, non-static.Dec 2 2017, 10:01 PM

Stefahn updated the task description. (Show Details)

Stefahn removed a project: MediaWiki-extensions-Page_Forms.

Stefahn removed a subscriber: Yaron_Koren.

Umherirrender unsubscribed.Jan 1 2018, 1:53 PM

https://www.mediawiki.org/wiki/Extension:SecureHTML told me: This extension has been archived.

But there's a problem to be clarified: Is this about Secure_HTML?

Yes, it's about https://www.mediawiki.org/wiki/Extension:Secure_HTML

Aklapper renamed this task from 2 warnings in SecureHTML: Undefined index, non-static to [Secure HTML extension] 2 warnings: Undefined index, non-static.Sep 20 2018, 8:55 AM

Aklapper triaged this task as Lowest priority.Dec 1 2022, 5:17 PM

Assigning this as I made patch that should fix issues with the SecureHTML extension.

Restricted Application added a project: User-Kizule. · View Herald TranscriptMar 30 2024, 3:30 PM

Kizule moved this task from Inbox to To deploy on the User-Kizule board.Mar 30 2024, 3:30 PM

Change #1015593 had a related patch set uploaded (by Zoranzoki21; author: Zoranzoki21):

[mediawiki/extensions/SecureHTML@master] Make extension working with MediaWiki 1.39+

https://gerrit.wikimedia.org/r/1015593

gerritbot added a project: Patch-For-Review.Mar 30 2024, 3:30 PM

Change #1015593 merged by jenkins-bot:

[mediawiki/extensions/SecureHTML@master] Fix callable for SpecialSecureHTML::trySubmit

https://gerrit.wikimedia.org/r/1015593

I'm going to close this task as resolved. Task description is mentioning MediaWiki 1.27 which is not supported anymore.

I've tested extension with my patch, and it's working as it's supposed to work.

[Secure HTML extension] 2 warnings: Undefined index, non-staticClosed, ResolvedPublicActions

Description

Details

Event Timeline

[Secure HTML extension] 2 warnings: Undefined index, non-static
Closed, ResolvedPublic
Actions