Page MenuHomePhabricator

As an iPhone X user with an OLED screen, I would like to have an option to have a true black dark mode for its energy saving properties and aesthetics.
Closed, ResolvedPublic

Assigned To
Authored By
cmadeo
Dec 1 2017, 7:50 PM
Referenced Files
F11850018: giphy-downsized (14).gif
Dec 15 2017, 7:48 PM
F11834114: Black mode color palette.png
Dec 14 2017, 10:26 PM
F11834067: Black mode color palette.png
Dec 14 2017, 10:20 PM
F11796288: IMG_776DFD4CA8D7-1.jpeg
Dec 12 2017, 11:49 PM
F11796275: IMG_4755.PNG
Dec 12 2017, 11:49 PM
F11796316: IMG_4759.PNG
Dec 12 2017, 11:49 PM
F11231322: Settings > Reading themes.png
Dec 7 2017, 12:42 AM
F11231325: Reading Controls Black.png
Dec 7 2017, 12:42 AM
Tokens
"Mountain of Wealth" token, awarded by JMinor.

Description

Link to corresponding Android ticket

https://phabricator.wikimedia.org/T173319

Why are we doing this?

A few iPhone X users with OLED screens have requested a way to have a black dark mode, so that they can benefit from energy saving. Additionally, some iPhone X users have requested this feature for aesthetic reasons, as the bezel around the screen of the iPhone X is a true black. Additionally, this feature will soon be available on Android.

Proposed Design

Changing themes
Users will be able to select black mode from the appearance theme selector in the Article view or in settings.

Color Palette - iOS

Black mode color palette.png (1×899 px, 131 KB)

ElementBlack theme color
BaseBase 4- Pitch Black #101418
PaperBase 0 - Pure Black #000
Mid-backgroundBase 10 - #222
ChromeBase 10 - #222
All other elementsAs per dark theme

Mocks

Black mode Explore feedBlack mode ArticleBlack mode Article with reading themes openBlack mode Settings Theme selection in Settings
Black mode - Feed.png (2×375 px, 710 KB)
Black mode - Article.png (3×375 px, 526 KB)
Reading Controls Black.png (667×375 px, 191 KB)
Black mode - settings.png (1×375 px, 79 KB)
Settings > Reading themes.png (830×375 px, 61 KB)
Zeplin: http://zpl.io/VDpLWOWZeplin: http://zpl.io/bAOLWvqZeplin: http://zpl.io/aRmeGNgZeplin: http://zpl.io/Vq1NLE7Zeplin: http://zpl.io/VQMw0X5

Event Timeline

@JoeWalsh so far everything is looking good on the native views with Black mode. I have seen two bugs though, one reliably reproducible and the other I only saw once.


The TOC theme seems to be sticking after changing themes. The first theme chosen is then used (only in the TOC) on the subsequent theme choices. It does eventually switch over to another TOC theme, but often this TOC theme is then sticky on other themes. In some cases it appears to be showing the text styling from one theme and the paper color of another theme.

IMG_4755.PNG (1×750 px, 273 KB)
IMG_776DFD4CA8D7-1.jpeg (1×750 px, 249 KB)

Steps to reproduce:
Open article with Sepia theme active
Open TOC
Switch to Black mode
Open TOC

Expected results
Black mode TOC is shown

Actual results
Sepia TOC is shown


On my first load, just the saved tab table view was utilizing the default styling rather than the black mode styling. I have not been able to reproduce this.

IMG_4759.PNG (1×750 px, 439 KB)

cmadeo added a subscriber: Mhurd.

Updated color palette and Zeplin to reflect updates made during paring session with @Mhurd.

giphy-downsized (14).gif (200×210 px, 1012 KB)

Looking ready for hardcore nocturnal readers!
Thanks @JoeWalsh!

@JoeWalsh @JMinor @ABorbaWMF TSG doesn't have an iPhone X device so I recommend someone that does test this instead. Thanks!

Tested black mode on a few devices and it is looking good on 5.7.3 (1296).

JMinor awarded a token.