Page MenuHomePhabricator
Create Task
Maniphest T182164

[wmf.11- regression] testwiki: Related changes - articles titles displayed incorrectly in 'Select a page' textbox
Closed, ResolvedPublic
Actions

Assigned To
SBisson
Authored By
Etonkovidova
Dec 6 2017, 1:27 AM
Tags
Referenced Files
F11817194: Screen Shot 2017-12-13 at 5.35.00 PM.png
Dec 14 2017, 1:37 AM
F11211084: Screen Shot 2017-12-05 at 5.21.55 PM.png
Dec 6 2017, 1:27 AM
F11211090: Screen Shot 2017-12-05 at 5.18.45 PM.png
Dec 6 2017, 1:27 AM
F11211080: Screen Shot 2017-12-05 at 5.21.44 PM.png
Dec 6 2017, 1:27 AM
F11211009: Screen Shot 2017-12-05 at 4.47.34 PM.png
Dec 6 2017, 1:27 AM
F11211005: Screen Shot 2017-12-05 at 4.47.20 PM.png
Dec 6 2017, 1:27 AM
F11211087: Screen Shot 2017-12-05 at 5.18.28 PM.png
Dec 6 2017, 1:27 AM
Subscribers
Aklapper
Etonkovidova
gerritbot
Trizek-WMF

Description

The issue might be specific to testwiki setup, otherwise the issue is a regression.

  1. Enable RC filters and click on Random page option on the left side navigation. Keep going through random articles until you see an article with two (or more) words in the title.
  2. Click on the Related changes - the article title will be displayed with white spaces indicated with underscores.

Screen Shot 2017-12-05 at 5.18.28 PM.png (337×528 px, 46 KB)

Screen Shot 2017-12-05 at 5.18.45 PM.png (374×487 px, 47 KB)

Since testwiki has a variety of article titles in different languages - Related changes will display several cases of url-encoded titles in the text box:
Screen Shot 2017-12-05 at 4.47.34 PM.png (371×578 px, 46 KB)

Screen Shot 2017-12-05 at 4.47.20 PM.png (440×604 px, 63 KB)

One of the most mangled titles:

Screen Shot 2017-12-05 at 5.21.44 PM.png (361×864 px, 79 KB)

Screen Shot 2017-12-05 at 5.21.55 PM.png (346×453 px, 46 KB)

Note:

  1. Without new filters I did not see any problems with articles' titles display in test wiki.
  2. I did not see any problems with articles' titles display in wmf.10

Details

SubjectRepoBranchLines +/-
RCLFilters: display target page as a titlemediawiki/corewmf/1.31.0-wmf.12+8 -2
RCLFilters: display target page as a titlemediawiki/coremaster+8 -2
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.Dec 6 2017, 1:27 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 6 2017, 1:27 AM
Etonkovidova updated the task description. (Show Details)Dec 6 2017, 5:21 PM
gerritbot subscribed.Dec 6 2017, 10:03 PM

Change 395866 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/core@master] RCLFilters: display target page as a title

https://gerrit.wikimedia.org/r/395866

gerritbot added a project: Patch-For-Review.Dec 6 2017, 10:03 PM
SBisson claimed this task.Dec 6 2017, 10:13 PM
SBisson moved this task from Untriaged to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
SBisson merged a task: T182686: When accessed from a page that have diacritics in its title, RecentChangesLinked is broken.Dec 12 2017, 1:55 PM
SBisson added a subscriber: Trizek-WMF.
Catrope moved this task from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Dec 13 2017, 9:08 PM
gerritbot added a comment.Dec 13 2017, 9:14 PM

Change 395866 merged by jenkins-bot:
[mediawiki/core@master] RCLFilters: display target page as a title

https://gerrit.wikimedia.org/r/395866

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)).Dec 13 2017, 10:00 PM
Etonkovidova added a comment.Dec 14 2017, 1:37 AM

Checked in betalabs - the titles are displayed correctly:

Screen Shot 2017-12-13 at 5.35.00 PM.png (293×570 px, 39 KB)

Etonkovidova closed this task as Resolved.Dec 14 2017, 1:38 AM
SBisson mentioned this in T172161: Integrate 'Related Changes' tools into the new UX.Dec 14 2017, 11:27 AM
gerritbot added a comment.Dec 14 2017, 11:53 AM

Change 398242 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/core@wmf/1.31.0-wmf.12] RCLFilters: display target page as a title

https://gerrit.wikimedia.org/r/398242

Trizek-WMF added a comment.Dec 14 2017, 1:59 PM

Has it been SWATed or is it on the train?

gerritbot added a comment.Dec 14 2017, 2:09 PM

Change 398242 merged by Hashar:
[mediawiki/core@wmf/1.31.0-wmf.12] RCLFilters: display target page as a title

https://gerrit.wikimedia.org/r/398242

SBisson added a comment.Dec 14 2017, 2:20 PM
In T182164#3837466, @Trizek-WMF wrote:

Has it been SWATed or is it on the train?

It is being deployed to 1.31.0-wmf.12 as we speak. It will reach the wikipedias later today with the train.

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2017-12-12 (1.31.0-wmf.12)); removed MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)).Dec 14 2017, 3:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL