Utilize a consistent sub-section header style on Settings and in the Article footer
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	cmadeo
	Dec 21 2017, 8:53 PM

Description

Why are we doing this?

Currently there are two section very similar header styles used in the app. To improve consistency and polish we should settle on a single style.

Article footer	Settings

Design proposal

Utilize the Settings header design throughout the app, as this design is most closely based on the iOS header style and is used as the subheader style for cards on the Explore feed.

Wikipedia app settings screen

Zeplin: https://zpl.io/bW1BdvK

Text size: 14pt
Font: SFUIText-Regular
Line Height: 19pt
Color: #72777d
Letter spacing -0.1pt
Left padding 18pt
Top padding: 35pt
Bottom padding: 5pt

Related Objects

Mentioned In: rAPIOS1a466abf4671: Merge pull request #2584 from wikimedia/update/sub-section-consistency/T183502
rAPIOSbeaa53de730b: Merge branch 'develop' into update/sub-section-consistency/T183502
rAPIOSdc9dd99818af: Merge branch 'develop' into update/sub-section-consistency/T183502

Event Timeline

cmadeo created this task.Dec 21 2017, 8:53 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 21 2017, 8:53 PM

• JMinor triaged this task as Medium priority.Jan 11 2018, 7:51 PM

• JMinor moved this task from Tasks from Product Backlog to Needs Engineering Sync on the iOS-app-v5.8.0-Manatee-On-A-Skateboard board.

• NHarateh_WMF edited projects, added Wikipedia-iOS-App-Backlog; removed Wikipedia-iOS-App-Backlog (Administrative).Feb 6 2018, 3:44 PM

• JMinor edited projects, added iOS-app-v6.0-Walrus-On-A-Unicycle; removed iOS-app-v5.8.0-Manatee-On-A-Skateboard.Feb 13 2018, 9:04 PM

• JMinor moved this task from Needs Triage to Design on the Wikipedia-iOS-App-Backlog board.Feb 13 2018, 9:11 PM

• JMinor edited projects, added Wikipedia-iOS-App-Backlog (Design); removed Wikipedia-iOS-App-Backlog.

• JMinor moved this task from Tasks from Product Backlog to Needs Acceptance Criteria on the iOS-app-v6.0-Walrus-On-A-Unicycle board.Mar 8 2018, 6:36 PM

• JMinor lowered the priority of this task from Medium to Low.Mar 8 2018, 6:45 PM

• JMinor moved this task from Needs Acceptance Criteria to Needs Engineering Sync on the iOS-app-v6.0-Walrus-On-A-Unicycle board.

cmadeo renamed this task from Utilize a consistent header style throughout the app to Utilize a consistent section header style throughout the app.May 25 2018, 6:54 PM

cmadeo updated the task description. (Show Details)

Restricted Application edited projects, added Wikipedia-iOS-App-Backlog; removed Wikipedia-iOS-App-Backlog (Design). · View Herald TranscriptMay 25 2018, 6:54 PM

Just to clarify, this ticket is in regards to the grey section headers, not the tab/page headers.

• JMinor moved this task from Needs Triage to Product Backlog on the Wikipedia-iOS-App-Backlog board.May 29 2018, 9:03 PM

• JMinor raised the priority of this task from Low to Medium.Jun 25 2018, 6:27 PM

JoeWalsh moved this task from Needs Engineering Sync to Doing on the iOS-app-v6.0-Walrus-On-A-Unicycle board.Jun 26 2018, 2:31 PM

JoeWalsh moved this task from Doing to Needs Engineering Sync on the iOS-app-v6.0-Walrus-On-A-Unicycle board.

• JMinor lowered the priority of this task from Medium to Low.Jul 3 2018, 6:23 PM

cmadeo renamed this task from Utilize a consistent section header style throughout the app to Utilize a consistent sub-section header style throughout the app.Jul 3 2018, 6:23 PM

cmadeo raised the priority of this task from Low to Medium.

• JMinor moved this task from Needs Engineering Sync to Ready for Development on the iOS-app-v6.0-Walrus-On-A-Unicycle board.Jul 3 2018, 6:24 PM

cmadeo moved this task from Ready for Development to Needs Design on the iOS-app-v6.0-Walrus-On-A-Unicycle board.Jul 23 2018, 6:55 PM

cmadeo moved this task from Needs Design to Design Doing on the iOS-app-v6.0-Walrus-On-A-Unicycle board.Jul 23 2018, 10:52 PM

cmadeo updated the task description. (Show Details)Jul 25 2018, 11:33 PM

cmadeo edited projects, added iOS-app-v6.0.1-Walrus-On-A-Golf-Cart; removed iOS-app-v6.0-Walrus-On-A-Unicycle.Jul 26 2018, 7:02 PM

• JMinor lowered the priority of this task from Medium to Low.Aug 8 2018, 7:22 PM

LGoto moved this task from Tasks from Product Backlog to Ready for Development on the iOS-app-v6.0.1-Walrus-On-A-Golf-Cart board.Aug 8 2018, 7:22 PM

Mhurd claimed this task.Aug 10 2018, 9:18 PM

Mhurd moved this task from Ready for Development to Doing on the iOS-app-v6.0.1-Walrus-On-A-Golf-Cart board.

Mhurd updated the task description. (Show Details)Aug 10 2018, 10:51 PM

Mhurd updated the task description. (Show Details)

cmadeo renamed this task from Utilize a consistent sub-section header style throughout the app to Utilize a consistent sub-section header style on Settings and in the Article footer.Aug 10 2018, 10:58 PM

cmadeo updated the task description. (Show Details)

The pagelib part of this ticket:

https://github.com/wikimedia/wikimedia-page-library/pull/155

Mhurd moved this task from Doing to Blocked or Waiting on the iOS-app-v6.0.1-Walrus-On-A-Golf-Cart board.Aug 14 2018, 6:58 PM

Mhurd mentioned this in rAPIOSdc9dd99818af: Merge branch 'develop' into update/sub-section-consistency/T183502.Aug 16 2018, 1:22 AM

Integrating pagelib changes:
https://github.com/wikimedia/wikipedia-ios/pull/2584

Mhurd moved this task from Blocked or Waiting to Needs Code Review on the iOS-app-v6.0.1-Walrus-On-A-Golf-Cart board.Aug 16 2018, 1:27 AM

• NHarateh_WMF mentioned this in rAPIOSbeaa53de730b: Merge branch 'develop' into update/sub-section-consistency/T183502.Aug 16 2018, 11:49 AM

• NHarateh_WMF mentioned this in rAPIOS1a466abf4671: Merge pull request #2584 from wikimedia/update/sub-section-consistency/T183502.Aug 16 2018, 12:14 PM

• NHarateh_WMF moved this task from Needs Code Review to Needs Testing Criteria on the iOS-app-v6.0.1-Walrus-On-A-Golf-Cart board.Aug 16 2018, 12:17 PM

Testing criteria

load any article
scroll to bottom of article
ensure the ABOUT THIS ARTICLE and READ MORE headers look more like the after pictures on https://github.com/wikimedia/wikipedia-ios/pull/2584 than the before pictures

Mhurd moved this task from Needs Testing Criteria to Waiting for Build on the iOS-app-v6.0.1-Walrus-On-A-Golf-Cart board.Aug 21 2018, 9:24 PM

• NHarateh_WMF moved this task from Waiting for Build to Needs Design Review on the iOS-app-v6.0.1-Walrus-On-A-Golf-Cart board.Aug 22 2018, 5:28 PM

Looking good, thanks @Mhurd!

LGTM on 6.0.1 (1483)

• JMinor closed this task as Resolved.Sep 24 2018, 10:09 PM

	F24127252: 105_Feed customization_single language.png
	Jul 25 2018, 11:33 PM

Utilize a consistent sub-section header style on Settings and in the Article footerClosed, ResolvedPublicActions