Possibly permit more ext tag types in directive
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Arlolra
	Dec 21 2017, 10:57 PM

Description

From https://github.com/wikimedia/parsoid/blob/master/lib/wt2html/pegTokenizer.pegjs#L1383-L1386

which is preventing translate extension tags from rendering in html element attrributes, as on,

https://meta.wikimedia.org/api/rest_v1/page/html/Global_Collaboration%2FNewsletter%2FIssues%2F2016%2F10

@cscott warns that the nowiki rule is now also used by language variants, and to just be mindful of that.

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/services/parsoid	master	+46 -13	Permit extension tags in xmlish attribute values

Customize query in gerrit

Related Objects

Mentioned In: T181408: Rethink responsive references wrappers
T129372: gallery syntax claims to require 'px' for widths/heights attributes, but actually discards all strings after the number
Mentioned Here: rGPAR8a0ff6c19336: Fix implementation of padleft/padright.
T129372: gallery syntax claims to require 'px' for widths/heights attributes, but actually discards all strings after the number
T181408: Rethink responsive references wrappers

Event Timeline

Arlolra created this task.Dec 21 2017, 10:57 PM

Restricted Application added subscribers: jeblad, Aklapper. · View Herald TranscriptDec 21 2017, 10:57 PM

Arlolra triaged this task as High priority.Dec 21 2017, 10:57 PM

<cscott> adding a new `nowiki_or_ext: nowiki | xmlish` production for use in attributes should be fine

Change 403319 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] WIP: Permit extension tags in xmlish attribute values

https://gerrit.wikimedia.org/r/403319

gerritbot added a project: Patch-For-Review.Jan 9 2018, 11:16 PM

ssastry moved this task from Needs Triage to Read Views on the Parsoid board.Jan 11 2018, 9:14 PM

Change 403319 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Permit extension tags in xmlish attribute values

https://gerrit.wikimedia.org/r/403319

Arlolra closed this task as Resolved.Jan 18 2018, 12:31 AM

Mentioned in SAL (#wikimedia-operations) [2018-02-06T18:47:51Z] <arlolra> Updated Parsoid to 8a0ff6c (T183515, T129372, T181408)

Stashbot mentioned this in T129372: gallery syntax claims to require 'px' for widths/heights attributes, but actually discards all strings after the number.Feb 6 2018, 6:47 PM

Stashbot mentioned this in T181408: Rethink responsive references wrappers.

After a purge, https://meta.wikimedia.org/api/rest_v1/page/html/Global_Collaboration%2FNewsletter%2FIssues%2F2016%2F10 renders as desired

Possibly permit more ext tag types in directiveClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Possibly permit more ext tag types in directive
Closed, ResolvedPublic
Actions