Change 295116 had a related patch set uploaded (by Prtksxna):
Gallery: Add numHasPxUnit method

https://gerrit.wikimedia.org/r/295116

While I like the idea of supporting the other units in the future, applying this patch might break galleries that aren't using any units. I know I've seen a few, is there a way to query how many such are there?

A documentation change might be easier at this point.

This would definitely be a breaking change.

In T129372#2392043, @Prtksxna wrote:

I know I've seen a few, is there a way to query how many such are there?

It's common. [[ https://en.wikipedia.org/w/index.php?title=Special:Search&profile=default&fulltext=Search&search=insource%3A%2F%5C%3Cgallery+widths%3D%5B%22%27%5D%3F%5B0-9%5D%2B%5B%22%27+%3E%5D%2F| Searching enwiki for insource:/\<gallery widths=["']?[0-9]+["' >]/ ]] apparently gives 2,805 results (this doesn't count instances with parameters in different order, obviously, and in the past I've found results from Special:Search to be incomplete – you'd have to use a better regexp and scan the database dump to get the real numbers).

[[https://en.wikipedia.org/w/index.php?title=Special:Search&profile=default&fulltext=Search&search=insource%3A%2F%5C<gallery+widths%3D%5B"%27%5D%3F%5B0-9%5D%2Bpx%5B"%27+>%5D%2F|Same with px]] – 6,485 results.

I've also searched a few wikis for insource:/\<gallery widths=["']?[0-9]+[^0-9p"' >]/ ('widths' parameter containing a number, followed by anything that is not "p" or end of the attribute).

• Some have no results:
  • https://es.wikipedia.org/w/index.php?search=insource%3A%2F%5C<gallery+widths%3D%5B"%27%5D%3F%5B0-9%5D%2B%5B%5E0-9p"%27+>%5D%2F
  • https://zh.wikipedia.org/w/index.php?search=insource%3A%2F%5C<gallery+widths%3D%5B"%27%5D%3F%5B0-9%5D%2B%5B%5E0-9p"%27+>%5D%2F

• Some have only obvious typos (160ox, 250x):
  • https://en.wikipedia.org/w/index.php?search=insource%3A%2F%5C<gallery+widths%3D%5B"%27%5D%3F%5B0-9%5D%2B%5B%5E0-9p"%27+>%5D%2F

• People on Polish Wikipedia, however, are apparently fond of using syntax like <gallery widths=250, heights=250, perrow=3> which worked so far (accidentally) but presumably will no longer work after the patch:
  • https://pl.wikipedia.org/w/index.php?search=insource%3A%2F%5C<gallery+widths%3D%5B"%27%5D%3F%5B0-9%5D%2B%5B%5E0-9p"%27+>%5D%2F

• Some also tried using percentages, which doesn't make any sense to me (<gallery widths=300% heights=200%>):
  • https://sv.wikipedia.org/w/index.php?search=insource%3A%2F%5C<gallery+widths%3D%5B"%27%5D%3F%5B0-9%5D%2B%5B%5E0-9p"%27+>%5D%2F
  • https://fr.wikipedia.org/w/index.php?search=insource%3A%2F%5C<gallery+widths%3D%5B"%27%5D%3F%5B0-9%5D%2B%5B%5E0-9p"%27+>%5D%2F

I checked all of our wikis using a neat little script.

So I think this will have very little impact, except for pl.wp and de.wp, where we might want to ask somebody to run a bot or something. (I can do pl.wp myself.)

@matmarex, wow, thanks for the script! Do you think the same bot could be run for both pl and de?

@cscott Do you think this change makes sense?

Adding Parsing-Team--ARCHIVED since this is apparently blocked on them reviewing the patch.

Change 406248 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] Match core's parsing of gallery dimensions

https://gerrit.wikimedia.org/r/406248

Change 295116 merged by jenkins-bot:
[mediawiki/core@master] Gallery: Use Parser::parseWidthParam() for gallery dimensions

https://gerrit.wikimedia.org/r/295116

I left a note about the merged patch in User-notice https://meta.wikimedia.org/w/index.php?title=Tech%2FNews%2F2018%2F06&type=revision&diff=17679906&oldid=17679435

In T129372#2704083, @matmarex wrote:

So I think this will have very little impact, except for pl.wp and de.wp, where we might want to ask somebody to run a bot or something. (I can do pl.wp myself.)

@matmarex Still want to take that on?

In T129372#3925152, @Arlolra wrote:

In T129372#2704083, @matmarex wrote:

So I think this will have very little impact, except for pl.wp and de.wp, where we might want to ask somebody to run a bot or something. (I can do pl.wp myself.)

@matmarex Still want to take that on?

Is linting support required? May not be -- I am asking that question without context.

In T129372#3925152, @Arlolra wrote:

In T129372#2704083, @matmarex wrote:

So I think this will have very little impact, except for pl.wp and de.wp, where we might want to ask somebody to run a bot or something. (I can do pl.wp myself.)

@matmarex Still want to take that on?

Thanks for the reminder, I can do it right now actually.

I am using AutoWikiBrowser and doing the following:

• Make list using "Wiki search" with the query insource:/(widths|heights)=["']?[0-9]+[^0-9p"' >]/
• Apply "Find and replace" from (widths|heights)=(["']?[0-9]+)[^0-9p"' >] to $1=$2 (regexp) – this simply removes any unexpected characters after the number
• My edit summary is fix syntax of <gallery widths=… heights=…> ([[phab:T129372]]) (translated to Polish)

You can do the same for your favorite wiki using your favorite bot toolkit.

https://pl.wikipedia.org/w/index.php?title=Specjalna:Wkład/MatmaBot&offset=201801262100000&limit=131

In T129372#3925153, @ssastry wrote:

Is linting support required? May not be -- I am asking that question without context.

Not specifically for this case, but I think some better validation of <gallery> parameters and displaying some errors when they are invalid would be useful. For example, I found a few articles during this bot run that had 'widths' misspelled as 'widhts'. That is probably a bigger task though.

Change 406248 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Match core's parsing of gallery dimensions

https://gerrit.wikimedia.org/r/406248

Mentioned in SAL (#wikimedia-operations) [2018-02-06T18:47:51Z] <arlolra> Updated Parsoid to 8a0ff6c (T183515, T129372, T181408)