Page MenuHomePhabricator

InvalidArgumentException from line 101 RevisionStoreRecord.php: The given Title does not belong to page ID 1187
Closed, ResolvedPublic

Description

To reproduce:

  1. Create a page with 1 or 2 revisions
  2. Delete the page
  3. Create another new revision on the same page
  4. Delete the page again
  5. Try to restore all revisions

An example of this on the beta cluster is trying to undelete https://deployment.wikimedia.beta.wmflabs.org/wiki/Special:Undelete/Addwiki_PageIntegrationTest_-_1486895593.775

[Wj0qtwpEE4AAADljHewAAAAA] /w/index.php?title=Special:Undelete&action=submit InvalidArgumentException from line 101 of /srv/mediawiki/php-master/includes/Storage/RevisionStoreRecord.php: The given Title does not belong to page ID 1187

Backtrace:

#0 /srv/mediawiki/php-master/includes/Storage/RevisionStore.php(404): MediaWiki\Storage\RevisionStoreRecord->__construct(Title, MediaWiki\User\UserIdentityValue, CommentStoreComment, stdClass, MediaWiki\Storage\RevisionSlots, boolean)
#1 /srv/mediawiki/php-master/includes/Revision.php(984): MediaWiki\Storage\RevisionStore->insertRevisionOn(MediaWiki\Storage\RevisionArchiveRecord, Wikimedia\Rdbms\DatabaseMysqli)
#2 /srv/mediawiki/php-master/includes/page/PageArchive.php(690): Revision->insertOn(Wikimedia\Rdbms\DatabaseMysqli)
#3 /srv/mediawiki/php-master/includes/page/PageArchive.php(426): PageArchive->undeleteRevisions(array, boolean, string)
#4 /srv/mediawiki/php-master/includes/specials/SpecialUndelete.php(1142): PageArchive->undelete(array, string, array, boolean, User)
#5 /srv/mediawiki/php-master/includes/specials/SpecialUndelete.php(201): SpecialUndelete->undelete()
#6 /srv/mediawiki/php-master/includes/specialpage/SpecialPage.php(522): SpecialUndelete->execute(NULL)
#7 /srv/mediawiki/php-master/includes/specialpage/SpecialPageFactory.php(578): SpecialPage->run(NULL)
#8 /srv/mediawiki/php-master/includes/MediaWiki.php(287): SpecialPageFactory::executePath(Title, RequestContext)
#9 /srv/mediawiki/php-master/includes/MediaWiki.php(851): MediaWiki->performRequest()
#10 /srv/mediawiki/php-master/includes/MediaWiki.php(523): MediaWiki->main()
#11 /srv/mediawiki/php-master/index.php(43): MediaWiki->run()
#12 /srv/mediawiki/w/index.php(3): include(string)
#13 {main}

Event Timeline

Addshore created this task.Dec 22 2017, 4:05 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 22 2017, 4:05 PM
Addshore triaged this task as Unbreak Now! priority.Dec 22 2017, 4:06 PM
Restricted Application added subscribers: Liuxinyu970226, Jay8g, TerraCodes. · View Herald TranscriptDec 22 2017, 4:06 PM
Addshore moved this task from Inbox to Next on the Multi-Content-Revisions board.Dec 22 2017, 4:08 PM

Change 399838 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/core@master] [MCR] Revision::newFromArchiveRow convert overrides for rows

https://gerrit.wikimedia.org/r/399838

Change 399838 merged by jenkins-bot:
[mediawiki/core@master] [MCR] Revision::newFromArchiveRow convert overrides for rows

https://gerrit.wikimedia.org/r/399838

Addshore closed this task as Resolved.Dec 23 2017, 5:38 PM
Addshore moved this task from Active 🚁 to Closing ✔️ on the User-Addshore board.