Page MenuHomePhabricator
Create Task
Maniphest T183615

[Unit testing] Unit test addPublisher in `includes/NewsletterDb.php`
Closed, ResolvedPublic
Actions

Description

Function to test: https://github.com/wikimedia/mediawiki-extensions-Newsletter/blob/master/includes/NewsletterDb.php#L95

You can find instructions on how to test in the parent task description, or https://phabricator.wikimedia.org/T183613

Mentor: @01tonythomas, and others

Details

SubjectRepoBranchLines +/-
Unit test NewsletterDb::addPublishermediawiki/extensions/Newslettermaster+40 -5
Customize query in gerrit

Related Objects
Search...

Event Timeline

01tonythomas created this task.Dec 23 2017, 12:12 PM
Aklapper moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-in-2017 board.Dec 23 2017, 2:52 PM
gerritbot subscribed.Dec 23 2017, 11:19 PM

Change 400075 had a related patch set uploaded (by Albert221; owner: Albert221):
[mediawiki/extensions/Newsletter@master] Unit test NewsletterDb::addPublisher

https://gerrit.wikimedia.org/r/400075

gerritbot added a project: Patch-For-Review.Dec 23 2017, 11:19 PM
Albert221 claimed this task.Dec 23 2017, 11:28 PM
gerritbot added a comment.Dec 24 2017, 12:15 PM

Change 400075 merged by jenkins-bot:
[mediawiki/extensions/Newsletter@master] Unit test NewsletterDb::addPublisher

https://gerrit.wikimedia.org/r/400075

01tonythomas closed this task as Resolved.Dec 24 2017, 12:15 PM

Nice work! Thanks.

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)).Dec 24 2017, 1:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL