Page MenuHomePhabricator
Create Task
Maniphest T184705

distinct values constraint lists items several times (days: 1)
Closed, ResolvedPublic
Actions

Description

I noticed this on a random gene item: the violation message for a “unique value” constraint can list other entities with the same value several times.

Screenshot-2018-1-11 2-deoxyribose-5-phosphate aldolase BAS1754.png (506×775 px, 61 KB)

This might be specific to qualifiers/references, not sure. The linked item does contain the same qualifier, but as far as I can see only three times, not nine times.

Patch-For-Review:

Details

SubjectRepoBranchLines +/-
Add missing DISTINCT to SPARQL querymediawiki/extensions/WikibaseQualityConstraintswmf/1.31.0-wmf.17+4 -4
Add missing DISTINCT to SPARQL querymediawiki/extensions/WikibaseQualityConstraintsmaster+4 -4
Customize query in gerrit

Related Objects
Search...

Event Timeline

Lucas_Werkmeister_WMDE created this task.Jan 11 2018, 11:38 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 11 2018, 11:38 AM
Lucas_Werkmeister_WMDE added a parent task: T173695: Enable constraint checks by default for users.Jan 11 2018, 11:38 AM
thiemowmde triaged this task as Low priority.Jan 13 2018, 2:39 PM
Lydia_Pintscher moved this task from incoming to consider for next sprint on the Wikidata board.Jan 15 2018, 4:22 PM
Lucas_Werkmeister_WMDE added a project: Wikidata-Sprint-2018-01-17.Jan 16 2018, 2:41 PM
gerritbot subscribed.Jan 16 2018, 3:46 PM

Change 404477 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add missing DISTINCT to SPARQL query

https://gerrit.wikimedia.org/r/404477

gerritbot added a project: Patch-For-Review.Jan 16 2018, 3:46 PM
Lucas_Werkmeister_WMDE moved this task from Backlog to Review on the Wikidata-Sprint-2018-01-17 board.Jan 16 2018, 3:46 PM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
WMDE-leszek renamed this task from distinct values constraint lists items several times to distinct values constraint lists items several times (days: 1).Jan 17 2018, 11:13 AM
gerritbot added a comment.Jan 17 2018, 3:22 PM

Change 404477 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Add missing DISTINCT to SPARQL query

https://gerrit.wikimedia.org/r/404477

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Jan 17 2018, 3:55 PM
Lucas_Werkmeister_WMDE closed this task as Resolved.Jan 17 2018, 3:57 PM
Lucas_Werkmeister_WMDE claimed this task.
Lucas_Werkmeister_WMDE moved this task from Review to Done on the Wikidata-Sprint-2018-01-17 board.
ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)).Jan 17 2018, 4:00 PM
Lucas_Werkmeister_WMDE renamed this task from distinct values constraint lists items several times (days: 1) to distinct values constraint lists items several times.Jan 17 2018, 6:13 PM
Lucas_Werkmeister_WMDE renamed this task from distinct values constraint lists items several times to distinct values constraint lists items several times (days: 1).
Lucas_Werkmeister_WMDE set the point value for this task to 1.
Lucas_Werkmeister_WMDE removed the point value for this task.
gerritbot added a comment.Jan 22 2018, 3:53 PM

Change 405728 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@wmf/1.31.0-wmf.17] Add missing DISTINCT to SPARQL query

https://gerrit.wikimedia.org/r/405728

gerritbot added a comment.Jan 23 2018, 1:55 PM

Change 405728 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@wmf/1.31.0-wmf.17] Add missing DISTINCT to SPARQL query

https://gerrit.wikimedia.org/r/405728

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)); removed MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)).Jan 23 2018, 2:00 PM
Stashbot subscribed.Jan 23 2018, 2:13 PM

Mentioned in SAL (#wikimedia-operations) [2018-01-23T14:13:37Z] <zfilipin@tin> Synchronized php-1.31.0-wmf.17/extensions/WikibaseQualityConstraints/: SWAT: [[gerrit:405728|Add missing DISTINCT to SPARQL query (T184705)]] (duration: 01m 02s)

Lucas_Werkmeister_WMDE added a comment.Jan 23 2018, 2:15 PM

Fix backported, and I tried it out on the same gene item – now lots of different violating items are listed instead. Curiously enough, there’s still enough of them to hit the limit of 10 other entities we show… but that’s not our problem ;)

• 238482n375 removed Lucas_Werkmeister_WMDE as the assignee of this task.Jun 15 2018, 8:04 AM
• 238482n375 lowered the priority of this task from Low to Lowest.
• 238482n375 moved this task from Next Up to In Code Review on the Analytics-Kanban board.
• 238482n375 added projects: Analytics-Kanban, acl*security, Wikimedia-VE-Campaigns (S2-2018), Scap (Scap3-Adoption-Phase2), AbuseFilter, Data-release, Hashtags, LabsDB-Auditor, Ladies-That-FOSS-MediaWiki, Language-2018-Apr-June, Language-2018-Jan-Mar, HHVM, HAWelcome.
• 238482n375 edited subscribers, added: • 238482n375; removed: Aklapper.

SG9tZVBoYWJyaWNhdG9yCk5vIG1lc3NhZ2VzLiBObyBub3RpZmljYXRpb25zLgoKICAgIFNlYXJjaAoKQ3JlYXRlIFRhc2sKTWFuaXBoZXN0ClQxOTcyODEKRml4IGZhaWxpbmcgd2VicmVxdWVzdCBob3VycyAodXBsb2FkIGFuZCB0ZXh0IDIwMTgtMDYtMTQtMTEpCk9wZW4sIE5lZWRzIFRyaWFnZVB1YmxpYwoKICAgIEVkaXQgVGFzawogICAgRWRpdCBSZWxhdGVkIFRhc2tzLi4uCiAgICBFZGl0IFJlbGF0ZWQgT2JqZWN0cy4uLgogICAgUHJvdGVjdCBhcyBzZWN1cml0eSBpc3N1ZQoKICAgIE11dGUgTm90aWZpY2F0aW9ucwogICAgQXdhcmQgVG9rZW4KICAgIEZsYWcgRm9yIExhdGVyCgpUYWdzCgogICAgQW5hbHl0aWNzLUthbmJhbiAoSW4gUHJvZ3Jlc3MpCgpTdWJzY3JpYmVycwpBa2xhcHBlciwgSkFsbGVtYW5kb3UKQXNzaWduZWQgVG8KSkFsbGVtYW5kb3UKQXV0aG9yZWQgQnkKSkFsbGVtYW5kb3UsIEZyaSwgSnVuIDE1CkRlc2NyaXB0aW9uCgpPb3ppZSBqb2JzIGhhdmUgYmVlbiBmYWlsaW5nIGF0IGxlYXN0IGEgZmV3IHRpbWVzIGVhY2guIE1vcmUgaW52ZXN0aWdhdGlvbiBuZWVkZWQuCkpBbGxlbWFuZG91IGNyZWF0ZWQgdGhpcyB0YXNrLkZyaSwgSnVuIDE1LCA3OjIxIEFNCkhlcmFsZCBhZGRlZCBhIHN1YnNjcmliZXI6IEFrbGFwcGVyLiC3IFZpZXcgSGVyYWxkIFRyYW5zY3JpcHRGcmksIEp1biAxNSwgNzoyMSBBTQpKQWxsZW1hbmRvdSBjbGFpbWVkIHRoaXMgdGFzay5GcmksIEp1biAxNSwgNzoyMiBBTQpKQWxsZW1hbmRvdSB1cGRhdGVkIHRoZSB0YXNrIGRlc2NyaXB0aW9uLiAoU2hvdyBEZXRhaWxzKQpKQWxsZW1hbmRvdSBhZGRlZCBhIHByb2plY3Q6IEFuYWx5dGljcy1LYW5iYW4uCkpBbGxlbWFuZG91IG1vdmVkIHRoaXMgdGFzayBmcm9tIE5leHQgVXAgdG8gSW4gUHJvZ3Jlc3Mgb24gdGhlIEFuYWx5dGljcy1LYW5iYW4gYm9hcmQuCkNoYW5nZSBTdWJzY3JpYmVycwpDaGFuZ2UgUHJpb3JpdHkKQXNzaWduIC8gQ2xhaW0KTW92ZSBvbiBXb3JrYm9hcmQKQ2hhbmdlIFByb2plY3QgVGFncwpBbmFseXRpY3MtS2FuYmFuCtcKU2VjdXJpdHkK1wpXaWtpbWVkaWEtVkUtQ2FtcGFpZ25zIChTMi0yMDE4KQrXClNjYXAK1wpTY2FwIChTY2FwMy1BZG9wdGlvbi1QaGFzZTIpCtcKQWJ1c2VGaWx0ZXIK1wpEYXRhLXJlbGVhc2UK1wpIYXNodGFncwrXCkxhYnNEQi1BdWRpdG9yCtcKTGFkaWVzLVRoYXQtRk9TUy1NZWRpYVdpa2kK1wpMYW5ndWFnZS0yMDE4LUFwci1KdW5lCtcKTGFuZ3VhZ2UtMjAxOC1KYW4tTWFyCtcKSEhWTQrXCkhBV2VsY29tZQrXCkJvbGQKSXRhbGljcwpNb25vc3BhY2VkCkxpbmsKQnVsbGV0ZWQgTGlzdApOdW1iZXJlZCBMaXN0CkNvZGUgQmxvY2sKUXVvdGUKVGFibGUKVXBsb2FkIEZpbGUKTWVtZQpQcmV2aWV3CkhlbHAKRnVsbHNjcmVlbiBNb2RlClBpbiBGb3JtIE9uIFNjcmVlbgoyMzg0ODJuMzc1IGFkZGVkIHByb2plY3RzOiBTZWN1cml0eSwgV2lraW1lZGlhLVZFLUNhbXBhaWducyAoUzItMjAxOCksIFNjYXAgKFNjYXAzLUFkb3B0aW9uLVBoYXNlMiksIEFidXNlRmlsdGVyLCBEYXRhLXJlbGVhc2UsIEhhc2h0YWdzLCBMYWJzREItQXVkaXRvciwgTGFkaWVzLVRoYXQtRk9TUy1NZWRpYVdpa2ksIExhbmd1YWdlLTIwMTgtQXByLUp1bmUsIExhbmd1YWdlLTIwMTgtSmFuLU1hciwgSEhWTSwgSEFXZWxjb21lLlBSRVZJRVcKMjM4NDgybjM3NSBtb3ZlZCB0aGlzIHRhc2sgZnJvbSBJbiBQcm9ncmVzcyB0byBJbiBDb2RlIFJldmlldyBvbiB0aGUgQW5hbHl0aWNzLUthbmJhbiBib2FyZC4KMjM4NDgybjM3NSByZW1vdmVkIEpBbGxlbWFuZG91IGFzIHRoZSBhc3NpZ25lZSBvZiB0aGlzIHRhc2suCjIzODQ4Mm4zNzUgdHJpYWdlZCB0aGlzIHRhc2sgYXMgTG93ZXN0IHByaW9yaXR5LgoyMzg0ODJuMzc1IHJlbW92ZWQgc3Vic2NyaWJlcnM6IEFrbGFwcGVyLCBKQWxsZW1hbmRvdS4KQ29udGVudCBsaWNlbnNlZCB1bmRlciBDcmVhdGl2ZSBDb21tb25zIEF0dHJpYnV0aW9uLVNoYXJlQWxpa2UgMy4wIChDQy1CWS1TQSkgdW5sZXNzIG90aGVyd2lzZSBub3RlZDsgY29kZSBsaWNlbnNlZCB1bmRlciBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSAoR1BMKSBvciBvdGhlciBvcGVuIHNvdXJjZSBsaWNlbnNlcy4gQnkgdXNpbmcgdGhpcyBzaXRlLCB5b3UgYWdyZWUgdG8gdGhlIFRlcm1zIG9mIFVzZSwgUHJpdmFjeSBQb2xpY3ksIGFuZCBDb2RlIG9mIENvbmR1Y3QuILcgV2lraW1lZGlhIEZvdW5kYXRpb24gtyBQcml2YWN5IFBvbGljeSC3IENvZGUgb2YgQ29uZHVjdCC3IFRlcm1zIG9mIFVzZSC3IERpc2NsYWltZXIgtyBDQy1CWS1TQSC3IEdQTApZb3VyIGJyb3dzZXIgdGltZXpvbmUgc2V0dGluZyBkaWZmZXJzIGZyb20gdGhlIHRpbWV6b25lIHNldHRpbmcgaW4geW91ciBwcm9maWxlLCBjbGljayB0byByZWNvbmNpbGUu

Lucas_Werkmeister_WMDE claimed this task.Jun 15 2018, 10:11 AM
Lucas_Werkmeister_WMDE raised the priority of this task from Lowest to Low.
Lucas_Werkmeister_WMDE removed projects: HAWelcome, HHVM, Language-2018-Jan-Mar, Language-2018-Apr-June, Ladies-That-FOSS-MediaWiki, LabsDB-Auditor, Hashtags, Data-release, AbuseFilter, Scap (Scap3-Adoption-Phase2), Wikimedia-VE-Campaigns (S2-2018), acl*security, Analytics-Kanban.
Lucas_Werkmeister_WMDE edited subscribers, added: Aklapper; removed: • 238482n375.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL