Page MenuHomePhabricator

Add uselang parameter to live preview diff requests
Closed, ResolvedPublic

Description

Currently only previews use the uselang parameter, diffs don’t. While the correct language is less important for diffs, line numbers, for example, are localized and should appear in the current page language. (This may be true for useskin as well; I’m not familiar with the inner structure of the diff generator.)

Details

Related Gerrit Patches:

Event Timeline

Tacsipacsi triaged this task as Medium priority.Jan 25 2018, 10:41 AM
Tacsipacsi created this task.
Aklapper raised the priority of this task from Medium to Needs Triage.Jan 25 2018, 3:32 PM
Aklapper removed a project: Tracking-Neverending.

Change 406183 had a related patch set uploaded (by Fomafix; owner: Fomafix):
[mediawiki/core@master] LivePreview: Add uselang parameter to API diff request

https://gerrit.wikimedia.org/r/406183

Fomafix claimed this task.Jan 25 2018, 6:34 PM

Change 406183 merged by jenkins-bot:
[mediawiki/core@master] LivePreview: Add uselang parameter to API diff request

https://gerrit.wikimedia.org/r/406183

Fomafix closed this task as Resolved.Jan 25 2018, 8:07 PM
Fomafix removed a project: Patch-For-Review.

The parameter uselang is added. When the diff output also depends on the skin the parameter useskin can added to.