Page MenuHomePhabricator

Make Constraint serializable
Closed, ResolvedPublic

Description

For T185709: Cache CheckResult serializations per-entity in ObjectCache, we need to be able to serialize and deserialize Constraint objects. Shouldn’t be difficult, they’re pure value objects (constraint ID, property ID, constraint type ID, parameters).

The only question is whether to serialize the parameters or not. They’re large and we won’t use them at all, so I definitely don’t want them in the cache. Should it be configurable whether they’re serialized or not, or do we just never serialize them?

Event Timeline

Lucas_Werkmeister_WMDE triaged this task as Normal priority.Jan 25 2018, 6:51 PM
Lucas_Werkmeister_WMDE created this task.

Change 412741 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Make Constraint serializable

https://gerrit.wikimedia.org/r/412741

Change 412741 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Make Constraint serializable

https://gerrit.wikimedia.org/r/412741

Lucas_Werkmeister_WMDE closed this task as Resolved.Feb 20 2018, 12:56 PM
Lucas_Werkmeister_WMDE moved this task from Review to Done on the Wikidata-Sprint-2018-02-14 board.