Page MenuHomePhabricator
Create Task
Maniphest T103228

Improve performance of constraint check
Open, MediumPublic
Actions

Description

When there are many statements with many constraints on an item, it may takes a time to perform the constraint check. Probably, there are a lot of things to do to improve the performance.

(Under this tasks, one could collect all concrete ideas to tackle this problem.)

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedLucas_Werkmeister_WMDET173695 Enable constraint checks by default for users
 OpenNoneT103228 Improve performance of constraint check
 ResolvedLucas_Werkmeister_WMDET89349 [Task] Only query constraints table once per property
 InvalidNoneT103114 [Task] Reduce class hierarchy for Type and Value Type
 OpenNoneT163683 Only check per-item constraints once, instead of with each statement
 ResolvedLydia_PintscherT179839 Cache constraint check results
 ResolvedLucas_Werkmeister_WMDET173696 Cache format constraint check results
 ResolvedLucas_Werkmeister_WMDET179844 Indicate that constraint check results are potentially stale
 ResolvedLydia_PintscherT179849 Cache all constraint check results per-entity
 ResolvedLucas_Werkmeister_WMDET181060 Cache constraint check results per-entity in ObjectCache (L) (days: 2)
 ResolvedLucas_Werkmeister_WMDET181080 Add cacheable layer between CheckConstraints and DelegatingConstraintChecker
 ResolvedLucas_Werkmeister_WMDET182104 Track entities to consider when checking whether cached constraint check result is valid
 ResolvedLucas_Werkmeister_WMDET182105 Store constraint check results and tracked entities in object cache
 ResolvedLucas_Werkmeister_WMDET182106 Read constraint check results from cache and check freshness
 ResolvedLucas_Werkmeister_WMDET182107 Remove cached constraint check results on purge
 ResolvedLucas_Werkmeister_WMDET182992 Update 'cached' information when getting constraint check results from cache
 ResolvedLucas_Werkmeister_WMDET182994 Get entity revision IDs in bulk
 ResolvedLucas_Werkmeister_WMDET184062 Add tracking for constraint check result cache hits and misses
 ResolvedLucas_Werkmeister_WMDET184812 Enable constraint result caching on Wikidata
 ResolvedNoneT183927 Add parameter to only get violations from wbcheckconstraints (days: 1)
 ResolvedLucas_Werkmeister_WMDET184937 Change wbcheckconstraints’ status parameter’s default value to cacheable value
 InvalidNoneT185104 status parameter removes too many results
 ResolvedLucas_Werkmeister_WMDET185688 Constraint check results are cached independent of language
 ResolvedLucas_Werkmeister_WMDET185689 Add language to cache key for check results
 ResolvedLucas_Werkmeister_WMDET185709 Cache CheckResult serializations per-entity in ObjectCache
 ResolvedLucas_Werkmeister_WMDET185710 Introduce class for constraint violation messages
 ResolvedLucas_Werkmeister_WMDET185999 Make ViolationMessage serializable
 ResolvedLucas_Werkmeister_WMDET187186 Use ViolationMessage in ConstraintParameterException
 ResolvedLucas_Werkmeister_WMDET187199 Remove support for plain string messages from ViolationMessageRenderer
 ResolvedLucas_Werkmeister_WMDET187201 Remove message argument related parts of ConstraintParameterRenderer
 ResolvedLucas_Werkmeister_WMDET187202 Remove injected ConstraintParameterRenderer from checkers and helpers
 ResolvedLucas_Werkmeister_WMDET185711 Make Constraint serializable
 ResolvedLucas_Werkmeister_WMDET185712 Make Context serializable
 DeclinedNoneT185713 Make CheckResult status serializable
 ResolvedLucas_Werkmeister_WMDET185714 Make CheckResult serializable
 ResolvedLucas_Werkmeister_WMDET188629 Completely remove support for detail and detailHTML in wbcheckconstraints response
 ResolvedLucas_Werkmeister_WMDET189875 Migrate “exception” check results to ViolationMessage
 ResolvedLucas_Werkmeister_WMDET189593 Replace CachingResultsBuilder with CachingResultsSource, (de)serializing CheckResults
 OpenNoneT190672 Cache check results from Special:ConstraintReport checks
 ResolvedLucas_Werkmeister_WMDET190684 Serialize NullResults in CachingResultsSource
 ResolvedLucas_Werkmeister_WMDET187057 Constraint check results involving the current time are cached indiscriminately [M]
 ResolvedLucas_Werkmeister_WMDET187058 Introduce separate messages for range violations involving current time
 ResolvedLucas_Werkmeister_WMDET186008 Remove range in numerical notation from violation messages
 ResolvedLucas_Werkmeister_WMDET187061 Don’t cache constraint check results involving current time whose validity will change soon
 ResolvedLucas_Werkmeister_WMDET188311 Don’t pass empty entity ID lists to WikiPageMetaDataAccessor
 ResolvedLucas_Werkmeister_WMDET188312 Don’t pass overly long entity ID lists to WikiPageEntityDataAccessor
 ResolvedLucas_Werkmeister_WMDET188418 Deduplicate entity ID lists in DependencyMetadata
 Resolved• jcrespoT188505 Investigate why query killer didn't kill 1-hour long queries
 OpenNoneT180798 Only check reference constraints once
 OpenNoneT180802 Add Context implementation containing multiple contexts
 OpenNoneT180799 Only parse constraint exceptions once per constraint
 DeclinedNoneT180796 Add ConstraintCheckPlan class
 OpenNoneT180801 Only parse constraint parameters once per constraint

Event Timeline

Jonaskeutel created this task.Jun 20 2015, 8:21 AM
Jonaskeutel raised the priority of this task from to Medium.
Jonaskeutel updated the task description. (Show Details)
Jonaskeutel added a project: Wikibase-Quality-Constraints.
Jonaskeutel subscribed.
Restricted Application added a project: Wikidata. · View Herald TranscriptJun 20 2015, 8:21 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Jonaskeutel added subtasks: T89349: [Task] Only query constraints table once per property, T103114: [Task] Reduce class hierarchy for Type and Value Type.Jun 20 2015, 8:38 AM
Lydia_Pintscher moved this task from incoming to monitoring on the Wikidata board.Jun 24 2015, 10:37 AM
Lydia_Pintscher added a project: Wikibase-Quality.Nov 22 2015, 8:48 PM
Lydia_Pintscher set Security to None.
Lydia_Pintscher closed subtask T103114: [Task] Reduce class hierarchy for Type and Value Type as Invalid.Apr 23 2017, 4:28 PM
Lucas_Werkmeister_WMDE closed subtask T89349: [Task] Only query constraints table once per property as Resolved.Apr 24 2017, 3:09 PM
Liuxinyu970226 subscribed.Apr 24 2017, 3:13 PM
Lucas_Werkmeister_WMDE added a subtask: T163683: Only check per-item constraints once, instead of with each statement.Apr 24 2017, 3:52 PM
Lucas_Werkmeister_WMDE added a parent task: T173695: Enable constraint checks by default for users.Aug 21 2017, 10:23 AM
Lucas_Werkmeister_WMDE added a subtask: T173696: Cache format constraint check results.
WMDE-leszek closed subtask T173696: Cache format constraint check results as Resolved.Oct 17 2017, 9:21 AM
Lucas_Werkmeister_WMDE reopened subtask T173696: Cache format constraint check results as Open.Oct 17 2017, 3:45 PM
Lucas_Werkmeister_WMDE created subtask T179839: Cache constraint check results.Nov 6 2017, 5:30 PM
Lucas_Werkmeister_WMDE removed a subtask: T173696: Cache format constraint check results.Nov 6 2017, 5:33 PM
Lucas_Werkmeister_WMDE mentioned this in T180796: Add ConstraintCheckPlan class.Nov 17 2017, 3:42 PM
Lucas_Werkmeister_WMDE created subtask T180798: Only check reference constraints once.Nov 17 2017, 3:45 PM
Lucas_Werkmeister_WMDE created subtask T180799: Only parse constraint exceptions once per constraint.Nov 17 2017, 3:53 PM
Lucas_Werkmeister_WMDE created subtask T180801: Only parse constraint parameters once per constraint.Nov 17 2017, 4:02 PM
Lydia_Pintscher closed subtask T179839: Cache constraint check results as Resolved.Apr 6 2018, 3:10 PM
Lydia_Pintscher moved this task from incoming to other on the Wikibase-Quality-Constraints board.Apr 6 2018, 4:21 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits