Page MenuHomePhabricator

Remove support for plain string messages from ViolationMessageRenderer
Closed, ResolvedPublic

Description

Supporting plain string arguments (pre-rendered messages) in ViolationMessageRenderer::render was just a temporary measure. Get rid of it as soon as we’re using ViolationMessages everywhere.

Details

Related Gerrit Patches:
mediawiki/extensions/WikibaseQualityConstraints : masterRemove support for plain string violation messages
mediawiki/extensions/WikibaseQualityConstraints : masterUse ViolationMessage instead of strings in tests
mediawiki/extensions/WikibaseQualityConstraints : masterRemove support for plain message CPEs from SparqlHelper

Event Timeline

WMDE-leszek triaged this task as Normal priority.Feb 13 2018, 2:30 PM
WMDE-leszek created this task.

Change 421936 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Remove support for plain message CPEs from SparqlHelper

https://gerrit.wikimedia.org/r/421936

Change 421937 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Use ViolationMessage instead of strings in tests

https://gerrit.wikimedia.org/r/421937

Change 421938 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Remove support for plain string violation messages

https://gerrit.wikimedia.org/r/421938

Change 421936 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Remove support for plain message CPEs from SparqlHelper

https://gerrit.wikimedia.org/r/421936

Change 421937 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Use ViolationMessage instead of strings in tests

https://gerrit.wikimedia.org/r/421937

Change 421938 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Remove support for plain string violation messages

https://gerrit.wikimedia.org/r/421938

Lucas_Werkmeister_WMDE closed this task as Resolved.Apr 12 2018, 5:33 PM
Lucas_Werkmeister_WMDE claimed this task.