Page MenuHomePhabricator
Create Task
Maniphest T187199

Remove support for plain string messages from ViolationMessageRenderer
Closed, ResolvedPublic
Actions

Description

Supporting plain string arguments (pre-rendered messages) in ViolationMessageRenderer::render was just a temporary measure. Get rid of it as soon as we’re using ViolationMessages everywhere.

Details

SubjectRepoBranchLines +/-
Remove support for plain string violation messagesmediawiki/extensions/WikibaseQualityConstraintsmaster+26 -105
Use ViolationMessage instead of strings in testsmediawiki/extensions/WikibaseQualityConstraintsmaster+33 -15
Remove support for plain message CPEs from SparqlHelpermediawiki/extensions/WikibaseQualityConstraintsmaster+9 -123
Customize query in gerrit

Related Objects
Search...

Event Timeline

WMDE-leszek triaged this task as Medium priority.Feb 13 2018, 2:30 PM
WMDE-leszek created this task.
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Feb 13 2018, 2:33 PM
gerritbot subscribed.Mar 26 2018, 4:16 PM

Change 421936 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Remove support for plain message CPEs from SparqlHelper

https://gerrit.wikimedia.org/r/421936

gerritbot added a project: Patch-For-Review.Mar 26 2018, 4:16 PM

Change 421937 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Use ViolationMessage instead of strings in tests

https://gerrit.wikimedia.org/r/421937

Lucas_Werkmeister_WMDE claimed this task.Mar 26 2018, 4:16 PM
gerritbot added a comment.Mar 26 2018, 4:16 PM

Change 421938 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Remove support for plain string violation messages

https://gerrit.wikimedia.org/r/421938

Lydia_Pintscher moved this task from incoming to Features/bugs for next release on the Wikibase-Quality-Constraints board.Apr 6 2018, 2:39 PM
gerritbot added a comment.Apr 12 2018, 5:00 PM

Change 421936 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Remove support for plain message CPEs from SparqlHelper

https://gerrit.wikimedia.org/r/421936

gerritbot added a comment.Apr 12 2018, 5:00 PM

Change 421937 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Use ViolationMessage instead of strings in tests

https://gerrit.wikimedia.org/r/421937

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)).Apr 12 2018, 5:00 PM
gerritbot added a comment.Apr 12 2018, 5:27 PM

Change 421938 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Remove support for plain string violation messages

https://gerrit.wikimedia.org/r/421938

Lucas_Werkmeister_WMDE closed this task as Resolved.Apr 12 2018, 5:33 PM
Lucas_Werkmeister_WMDE claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits