DelegatingConstraintChecker creates check results for the “exception” status with wfMessage( 'wbqc-exception-message' )->escaped() as the message. This needs to be migrated to use ViolationMessage instead – I’m just not sure what the best option is: we can either rename the message so that it starts with the wbqc-violation-message- prefix which ViolationMessage expects (which to me would make sense anyways), or we can special-case this in ViolationMessage, ViolationMessageSerializer and ViolationMessageDeserializer. How much effort is it to rename a message?
|Resolved||Lucas_Werkmeister_WMDE||T173695 Enable constraint checks by default for users|
|Open||None||T103228 Improve performance of constraint check|
|Resolved||Lydia_Pintscher||T179839 Cache constraint check results|
|Resolved||Lydia_Pintscher||T179849 Cache all constraint check results per-entity|
|Resolved||Lucas_Werkmeister_WMDE||T181060 Cache constraint check results per-entity in ObjectCache (L) (days: 2)|
|Resolved||Lucas_Werkmeister_WMDE||T184812 Enable constraint result caching on Wikidata|
|Resolved||Lucas_Werkmeister_WMDE||T185688 Constraint check results are cached independent of language|
|Resolved||Lucas_Werkmeister_WMDE||T185709 Cache CheckResult serializations per-entity in ObjectCache|
|Resolved||Lucas_Werkmeister_WMDE||T185714 Make CheckResult serializable|
|Resolved||Lucas_Werkmeister_WMDE||T189875 Migrate “exception” check results to ViolationMessage|
How much effort is it to rename a message?
translatewiki:FAQ#Is it possible to rename message keys? says I should just do the rename and not worry about anything else… which sounds almost too good to be true ;) but I guess I’ll upload a patch and see what reviewers say.