Migrate “exception” check results to ViolationMessage
Closed, ResolvedPublic
Actions

Description

DelegatingConstraintChecker creates check results for the “exception” status with wfMessage( 'wbqc-exception-message' )->escaped() as the message. This needs to be migrated to use ViolationMessage instead – I’m just not sure what the best option is: we can either rename the message so that it starts with the wbqc-violation-message- prefix which ViolationMessage expects (which to me would make sense anyways), or we can special-case this in ViolationMessage, ViolationMessageSerializer and ViolationMessageDeserializer. How much effort is it to rename a message?

Details

	Subject	Repo	Branch	Lines +/-
	Use ViolationMessage for constraint exceptions	mediawiki/extensions/WikibaseQualityConstraints	master	+15 -15

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Lucas_Werkmeister_WMDE	T173695 Enable constraint checks by default for users
Open	None	T103228 Improve performance of constraint check
Resolved	Lydia_Pintscher	T179839 Cache constraint check results
Resolved	Lydia_Pintscher	T179849 Cache all constraint check results per-entity
Resolved	Lucas_Werkmeister_WMDE	T181060 Cache constraint check results per-entity in ObjectCache (L) (days: 2)
Resolved	Lucas_Werkmeister_WMDE	T184812 Enable constraint result caching on Wikidata
Resolved	Lucas_Werkmeister_WMDE	T185688 Constraint check results are cached independent of language
Resolved	Lucas_Werkmeister_WMDE	T185709 Cache CheckResult serializations per-entity in ObjectCache
Resolved	Lucas_Werkmeister_WMDE	T185714 Make CheckResult serializable
Resolved	Lucas_Werkmeister_WMDE	T189875 Migrate “exception” check results to ViolationMessage

Event Timeline

Lucas_Werkmeister_WMDE triaged this task as Medium priority.Mar 16 2018, 2:44 PM

Lucas_Werkmeister_WMDE created this task.

Lucas_Werkmeister_WMDE mentioned this in T185714: Make CheckResult serializable.

Lydia_Pintscher moved this task from incoming to in progress on the Wikidata board.Mar 17 2018, 5:37 PM

How much effort is it to rename a message?

translatewiki:FAQ#Is it possible to rename message keys? says I should just do the rename and not worry about anything else… which sounds almost too good to be true ;) but I guess I’ll upload a patch and see what reviewers say.

Change 420356 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Use ViolationMessage for constraint exceptions

https://gerrit.wikimedia.org/r/420356

gerritbot added a project: Patch-For-Review.Mar 19 2018, 2:55 PM

Lucas_Werkmeister_WMDE moved this task from In Progress to Needs Review on the Wikidata-Ministry-Of-Magic board.Mar 19 2018, 2:55 PM

• Jonas moved this task from Needs Review to Blocked on the Wikidata-Ministry-Of-Magic board.Mar 21 2018, 11:13 AM

Change 420356 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Use ViolationMessage for constraint exceptions

https://gerrit.wikimedia.org/r/420356