Page MenuHomePhabricator

Migrate “exception” check results to ViolationMessage
Closed, ResolvedPublic

Description

DelegatingConstraintChecker creates check results for the “exception” status with wfMessage( 'wbqc-exception-message' )->escaped() as the message. This needs to be migrated to use ViolationMessage instead – I’m just not sure what the best option is: we can either rename the message so that it starts with the wbqc-violation-message- prefix which ViolationMessage expects (which to me would make sense anyways), or we can special-case this in ViolationMessage, ViolationMessageSerializer and ViolationMessageDeserializer. How much effort is it to rename a message?

Event Timeline

How much effort is it to rename a message?

translatewiki:FAQ#Is it possible to rename message keys? says I should just do the rename and not worry about anything else… which sounds almost too good to be true ;) but I guess I’ll upload a patch and see what reviewers say.

Change 420356 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Use ViolationMessage for constraint exceptions

https://gerrit.wikimedia.org/r/420356

Change 420356 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Use ViolationMessage for constraint exceptions

https://gerrit.wikimedia.org/r/420356

@Jonas why is this in the “blocked” column?

Lucas_Werkmeister_WMDE closed this task as Resolved.Mar 26 2018, 12:55 PM

I guess we’re done here.