Description

If the list of depended entity IDs in CachingResultBuilder is empty for some reason, something must be wrong – at least the entity itself should always be in that set. In any event, there’s no point asking the WikiPageMetaDataAccessor for revision IDs in that case, at the risk of it issuing some empty query. Just short-circuit in getLatestRevisionIds instead.

Part of https://wikitech.wikimedia.org/wiki/Incident_documentation/20180226-WikibaseQualityConstraints.

Details

Subject	Repo	Branch	Lines +/-
Don’t query WikiPageEntityMetaDataAccessor with empty list	mediawiki/extensions/WikibaseQualityConstraints	wmf/1.31.0-wmf.23	+4 -0
Don’t query WikiPageEntityMetaDataAccessor with empty list	mediawiki/extensions/WikibaseQualityConstraints	wmf/1.31.0-wmf.22	+4 -0
Don’t query WikiPageEntityMetaDataAccessor with empty list	mediawiki/extensions/WikibaseQualityConstraints	master	+4 -0

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Lucas_Werkmeister_WMDE	T173695 Enable constraint checks by default for users
Open	None	T103228 Improve performance of constraint check
Resolved	Lydia_Pintscher	T179839 Cache constraint check results
Resolved	Lydia_Pintscher	T179849 Cache all constraint check results per-entity
Resolved	Lucas_Werkmeister_WMDE	T181060 Cache constraint check results per-entity in ObjectCache (L) (days: 2)
Resolved	Lucas_Werkmeister_WMDE	T184812 Enable constraint result caching on Wikidata
Resolved	Lucas_Werkmeister_WMDE	T188311 Don’t pass empty entity ID lists to WikiPageMetaDataAccessor

Event Timeline

Lucas_Werkmeister_WMDE triaged this task as High priority.Feb 26 2018, 8:27 PM

Lucas_Werkmeister_WMDE created this task.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 26 2018, 8:27 PM

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Feb 26 2018, 10:53 PM

Lucas_Werkmeister_WMDE moved this task from Active investigation to Follow-up prevention on the Wikimedia-Incident board.Feb 27 2018, 10:19 AM

Lucas_Werkmeister_WMDE added a project: Wikidata-Sprint-2018-02-28.Feb 27 2018, 1:30 PM

Lydia_Pintscher moved this task from incoming to in progress on the Wikidata board.Feb 27 2018, 1:36 PM

Change 415025 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Don’t query WikiPageEntityMetaDataAccessor with empty list

https://gerrit.wikimedia.org/r/415025

gerritbot added a project: Patch-For-Review.Feb 27 2018, 3:40 PM

Lucas_Werkmeister_WMDE added a project: Wikidata-Sprint-2018-02-14.Feb 27 2018, 3:40 PM

Lucas_Werkmeister_WMDE moved this task from Backlog to Review on the Wikidata-Sprint-2018-02-14 board.

Lucas_Werkmeister_WMDE moved this task from Backlog to Review on the Wikidata-Sprint-2018-02-28 board.Feb 28 2018, 9:52 AM

• Jonas moved this task from Review to Done on the Wikidata-Sprint-2018-02-28 board.Feb 28 2018, 11:08 AM

Change 415025 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Don’t query WikiPageEntityMetaDataAccessor with empty list

https://gerrit.wikimedia.org/r/415025

Lucas_Werkmeister_WMDE closed this task as Resolved.Feb 28 2018, 1:03 PM

Change 415287 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@wmf/1.31.0-wmf.22] Don’t query WikiPageEntityMetaDataAccessor with empty list

https://gerrit.wikimedia.org/r/415287

Change 415288 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@wmf/1.31.0-wmf.23] Don’t query WikiPageEntityMetaDataAccessor with empty list

https://gerrit.wikimedia.org/r/415288

Change 415287 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@wmf/1.31.0-wmf.22] Don’t query WikiPageEntityMetaDataAccessor with empty list

https://gerrit.wikimedia.org/r/415287

Mentioned in SAL (#wikimedia-operations) [2018-02-28T14:48:35Z] <zfilipin@tin> Synchronized php-1.31.0-wmf.22/extensions/WikibaseQualityConstraints: SWAT: [[gerrit:415287|Don’t query WikiPageEntityMetaDataAccessor with empty list (T188311)]] (duration: 01m 02s)

Change 415288 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@wmf/1.31.0-wmf.23] Don’t query WikiPageEntityMetaDataAccessor with empty list

https://gerrit.wikimedia.org/r/415288

Mentioned in SAL (#wikimedia-operations) [2018-02-28T15:15:55Z] <zfilipin@tin> Synchronized php-1.31.0-wmf.23/extensions/WikibaseQualityConstraints/: SWAT: [[gerrit:415288|Don’t query WikiPageEntityMetaDataAccessor with empty list (T188311)]] [[gerrit:415290|Bump cache key for check results (T188384)]] (duration: 01m 02s)