Page MenuHomePhabricator

Remove injected ConstraintParameterRenderer from checkers and helpers
Closed, ResolvedPublic


When all the checkers and helpers produce ViolationMessages, they should no longer need a ConstraintParameterRenderer, so we should be able to remove it from them again.

Note: With this done, we’ll have essentially completed a migration from ConstraintParameterRenderer to ViolationMessageRenderer. A git diff --stat 407387c src/ might be interesting :) (minus however many lines the serializer and deserializer take up)

Event Timeline

Lucas_Werkmeister_WMDE triaged this task as Medium priority.Feb 13 2018, 2:44 PM
Lucas_Werkmeister_WMDE created this task.

Change 432094 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Remove ConstraintParameterRenderer where unnecessary

Change 432094 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Remove ConstraintParameterRenderer where unnecessary

Lucas_Werkmeister_WMDE closed this task as Resolved.May 15 2018, 2:23 PM
Lucas_Werkmeister_WMDE claimed this task.