Page MenuHomePhabricator

Use $logger as protected class variable
Closed, ResolvedPublic

Description

In core, a common practice is to declare a protected variable $logger in classes that make use multiple log statements.

        /** @var LoggerInterface */
	protected $logger;
...
      	$logger = LoggerFactory::getInstance( 'Math' );

See https://www.mediawiki.org/wiki/Manual:Structured_logging on how to use logging.

Event Timeline

Are you asking for this to be applied to all extensions or just the Math extension?

Physikerwelt triaged this task as Low priority.

Change 551495 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/Math@master] Declare $logger as a protected class variable

https://gerrit.wikimedia.org/r/551495

Change 551495 merged by jenkins-bot:
[mediawiki/extensions/Math@master] Declare $logger as a protected class variable

https://gerrit.wikimedia.org/r/551495