LoginManager.botAllowed compares Page object with string
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Xqt
	Feb 3 2018, 1:19 PM

Description

compairing template from templatesWithParams() with botTemplate work incorrect because template is a Page object whereas botTemplate is a string. This is a result of incompatible templatesWithParams() method between compat and core.

Details

	Subject	Repo	Branch	Lines +/-
	[bugfix] Fix using templatesWithParams results	pywikibot/core	master	+9 -9

Customize query in gerrit

Related Objects

Mentioned Here: T186459: imagecopy_self.imageFetcher.getNewFieldsFromInformation getNewFieldsFromInformation
T186394: solve_disambiguation uses slice operator for PageGenerator

Event Timeline

Xqt created this task.Feb 3 2018, 1:19 PM

Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptFeb 3 2018, 1:19 PM

Xqt triaged this task as High priority.Feb 3 2018, 1:20 PM

Change 407917 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [bugfix] Fix using templatesWithParams results

https://gerrit.wikimedia.org/r/407917

gerritbot added a project: Patch-For-Review.Feb 3 2018, 1:35 PM

Xqt added subscribers: Dalba, Lokal_Profil, valhallasw.Feb 3 2018, 1:37 PM

Possible similar issue in imagecopy_self.py and solve_disambiguation.py.

Change 407917 merged by jenkins-bot:
[pywikibot/core@master] [bugfix] Fix using templatesWithParams results

https://gerrit.wikimedia.org/r/407917

Xqt closed this task as Resolved.Feb 4 2018, 3:58 PM

In T186412#3944428, @Dalba wrote:

Possible similar issue in imagecopy_self.py and solve_disambiguation.py.

solve_disambiguation.py issue is T186394 the other is T186459

LoginManager.botAllowed compares Page object with stringClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

LoginManager.botAllowed compares Page object with string
Closed, ResolvedPublic
Actions