solve_disambiguation uses slice operator for PageGenerator
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Xqt
	Feb 3 2018, 8:40 AM

Description

In line 1021 we have this statement:

links = disambPage.linkedPages()[:1]

linkedPages() is a PageGenerator and doesn't have a __getitem__ attribute.

This is a difference to old compat where linkedPages is a list, not a generator.
There is another issue that tempatesWithParams gives a Page object in first tuple item but not a string

I am not sure whether this bug resides on other scripts, too.

Details

	Subject	Repo	Branch	Lines +/-
	[bugfix] Page.linkedPages() is a PageGenerator not a list	pywikibot/core	master	+55 -48
	[compat2core] Fix regressions of multiple Page methods	pywikibot/core	master	+29 -14

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T151110 RFC: Regressions of core should be rethought or solved
Resolved	Dvorapa	T186394 solve_disambiguation uses slice operator for PageGenerator
Open	None	T118719 solve_disambiguation.py gives possibilities from {{disambiguation}}
Resolved	Xqt	T106763 Mandatory dependency on mwparserfromhell
Resolved	Ladsgroup	T88069 Add pure python mwparserfromhell to nightlies
Resolved	Xqt	T186316 solve_disambiguation_tests are failing with AssertionError: source parameter should be either a Site or Page object

Event Timeline

Xqt created this task.Feb 3 2018, 8:40 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 3 2018, 8:40 AM

Xqt updated the task description. (Show Details)Feb 3 2018, 8:40 AM

Xqt added projects: Pywikibot, Pywikibot-compat-to-core.Feb 3 2018, 8:44 AM

Xqt updated the task description. (Show Details)

Xqt added a subscriber: Dvorapa.

Restricted Application added a subscriber: pywikibot-bugs-list. · View Herald TranscriptFeb 3 2018, 8:44 AM

Xqt triaged this task as High priority.Feb 3 2018, 8:44 AM

Xqt renamed this task from solve_disambiguation uses sloce operator for PageGenerator to solve_disambiguation uses slice operator for PageGenerator.Feb 3 2018, 8:47 AM

Xqt added a subtask: T118719: solve_disambiguation.py gives possibilities from {{disambiguation}}.Feb 3 2018, 8:51 AM

Sure this is not a regression against compat but a difference which should be noted at compat2core.py and mayby other instructions too.

Xqt claimed this task.Feb 3 2018, 9:36 AM

Change 407892 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [bugfix] Page.linkedPages() is a PageGenerator not a list

https://gerrit.wikimedia.org/r/407892

gerritbot added a project: Patch-For-Review.Feb 3 2018, 10:02 AM

matej_suchanek updated the task description. (Show Details)Feb 3 2018, 2:00 PM

Dvorapa added a project: Pywikibot-solve-disambiguation.py.Feb 4 2018, 10:55 AM

Xqt mentioned this in T186412: LoginManager.botAllowed compares Page object with string.Feb 4 2018, 4:07 PM

Xqt updated the task description. (Show Details)Feb 4 2018, 4:54 PM

Dvorapa changed the status of subtask T118719: solve_disambiguation.py gives possibilities from {{disambiguation}} from Open to Stalled.May 22 2018, 5:46 PM

Dvorapa changed the status of subtask T118719: solve_disambiguation.py gives possibilities from {{disambiguation}} from Stalled to Open.Sep 29 2018, 11:41 PM

Change 463660 had a related patch set uploaded (by Dvorapa; owner: Dvorapa):
[pywikibot/core@master] [compat2core] Fix regressions of multiple Page methods

https://gerrit.wikimedia.org/r/463660

Change 463660 merged by jenkins-bot:
[pywikibot/core@master] [compat2core] Fix regressions of multiple Page methods

https://gerrit.wikimedia.org/r/463660

xSavitar moved this task from Backlog to Needs Review on the Pywikibot board.Nov 5 2018, 11:27 AM

Xqt closed this task as Resolved.Oct 28 2020, 4:58 AM

Xqt reassigned this task from Xqt to Dvorapa.

Change 407892 abandoned by Xqt:
[pywikibot/core@master] [bugfix] Page.linkedPages() is a PageGenerator not a list

Reason: