Links to items & properties in client recent changes are now redlinks
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	matej_suchanek
	Feb 10 2018, 11:14 AM

Description

This is a screenshot from Wikidata-only recent changes on English Wikipedia:

Details

	Subject	Repo	Branch	Lines +/-
	Add federation-related configs for clients	operations/mediawiki-config	master	+22 -0
	Use the "old-style" database settings for changesDatabase and repoSiteId	mediawiki/extensions/Wikibase	master	+9 -2

Customize query in gerrit

Related Objects

Duplicates Merged Here: T187188: Edit summaries imported from Wikidata to Wikipedia should not contain red links to Wikidata pages
T187086: QuickStatements edit summaries for Wikidata edits link to the local wiki instead of to Wikidata

Event Timeline

matej_suchanek created this task.Feb 10 2018, 11:14 AM

Restricted Application added a project: Wikidata. · View Herald TranscriptFeb 10 2018, 11:14 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Liuxinyu970226 subscribed.Feb 10 2018, 11:15 AM

@Ladsgroup could you have a look please?

I'm in bus atm. Will take a look in five hours or so. Maybe sooner if I can get my laptop out.

Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptFeb 10 2018, 2:06 PM

Looking at the database, rc_comment in field is the same everywhere, so either: 1- This issue has not been introduced recently (and users started to report it now) which is unlikely OR 2- ChangeLinkFormatter (or Linker::formatComment) introduced this regression. Looking in it more depth atm.

Change 409622 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[operations/mediawiki-config@master] Add federation-related configs for clients

https://gerrit.wikimedia.org/r/409622

gerritbot added a project: Patch-For-Review.Feb 10 2018, 7:26 PM

After several hours of looking at codes, trying to reproduce it and interesting revelations such as RC injection is completely broken on beta, I think this will help getting the issue handled. It might not. I will deploy this on Monday and check the status.

thiemowmde triaged this task as High priority.Feb 12 2018, 2:44 PM

thiemowmde moved this task from incoming to in progress on the Wikidata board.

thiemowmde added a project: Wikidata-Sprint-2018-01-31.

thiemowmde moved this task from Backlog to Review on the Wikidata-Sprint-2018-01-31 board.

matej_suchanek merged a task: T187086: QuickStatements edit summaries for Wikidata edits link to the local wiki instead of to Wikidata.Feb 12 2018, 4:17 PM

matej_suchanek added a subscriber: Jc86035.

Change 410133 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/Wikibase@master] Use backwards-compatible settings for changesDatabase and repoSiteId

https://gerrit.wikimedia.org/r/410133

WMDE-leszek renamed this task from Links to items & properties in client recent changes are now redlinks to Links to items & properties in client recent changes are now redlinks (days: 1).Feb 13 2018, 11:08 AM

WMDE-leszek renamed this task from Links to items & properties in client recent changes are now redlinks (days: 1) to Links to items & properties in client recent changes are now redlinks.Feb 13 2018, 12:32 PM

WMDE-leszek moved this task from Review to Done on the Wikidata-Sprint-2018-01-31 board.

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)).Feb 13 2018, 1:01 PM

Lydia_Pintscher merged a task: T187188: Edit summaries imported from Wikidata to Wikipedia should not contain red links to Wikidata pages.Feb 13 2018, 1:51 PM

Lydia_Pintscher added a subscriber: Pigsonthewing.

Ladsgroup removed Ladsgroup as the assignee of this task.Feb 14 2018, 12:12 AM

Ladsgroup removed a project: Patch-For-Review.

I have just verified it had been fixed. Should this still be open?

I assume no.

Liuxinyu970226 unsubscribed.Jun 11 2018, 3:48 AM

Change 409622 abandoned by Ladsgroup:
Add federation-related configs for clients