Extra span at beginning of mobile-sections-lead
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• bearND
	Feb 12 2018, 5:49 PM

Description

Some pages start with an extraneous <span>. This has the negative consequence of our summary code picking up the incorrect intro paragraph in theses cases if we use mobile-sections-lead as the input[1]. If we use straight Parsoid html that is not an issue.

[1] See patch rGMOA9ce0818f3f29.

Examples

http://localhost:6928/de.wikipedia.org/v1/page/summary/B%C3%BCrgerkrieg_in_Syrien
https://de.wikipedia.org/api/rest_v1/page/mobile-sections-lead/B%C3%BCrgerkrieg_in_Syrien/173442308

"text": "<span><p>Der <b>Bürgerkrieg in Syrien</b>

https://de.wikipedia.org/api/rest_v1/page/html/B%C3%BCrgerkrieg_in_Syrien/173442308

<span about="#mwt1" typeof="mw:Transclusion"

https://bg.wikipedia.org/api/rest_v1/page/mobile-sections-lead/%D0%94%D0%B0%D0%BD%D0%B8%D1%8F/8341068
https://bg.m.wikipedia.org/api/rest_v1/page/mobile-sections-lead/%D0%9E%D0%BB%D0%BE%D0%B2%D0%BE/8055614

How to fix

Replace the first paragraph relocation transform with the page library one for the mobile-sections endpoint.

Details

	Subject	Repo	Branch	Lines +/-
	Mobile-sections: Use PCS version of relocateFirstParagraph	mediawiki/services/mobileapps	master	+11 -123

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	None	T169242 Develop Page Content Service for Reading Clients
Resolved	None	T177425 Develop General Layer of PCS
Resolved	• Jhernandez	T177426 Develop structured JSON APIs for general consumption
Resolved	• Mholloway	T177431 Develop a Summary JSON API
Declined	None	T184753 Use stored page leads when creating page summaries to reduce MCS load
Resolved	• Mholloway	T187098 Extra span at beginning of mobile-sections-lead

Event Timeline

• bearND created this task.Feb 12 2018, 5:49 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 12 2018, 5:49 PM

• bearND updated the task description. (Show Details)Feb 12 2018, 5:51 PM

• bearND added a parent task: T184753: Use stored page leads when creating page summaries to reduce MCS load.Feb 12 2018, 6:11 PM

• Mholloway mentioned this in T184753: Use stored page leads when creating page summaries to reduce MCS load.Feb 12 2018, 6:37 PM

• Mholloway subscribed.

• bearND triaged this task as Low priority.Jun 7 2018, 5:07 PM

We could do the the same as T170584, which means this would be replacing the old relocateFirstParagraph transform with the new one from page-lib.

So this task is about replacing the first paragraph relocation transform with the page library one for the mobile-sections-lead endpoint?

Yes, it's done for the new PCS endpoint. We should also do it for the mobile-sections endpoint. I think this
can come after the content-html endpoint is finished.

• Jhernandez raised the priority of this task from Low to Medium.Jul 7 2018, 12:21 PM

• Jhernandez edited projects, added Product-Infrastructure-Team-Backlog-Deprecated, Mobile-Content-Service; removed Product-Infrastructure-Team-Backlog-Deprecated (Kanban).

• Jhernandez moved this task from Needs triage to Backlog on the Product-Infrastructure-Team-Backlog-Deprecated board.

• Jhernandez updated the task description. (Show Details)

• Jhernandez moved this task from Backlog to Upcoming on the Product-Infrastructure-Team-Backlog-Deprecated board.Jul 11 2018, 3:50 PM

• Jhernandez edited projects, added Product-Infrastructure-Team-Backlog-Deprecated (Kanban); removed Product-Infrastructure-Team-Backlog-Deprecated.Jul 12 2018, 11:51 AM

Change 461283 had a related patch set uploaded (by Mholloway; owner: Mholloway):
[mediawiki/services/mobileapps@master] Mobile-sections: Use PCS version of relocateFirstParagraph

https://gerrit.wikimedia.org/r/461283

gerritbot added a project: Patch-For-Review.Sep 19 2018, 6:48 AM

• Mholloway claimed this task.Sep 19 2018, 6:50 AM

• Mholloway moved this task from To Do to Code Review on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.

Change 461283 merged by jenkins-bot:
[mediawiki/services/mobileapps@master] Mobile-sections: Use PCS version of relocateFirstParagraph

https://gerrit.wikimedia.org/r/461283

• Mholloway moved this task from Code Review to To Deploy on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Sep 21 2018, 7:07 AM

Mentioned in SAL (#wikimedia-operations) [2018-09-24T20:23:46Z] <bsitzmann@deploy1001> Started deploy [mobileapps/deploy@4be131b]: Update mobileapps to badb463 (T187098 T195838)

Stashbot mentioned this in T195838: Document the announcement endpoint config parameters.Sep 24 2018, 8:23 PM

Mentioned in SAL (#wikimedia-operations) [2018-09-24T20:28:17Z] <bsitzmann@deploy1001> Finished deploy [mobileapps/deploy@4be131b]: Update mobileapps to badb463 (T187098 T195838) (duration: 04m 31s)