Page MenuHomePhabricator
Create Task
Maniphest T188313

Fix safeguard for empty condition list in WikiPageEntityMetaDataLookup
Closed, ResolvedPublic
Actions

Description

WikiPageEntityMetaDataLookup::getWhere has a special guard against an empty condition list for the query:

		if ( empty( $where ) ) {
			// If we skipped all entity IDs, select nothing, not everything.
			return '0';
		}

However, Database::selectSQLText actually interprets that '0' as “no conditions” (same as []), which results in a query without WHERE clause. Make sure we return something better. ([ false ]?)

Part of https://wikitech.wikimedia.org/wiki/Incident_documentation/20180226-WikibaseQualityConstraints.

Details

SubjectRepoBranchLines +/-
Fix empty condition list in metadata lookupmediawiki/extensions/Wikibasewmf/1.31.0-wmf.23+16 -1
Fix empty condition list in metadata lookupmediawiki/extensions/Wikibasemaster+16 -1
DNM: add test without fixing bugmediawiki/extensions/Wikibasemaster+12 -0
Customize query in gerrit

Event Timeline

Lucas_Werkmeister_WMDE created this task.Feb 26 2018, 8:31 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 26 2018, 8:31 PM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Feb 26 2018, 10:54 PM
Lucas_Werkmeister_WMDE moved this task from Active investigation to Follow-up prevention on the Wikimedia-Incident board.Feb 27 2018, 10:19 AM
Lucas_Werkmeister_WMDE added a project: Wikidata-Sprint-2018-02-28.Feb 27 2018, 1:30 PM
Lydia_Pintscher moved this task from incoming to in progress on the Wikidata board.Feb 27 2018, 1:35 PM
Lucas_Werkmeister_WMDE added a subscriber: daniel.Feb 27 2018, 5:31 PM

By the way, the safeguard was introduced by @daniel in Ie2e0b4d096 “Protected against unknown entity namespace”. (Not intended as blame, just for notification.)

daniel added a comment.Feb 27 2018, 5:59 PM

I think [ false ] would result in WHERE (), which is a syntax error. I'd probably go for '1=2'.

gerritbot subscribed.Feb 27 2018, 6:31 PM

Change 415064 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] DNM: add test without fixing bug

https://gerrit.wikimedia.org/r/415064

gerritbot added a project: Patch-For-Review.Feb 27 2018, 6:31 PM
gerritbot added a comment.Feb 27 2018, 6:41 PM

Change 415064 abandoned by Lucas Werkmeister (WMDE):
DNM: add test without fixing bug

Reason:
Nevermind, I got a working setup now. And it’ll look better on the task if I abandon this change and upload a new one instead of updating this one… I didn’t think this through :)

https://gerrit.wikimedia.org/r/415064

gerritbot added a comment.Feb 27 2018, 6:50 PM

Change 415071 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Fix empty condition list in metadata lookup

https://gerrit.wikimedia.org/r/415071

gerritbot added a comment.Feb 27 2018, 8:00 PM

Change 415071 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Fix empty condition list in metadata lookup

https://gerrit.wikimedia.org/r/415071

Lucas_Werkmeister_WMDE closed this task as Resolved.Feb 27 2018, 10:42 PM
Lucas_Werkmeister_WMDE claimed this task.
Lucas_Werkmeister_WMDE edited projects, added Wikidata-Sprint-2018-02-14; removed Wikidata-Sprint-2018-02-28.
Lucas_Werkmeister_WMDE moved this task from Backlog to Done on the Wikidata-Sprint-2018-02-14 board.
gerritbot added a comment.Feb 28 2018, 4:16 PM

Change 415319 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@wmf/1.31.0-wmf.23] Fix empty condition list in metadata lookup

https://gerrit.wikimedia.org/r/415319

gerritbot added a comment.Mar 5 2018, 7:56 PM

Change 415319 merged by Hashar:
[mediawiki/extensions/Wikibase@wmf/1.31.0-wmf.23] Fix empty condition list in metadata lookup

https://gerrit.wikimedia.org/r/415319

Stashbot subscribed.Mar 5 2018, 8:02 PM

Mentioned in SAL (#wikimedia-operations) [2018-03-05T20:02:00Z] <hashar@tin> Synchronized php-1.31.0-wmf.23/extensions/Wikibase: Fix empty condition list in metadata lookup - T188313 (duration: 01m 58s)

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)).Mar 6 2018, 10:01 AM
ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)); removed MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)).Mar 6 2018, 3:01 PM
Krinkle edited projects, added Sustainability (Incident Followup); removed Wikimedia-Incident.Apr 28 2020, 9:50 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 28 2020, 10:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL