Display custom amount values when passing by query string
Closed, ResolvedPublic3 Story Points

Description

As a user,
I want amounts that I entered into a banner form to be displayed on the donation page,
so that I'm confident that the application correctly handles my donation.

Acceptance Criteria:

  • Custom amounts passed in the query string are displayed in the form's custom amount field

Background:

  • This does not work in either skin (cat17, 10h16).
  • The amount is currently not being handled properly, so T183481 might be related to this task.

Examples:
https://spenden.wikimedia.de/?skin=10h16&amountGiven=9.20&zahlweise=BEZ&periode=0
https://spenden.wikimedia.de/?skin=cat17&amountGiven=9.20

Restricted Application added a project: WMDE-FUN-Team. · View Herald TranscriptMar 1 2018, 4:51 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
kai.nissen updated the task description. (Show Details)Mar 2 2018, 2:16 PM
kai.nissen set the point value for this task to 3.
kai.nissen moved this task from Backlog to Sprint ready on the WMDE-Fundraising-Tech board.

@kai.nissen There's a difference between the predefined amounts on the donation page depending on skin. On cat17 we have predefined amounts up to 300€, but on 10h16 they're up to 250€. Therefor our current solution fails when the amount given is 300€ and the 10h16 skin is used, because the application considers this a predefined amount but since it's not present in the UI, it's neither selected nor filled in the custom amount form.


We'd like to avoid configuring two different sets of predefined amounts for each skin. We have two proposals:

  • The best and least painful solution will be to add a component for 300€ in the old skin as well. Then the input for custom amount will be moved to the right.
  • We can add a piece of code that checks if the amount given is predefined but it's 300 so it's considered custom ( along with a giant comment explaining why it's there ) to the js for 10h16 skin.

We're really advocating for the first solution. :)

kai.nissen added a comment.EditedWed, Apr 4, 3:47 PM

I'm totally fine with the first solution in general. Not sure, if I understood correctly, but instead of

I propose this

and this

kai.nissen closed this task as Resolved.Wed, Apr 18, 1:17 PM